{"thread":{"id":"9069","subject":"Problem running git-gui","startedAt":"2007-07-17T11:48:22Z","lastAt":"2007-07-18T10:10:13Z","messageCount":13,"participants":["Julian Phillips","Thomas Glanzmann","Brian Downing","Jason Sewall","Linus Torvalds","Shawn O. Pearce","Martin Langhoff"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"47627","messageId":"Pine.LNX.4.64.0707171244080.13359@reaper.quantumfyre.co.uk","threadId":"9069","inReplyTo":null,"subject":"Problem running git-gui","fromName":"Julian Phillips","fromEmail":"julian@quantumfyre.co.uk","sentAt":"2007-07-17T11:48:22Z","receivedAt":"2007-07-17T11:48:22Z","isPatch":false,"sender":{"key":"julian@quantumfyre.co.uk","avatar":"https://avatars.githubusercontent.com/u/948888?v=4"},"body":"I have a machine on which git was installed from a tarball created by \nrunning git-archive on master (so a 1.5.3ish version).\n\nWhen I try running git-gui I get an error message:\n\n'Error in startup script: expected version number but got \"1.5.3.GIT\"'\n\nfollowed by what I assume is a code snippet where it failed (I wouldn't \nknow tcl if it hit me with a large brick).\n\nIs this expected? driver error? or maybe a bug?\n\n-- \nJulian\n\n ---\nmixed emotions:\n \tWatching a bus-load of lawyers plunge off a cliff.\n \tWith five empty seats.\n"},{"id":"47628","messageId":"20070717120453.GD7774@cip.informatik.uni-erlangen.de","threadId":"9069","inReplyTo":"Pine.LNX.4.64.0707171244080.13359@reaper.quantumfyre.co.uk","subject":"Re: Problem running git-gui","fromName":"Thomas Glanzmann","fromEmail":"thomas@glanzmann.de","sentAt":"2007-07-17T12:04:53Z","receivedAt":"2007-07-17T12:04:53Z","isPatch":false,"sender":{"key":"thomas@glanzmann.de","avatar":null},"body":"Hello Julian,\n\n> 'Error in startup script: expected version number but got \"1.5.3.GIT\"'\n\nI get the same error. However it works with released versions of git:\n\n\t(faui04a) [~] git gui\n\tError in startup script: invalid command name \"git-version\"\n\twhile executing\n\t\"git-version >= 1.5.3\"\n\t(in namespace eval \"::blame\" script line 36)\n\tinvoked from within\n\t\"namespace eval $class $body\"\n\t(procedure \"class\" line 16)\n\tinvoked from within\n\t\"class blame {\n\n\timage create photo ::blame::img_back_arrow -data {R0lGODlhGAAYAIUAAPwCBEzKXFTSZIz+nGzmhGzqfGTidIT+nEzGXHTqhGzmfGzifFzadETCVES+VARWDFzWb...\"\n\t(file \"/usr/share/git-gui/lib/blame.tcl\" line 4)\n\tinvoked from within\n\t\"source [file join $oguilib $p]\"\n\t(\"foreach\" body line 3)\n\tinvoked from within\n\t\"foreach p $idx {\n\t\t\tif {[lsearch -exact $loaded $p] >= 0} continue\n\t\t\tsource [file join $oguilib $p]\n\t\t\tlappend loaded $p\n\t\t}\"\n\tinvoked from within\n\t\"if {$idx ne {}} {\n\t\tset loaded [list]\n\t\tforeach p $idx {\n\t\t\tif {[lsearch -exact $loaded $p] >= 0} continue\n\t\t\tsource [file join $oguilib $p]\n\t\t\tlappend loa...\"\n\t(file \"/usr/bin/git-gui\" line 98)\n\nit is because \"1.5.3.GIT\" is not a number I guess.\n\n\tThomas\n"},{"id":"47674","messageId":"20070717212103.11950.10363.julian@quantumfyre.co.uk","threadId":"9069","inReplyTo":"Pine.LNX.4.64.0707171244080.13359@reaper.quantumfyre.co.uk","subject":"[PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Julian Phillips","fromEmail":"julian@quantumfyre.co.uk","sentAt":"2007-07-17T21:14:06Z","receivedAt":"2007-07-17T21:14:06Z","isPatch":true,"sender":{"key":"julian@quantumfyre.co.uk","avatar":"https://avatars.githubusercontent.com/u/948888?v=4"},"body":"The git-gui version check doesn't handle versions of the form\nn.n.n.GIT which you can get by installing from an tarball produced by\ngit-archive.\n\nWithout this change you get an error of the form:\n'Error in startup script: expected version number but got \"1.5.3.GIT\"'\n\nSigned-off-by: Julian Phillips \n---\n\n> I have a machine on which git was installed from a tarball created by \n> running git-archive on master (so a 1.5.3ish version).\n> \n> When I try running git-gui I get an error message:\n> \n> 'Error in startup script: expected version number but got \"1.5.3.GIT\"'\n> \n> followed by what I assume is a code snippet where it failed (I wouldn't \n> know tcl if it hit me with a large brick).\n> \n> Is this expected? driver error? or maybe a bug?\n\nWell, whichever it is, this seems to fix it for me ... with the proviso that I\nstill no nothing about tcl. I am also not sure if it is correct to do the\npatch against the git repo?\n\n git-gui/git-gui.sh | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 2077261..f8b1f10 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -546,6 +546,7 @@ if {![regsub {^git version } $_git_version {} _git_version]} {\n }\n regsub {\\.[0-9]+\\.g[0-9a-f]+$} $_git_version {} _git_version\n regsub {\\.rc[0-9]+$} $_git_version {} _git_version\n+regsub {\\.GIT$} $_git_version {} _git_version\n \n proc git-version {args} {\n \tglobal _git_version\n-- \n1.5.2.2\n"},{"id":"47675","messageId":"20070717214011.GU19073@lavos.net","threadId":"9069","inReplyTo":"20070717212103.11950.10363.julian@quantumfyre.co.uk","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-07-17T21:40:12Z","receivedAt":"2007-07-17T21:40:12Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"On Tue, Jul 17, 2007 at 10:14:06PM +0100, Julian Phillips wrote:\n> The git-gui version check doesn't handle versions of the form\n> n.n.n.GIT which you can get by installing from an tarball produced by\n> git-archive.\n> \n> Without this change you get an error of the form:\n> 'Error in startup script: expected version number but got \"1.5.3.GIT\"'\n\nCan we handle versions with '-dirty' at the end as well, or is this\nill-advised? For some reason when I build my hacked-up personal debian\npackages it usually winds up:\n\n:; git --version\ngit version 1.5.3.GIT-dirty\n\nand I haven't bothered to find out why.\n\n-bcd\n"},{"id":"47676","messageId":"20070717214510.GV19073@lavos.net","threadId":"9069","inReplyTo":"20070717214011.GU19073@lavos.net","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-07-17T21:45:10Z","receivedAt":"2007-07-17T21:45:10Z","isPatch":true,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"On Tue, Jul 17, 2007 at 04:40:12PM -0500, Brian Downing wrote:\n> Can we handle versions with '-dirty' at the end as well, or is this\n> ill-advised? For some reason when I build my hacked-up personal debian\n> packages it usually winds up:\n> \n> :; git --version\n> git version 1.5.3.GIT-dirty\n> \n> and I haven't bothered to find out why.\n\nD'oh, now I know why. I'm trying git to keep my home directory config\nstuff versioned, so GIT-VERSION-GEN, failing to find a .git directory\nin my tar export, digs down and finds my home directory one instead.\n\nI take it this means that keeping your home directory under git\n/directly/ as I have chosen to do is a bad idea...\n\n-bcd\n"},{"id":"47677","messageId":"31e9dd080707171449r26c430f1vacfb58eb00f578e5@mail.gmail.com","threadId":"9069","inReplyTo":"20070717214510.GV19073@lavos.net","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Jason Sewall","fromEmail":"jasonsewall@gmail.com","sentAt":"2007-07-17T21:49:36Z","receivedAt":"2007-07-17T21:49:36Z","isPatch":true,"sender":{"key":"jasonsewall@gmail.com","avatar":null},"body":"On 7/17/07, Brian Downing wrote:\n> I take it this means that keeping your home directory under git\n> /directly/ as I have chosen to do is a bad idea...\n\nInteresting, because this is something I've wanted to do - I use\nseveral machines (work, work laptop, home, home laptop) and I'm always\ntweaking my various dotfiles... I could really use a way to keep them\nall synchronized.\n\nJust out of curiosity, what do you people do?\n\nJason\n"},{"id":"47678","messageId":"alpine.LFD.0.999.0707171532070.27353@woody.linux-foundation.org","threadId":"9069","inReplyTo":"20070717214510.GV19073@lavos.net","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2007-07-17T22:34:36Z","receivedAt":"2007-07-17T22:34:36Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Tue, 17 Jul 2007, Brian Downing wrote:\n> \n> D'oh, now I know why. I'm trying git to keep my home directory config\n> stuff versioned, so GIT-VERSION-GEN, failing to find a .git directory\n> in my tar export, digs down and finds my home directory one instead.\n\nOk, that's definitely a git misfeature.\n\nI think we could probably add a check something like:\n\n - once we have found a .git directory by walking up the tree, the \n directory we actually came _from_ should then be tracked by that git \n directory.\n\nbut I wonder how to do that properly (we would probably need to load the \nindex, which we generally don't want to do).\n\n\t\tLinus\n"},{"id":"47688","messageId":"20070718014806.GQ32566@spearce.org","threadId":"9069","inReplyTo":"31e9dd080707171449r26c430f1vacfb58eb00f578e5@mail.gmail.com","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-18T01:48:06Z","receivedAt":"2007-07-18T01:48:06Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Jason Sewall wrote:\n> On 7/17/07, Brian Downing wrote:\n> >I take it this means that keeping your home directory under git\n> >/directly/ as I have chosen to do is a bad idea...\n> \n> Interesting, because this is something I've wanted to do - I use\n> several machines (work, work laptop, home, home laptop) and I'm always\n> tweaking my various dotfiles... I could really use a way to keep them\n> all synchronized.\n> \n> Just out of curiosity, what do you people do?\n\nI have a regular git directory in ~/cgwork/HomeDir, with its\nassociated .git directory in ~/cgwork/HomeDir/.git. In other\nwords standard Git repository setup in a location that isn't my\nactual home directory.\n\nMy dotfiles in ~/ are actually symlinks back to that Git repository.\nTo update the symlinks I run the script below. Its pretty simple,\nit just merges to directories from the Git repository into my ~/\nas dotfiles (the dot-* items) and into my ~/bin (the bin/* items).\nSo my Git repository looks like this:\n\n $ git ls-tree --abbrev=4 HEAD\n 040000 tree 0d35 common\n 040000 tree e033 host-asimov\n 040000 tree 21c4 host-spearce-pb15.local\n 100755 blob 0f2d relink.sh\n\n $ git ls-tree --abbrev=4 HEAD:common/\n 040000 tree cc76 bin\n 100644 blob 371e dot-bash_profile\n 100644 blob e675 dot-bashrc\n 100644 blob 1f0a dot-gitconfig\n 100644 blob 3d02 dot-ldaprc\n 100644 blob 1d42 dot-vilerc\n\n $ git ls-tree --abbrev=4 HEAD:common/bin/\n 100755 blob 7322 cherry-kill\n 100755 blob 9ed5 fp\n 100755 blob 89f2 genbibtex\n 100755 blob 68be newrepo\n 100755 blob 3759 tkbibtex\n\n $ ls -l ~/.bashrc ~/bin/fp\n lrwxr-xr-x 1 spearce spearce 41 Feb 3 23:05 /Users/spearce/.bashrc -> cgwork/HomeDir-DotFiles/common/dot-bashrc\n lrwxr-xr-x 1 spearce spearce 40 Feb 3 23:05 /Users/spearce/bin/fp -> ../cgwork/HomeDir-DotFiles/common/bin/fp\n\nYea, it relies on the fact that I never use `git config --global`,\nwhich apparently I've done recently as the damn thing isn't a symlink\nlike its supposed to be. Uggh. Its the *only* program on my system\nthat doesn't resolve the symlink and edit the file it points at.\n\n-->--\n#!/bin/sh\n\nroot=`dirname \"$0\"`\n[ -d \"$root\" ] || {\n\techo \"error: Can't locate $0 in filesystem.\" >&2\n\texit 1\n}\n\ncd \"$root\"\nroot=$(pwd)\nroot=$(echo \"$root\" | sed s:^$HOME/::)\n\nif [ \"X$HOSTTYPE\" = Xpowerpc ]\nthen\n\tHOSTNAME=spearce-pb15.local\nfi\n\ndot_sources=\"common/dot-* host-$HOSTNAME/dot-*\"\nbin_sources=\"common/bin/* host-$HOSTNAME/bin/*\"\n\necho \"Linking from $dot_sources\"\nfor src in $dot_sources\ndo\n\tif [ -e \"$src\" ]\n\tthen\n\t\tdot_file=$(basename \"$src\" | sed s/^dot-/./)\n\n\t\ttarg=\"$root/$src\"\n\t\tdest=\"$HOME/$dot_file\"\n\n\t\tif [ -L \"$dest\" ]\n\t\tthen\n\t\t\techo \" U $dest -> $targ\"\n\t\t\trm -f \"$dest\"\n\t\t\tln -s \"$targ\" \"$dest\"\n\t\t\tcontinue\n\t\tfi\n\n\t\tif [ ! -e \"$dest\" ]\n\t\tthen\n\t\t\techo \" N $dest -> $targ\"\n\t\t\tln -s \"$targ\" \"$dest\"\n\t\t\tcontinue\n\t\tfi\n\n\t\tif [ -e \"$dest\" -a ! -e \"$dest.bak\" ]\n\t\tthen\n\t\t\techo \" O $dest -> $targ\"\n\t\t\tmv \"$dest\" \"$dest.bak\"\n\t\t\tln -s \"$targ\" \"$dest\"\n\t\t\tcontinue\n\t\tfi\n\n\t\techo \" ! $dest -> $targ\"\n\tfi\ndone\necho \"done.\"\n\necho\necho \"Linking from $bin_sources\"\nfor src in $bin_sources\ndo\n\tif [ -e \"$src\" ]\n\tthen\n\t\tbin_file=$(basename \"$src\")\n\n\t\tcase \"$root\" in\n\t\t/*) targ=\"$root/$src\";;\n\t\t*) targ=\"../$root/$src\"\n\t\tesac\n\t\tdest=\"$HOME/bin/$bin_file\"\n\n\t\tmkdir -p \"$HOME/bin\"\n\n\t\tif [ -L \"$dest\" ]\n\t\tthen\n\t\t\techo \" U $dest -> $targ\"\n\t\t\trm -f \"$dest\"\n\t\t\tln -s \"$targ\" \"$dest\"\n\t\t\tcontinue\n\t\tfi\n\n\t\tif [ ! -e \"$dest\" ]\n\t\tthen\n\t\t\techo \" N $dest -> $targ\"\n\t\t\tln -s \"$targ\" \"$dest\"\n\t\t\tcontinue\n\t\tfi\n\n\t\tif [ -e \"$dest\" -a ! -e \"$dest.bak\" ]\n\t\tthen\n\t\t\techo \" O $dest -> $targ\"\n\t\t\tmv \"$dest\" \"$dest.bak\"\n\t\t\tchmod a-x \"$dest.bak\"\n\t\t\tln -s \"$targ\" \"$dest\"\n\t\t\tcontinue\n\t\tfi\n\n\t\techo \" ! $dest -> $targ\"\n\tfi\ndone\necho \"done.\"\n-->--\n\n-- \nShawn.\n"},{"id":"47689","messageId":"20070718015138.GR32566@spearce.org","threadId":"9069","inReplyTo":"20070717212103.11950.10363.julian@quantumfyre.co.uk","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-18T01:51:38Z","receivedAt":"2007-07-18T01:51:38Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Julian Phillips wrote:\n> > 'Error in startup script: expected version number but got \"1.5.3.GIT\"'\n> > \n> > followed by what I assume is a code snippet where it failed (I wouldn't \n> > know tcl if it hit me with a large brick).\n> > \n> > Is this expected? driver error? or maybe a bug?\n\nBug in git-gui. *sigh*\n \n> Well, whichever it is, this seems to fix it for me ... with the proviso that I\n> still no nothing about tcl. I am also not sure if it is correct to do the\n> patch against the git repo?\n> \n> git-gui/git-gui.sh | 1 +\n> 1 files changed, 1 insertions(+), 0 deletions(-)\n\nMany thanks for the fix. I was about to do this myself but found\nyour message in my inbox instead. Happy days.\n\nFortunately git-am -3 does wonders, and it didn't matter:\n\n $ git am -s -3 jp\n \n Applying git-gui: Handle git versions of the form n.n.n.GIT\n \n error: git-gui/git-gui.sh: does not exist in index\n Using index info to reconstruct a base tree...\n Falling back to patching base and 3-way merge...\n Renamed git-gui/git-gui.sh => git-gui.sh\n Wrote tree 1909733645c3bd167b1b28a98ee66c0a95f357f1\n Committed: 91464dfb102d6143182d8f312b68486e9dceb103\n\nI've extolled the virtues of -3 and merge-recursive's rename detector\nbefore on the mailing list, for exactly this reason. Despite the\npatch coming in with the wrong path it still applies just fine.\n\n-- \nShawn.\n"},{"id":"47690","messageId":"20070718015210.GS32566@spearce.org","threadId":"9069","inReplyTo":"20070717214011.GU19073@lavos.net","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-18T01:52:10Z","receivedAt":"2007-07-18T01:52:10Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Brian Downing wrote:\n> Can we handle versions with '-dirty' at the end as well, or is this\n> ill-advised? For some reason when I build my hacked-up personal debian\n> packages it usually winds up:\n> \n> :; git --version\n> git version 1.5.3.GIT-dirty\n> \n> and I haven't bothered to find out why.\n\nAlready fixed. Please get the latest version of git-gui...\n\n-- \nShawn.\n"},{"id":"47693","messageId":"46a038f90707171932m67c51388jb2304f0b1873e3a6@mail.gmail.com","threadId":"9069","inReplyTo":"20070718015138.GR32566@spearce.org","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2007-07-18T02:32:50Z","receivedAt":"2007-07-18T02:32:50Z","isPatch":true,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 7/17/07, Shawn O. Pearce wrote:\n> Applying git-gui: Handle git versions of the form n.n.n.GIT\n>\n\nI'm far from an authority on things TCL, but I don't think this patch\nshould be merged as is. Julian is reporting it as a \"fixes my symptom\"\npatch, and that's barely what it does.\n\nThe regex should be more liberal, imho. With this superficial fix:\n\n - Builds from a dirty tree have a broken git gui\n\n - Builds from a repo with a nonstandard (local) tagname tagname have\na broken git gui\n\ncheers,\n\n\nmartin\n"},{"id":"47695","messageId":"20070718025442.GX32566@spearce.org","threadId":"9069","inReplyTo":"46a038f90707171932m67c51388jb2304f0b1873e3a6@mail.gmail.com","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-18T02:54:42Z","receivedAt":"2007-07-18T02:54:42Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Martin Langhoff wrote:\n> On 7/17/07, Shawn O. Pearce wrote:\n> > Applying git-gui: Handle git versions of the form n.n.n.GIT\n> >\n> \n> I'm far from an authority on things TCL, but I don't think this patch\n> should be merged as is.\n\nToo late, already applied and pushed. ;-)\n\n> Julian is reporting it as a \"fixes my symptom\"\n> patch, and that's barely what it does.\n> \n> The regex should be more liberal, imho. With this superficial fix:\n\nI think we are now cleaning up the Git version as best we can:\n\n regsub -- {-dirty$} $_git_version {} _git_version\n regsub {\\.[0-9]+\\.g[0-9a-f]+$} $_git_version {} _git_version\n regsub {\\.rc[0-9]+$} $_git_version {} _git_version\n regsub {\\.GIT$} $_git_version {} _git_version\n\nThe first fixes the -dirty build problem. The second drops off\nthe extra information that git-describe throws into the mix when\nit generates output for a non-tagged commit. The third kills the\nrc* component if this is a release candidate. Note that the rc*\nkiller must come after the git-describe killer, as the rc* part is\nactually in the real tag. The last one fixes the weird case where\nthe user has somehow bungled his git software distribution so it\ncannot generate a git version via git-describe *and* they have no\n`version` file in the source code directory. Such people really\nshould fix their git. But anyway we do support it now.\n\n> - Builds from a repo with a nonstandard (local) tagname tagname have\n> a broken git gui\n\nThis I cannot do anything about, other than maybe to warn the user\nthat they are about to run with a version of Git that we cannot\nverify and hence we have no idea if git-gui will work correctly,\nor fall flat on its face.\n\nI'll add in a confirmation dialog for this case. That way the\nuser can make the decision. User always knows best.\n\n-- \nShawn.\n"},{"id":"47719","messageId":"Pine.LNX.4.64.0707181102100.19849@reaper.quantumfyre.co.uk","threadId":"9069","inReplyTo":"20070718025442.GX32566@spearce.org","subject":"Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT","fromName":"Julian Phillips","fromEmail":"julian@quantumfyre.co.uk","sentAt":"2007-07-18T10:10:13Z","receivedAt":"2007-07-18T10:10:13Z","isPatch":true,"sender":{"key":"julian@quantumfyre.co.uk","avatar":"https://avatars.githubusercontent.com/u/948888?v=4"},"body":"On Tue, 17 Jul 2007, Shawn O. Pearce wrote:\n\n> The first fixes the -dirty build problem. The second drops off\n> the extra information that git-describe throws into the mix when\n> it generates output for a non-tagged commit. The third kills the\n> rc* component if this is a release candidate. Note that the rc*\n> killer must come after the git-describe killer, as the rc* part is\n> actually in the real tag. The last one fixes the weird case where\n> the user has somehow bungled his git software distribution so it\n> cannot generate a git version via git-describe *and* they have no\n> `version` file in the source code directory. Such people really\n> should fix their git. But anyway we do support it now.\n\nWell, I would say that my git is not broken, but simply temporary. I \nhave a machine that is not connected to the internet where I want to run \ngit. Normally I use release tarballs, but at the moment I need the recent \nchanges to fast-import, so I am running whatever was master at the time I \nmade the tarball.\n\nAs soon as 1.5.3 comes out I will be back to using the official releases. \nI just wanted to run git-gui blame (a rather nice tool) to look at what \nthe result of my latest test import looked like. Since I wasn't using git \nfor anything other than playing with fast-import, creating a properly \nversioned git seemed like more effort than it was worth.\n\n-- \nJulian\n\n ---\nThe major difference between bonds and bond traders is that the bonds will\neventually mature.\n"}]}