{"thread":{"id":"9017","subject":"failing to send patches to the list","startedAt":"2007-07-13T09:30:50Z","lastAt":"2007-07-14T10:54:55Z","messageCount":9,"participants":["martin f krafft","Alex Riesen","Jeff King","Jakub Narebski","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"47246","messageId":"20070713093050.GA18001@lapse.madduck.net","threadId":"9017","inReplyTo":null,"subject":"failing to send patches to the list","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-07-13T09:30:50Z","receivedAt":"2007-07-13T09:30:50Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"Dear list,\n\nattached you may find two patches, which I've previously sent to the\nlist with\n\n git format-patch -s --stdout | sendmail git@vger.kernel.org\n\nEven though my mail server seems to have delivered them correctly:\n\n Jul 13 10:53:32 albatross postfix/smtp[29758]: C404D895D6F:\n to=,\n relay=vger.kernel.org[209.132.176.167]:25, delay=2.2,\n delays=0.08/0.04/0.56/1.6, dsn=2.7.1, status=sent (250 2.7.1 Looks\n like Linux source DIFF email.. BF:; S932911AbXGMIxb)\n\nthey never made it onto the list.\n\nWhat am I doing wrong?\n\nShould I resubmit the patches or is this enough for now?\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \nspamtraps: madduck.bogus@madduck.net\n \nall software projects are done by iterative prototyping.\nsome companies call their prototypes \"releases\", that's all.\n\n\nFrom 7b2bb44f78b8bc691bbc1445c6c333fdc281a788 Mon Sep 17 00:00:00 2001\nFrom: martin f. krafft \nDate: Fri, 13 Jul 2007 11:09:05 +0200\nSubject: [PATCH] fall back to mozilla's sha.h if openssl/sha.h is not available\n\nUses $(CPP) to attempt to preprocess an include directive. If\nthat fails, NO_OPENSSL is defined, causing the Makefile to fall back to using\nmozilla's SHA implementation.\n\nSigned-off-by: martin f. krafft \n---\n Makefile | 6 ++++++\n 1 files changed, 6 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex d7541b4..1676343 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -532,6 +532,12 @@ ifndef NO_CURL\n \tendif\n endif\n \n+HAS_OPENSSL := $(shell echo \"\\#include \" \\\n+\t\t\t| $(CPP) -o/dev/null - 2>/dev/null || echo no)\n+ifeq \"$(HAS_OPENSSL)\" \"no\"\n+\tNO_OPENSSL = \"openssl_sha.h_not_found\"\n+endif\n+\n ifndef NO_OPENSSL\n \tOPENSSL_LIBSSL = -lssl\n \tifdef OPENSSLDIR\n-- \n1.5.3.rc1.7.gcae4\n\n\n\nFrom 5f537c75774c5c0b45b74585ace4178738f251f0 Mon Sep 17 00:00:00 2001\nFrom: martin f. krafft \nDate: Fri, 13 Jul 2007 11:09:46 +0200\nSubject: [PATCH] Provide --stdlayout option for git-svn to set trunk,tags,branches to defaults\n\nThe --stdlayout option to git-svn init initialises the default Subversion\nvalues of trunk,tags,branches: -T trunk -b branches -t tags. If any of the\n-T/-t/-b options are given in addition, they are given preference.\n\nSigned-off-by: martin f. krafft \n---\n Documentation/git-svn.txt | 6 +++++-\n git-svn.perl | 8 +++++++-\n 2 files changed, 12 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 0a210e4..9e74b27 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -44,10 +44,14 @@ COMMANDS\n --tags=;;\n -b;;\n --branches=;;\n+--stdlayout;;\n \tThese are optional command-line options for init. Each of\n \tthese flags can point to a relative repository path\n \t(--tags=project/tags') or a full url\n-\t(--tags=https://foo.org/project/tags)\n+\t(--tags=https://foo.org/project/tags). The option --stdlayout is\n+\ta shorthand way of setting trunk,tags,branches as the relative paths,\n+\twhich is the Subversion default. If any of the other options are given\n+\tas well, they take precedence.\n --no-metadata;;\n \tSet the 'noMetadata' option in the [svn-remote] config.\n --use-svm-props;;\ndiff --git a/git-svn.perl b/git-svn.perl\nindex b3dffcc..5b443ee 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -77,11 +77,12 @@ my %fc_opts = ( 'follow-parent|follow!' => \\$Git::SVN::_follow_parent,\n \t\t \\$Git::SVN::_repack_flags,\n \t\t%remote_opts );\n \n-my ($_trunk, $_tags, $_branches);\n+my ($_trunk, $_tags, $_branches, $_stdlayout);\n my %icv;\n my %init_opts = ( 'template=s' => \\$_template, 'shared:s' => \\$_shared,\n 'trunk|T=s' => \\$_trunk, 'tags|t=s' => \\$_tags,\n 'branches|b=s' => \\$_branches, 'prefix=s' => \\$_prefix,\n+ 'stdlayout' => \\$_stdlayout,\n 'minimize-url|m' => \\$Git::SVN::_minimize_url,\n \t\t 'no-metadata' => sub { $icv{noMetadata} = 1 },\n \t\t 'use-svm-props' => sub { $icv{useSvmProps} = 1 },\n@@ -296,6 +297,11 @@ sub cmd_clone {\n \t $url !~ m#^[a-z\\+]+://#) {\n \t\t$path = $url;\n \t}\n+ if (defined $_stdlayout) {\n+ $_trunk = 'trunk' if (!defined $_trunk);\n+ $_tags = 'tags' if (!defined $_tags);\n+ $_branches = 'branches' if (!defined $_branches);\n+ }\n \t$path = basename($url) if !defined $path || !length $path;\n \tcmd_init($url, $path);\n \tGit::SVN::fetch_all($Git::SVN::default_repo_id);\n-- \n1.5.3.rc1.7.gcae4\n\n"},{"id":"47251","messageId":"20070713095644.GA26743@lapse.madduck.net","threadId":"9017","inReplyTo":"20070713093050.GA18001@lapse.madduck.net","subject":"git-svn patch faulty (was: failing to send patches to the list)","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-07-13T09:56:44Z","receivedAt":"2007-07-13T09:56:44Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"Hi there,\n\nstill not having figured out the problem with the list (and I did\ncontact postmaster@), I just discovered that in fact the patch only\nhandles git-svn clone, not git-svn init. Thus, it's best to ignore\nit for now. I am sorry for not taking enough care before publishing\nit.\n\nThe openssl-autodetect patch does work and is ready for inclusion,\nif you agree.\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \nspamtraps: madduck.bogus@madduck.net\n \n\"if builders built buildings the way\n programmers wrote programs,\n then the first woodpecker that came along\n would destroy civilization.\"\n -- gerald weinberg\n"},{"id":"47262","messageId":"81b0412b0707130557g6cf04365j232654734b148c3f@mail.gmail.com","threadId":"9017","inReplyTo":"20070713093050.GA18001@lapse.madduck.net","subject":"Re: failing to send patches to the list","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-07-13T12:57:36Z","receivedAt":"2007-07-13T12:57:36Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 7/13/07, martin f krafft wrote:\n> attached you may find two patches, which I've previously sent to the\n> list with\n>\n> git format-patch -s --stdout | sendmail git@vger.kernel.org\n>\n\nI suggest you try \"git format-patch -s --stdout |less\" before sending\nformat-patch without parameters produces nothing.\n\nEven assuming you run something like \"git-format-patch start..\"\n(note the range specification), its output is NOT what sendmail\ncan use (unless you have a special sendmail which understands\nmboxes).\n"},{"id":"47272","messageId":"20070713155516.GA2712@sigill.intra.peff.net","threadId":"9017","inReplyTo":"20070713093050.GA18001@lapse.madduck.net","subject":"Re: failing to send patches to the list","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-07-13T15:55:16Z","receivedAt":"2007-07-13T15:55:16Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jul 13, 2007 at 11:30:50AM +0200, martin f krafft wrote:\n\n> git format-patch -s --stdout | sendmail git@vger.kernel.org\n> \n> Even though my mail server seems to have delivered them correctly:\n> [...]\n> they never made it onto the list.\n\nvger will reject messages without a message-id. git-format-patch by\ndefault does not generate a message-id, so unless sendmail generates one\non the fly, that is your problem.\n\nIn general, git-format-patch output is probably not suitable for direct\nsending...have you looked at git-send-email?\n\n-Peff\n"},{"id":"47303","messageId":"f79742$j44$2@sea.gmane.org","threadId":"9017","inReplyTo":"20070713093050.GA18001@lapse.madduck.net","subject":"Re: failing to send patches to the list","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-07-14T00:58:45Z","receivedAt":"2007-07-14T00:58:45Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"martin f krafft wrote:\n\n> Subject: [PATCH] fall back to mozilla's sha.h if openssl/sha.h is not available\n> \n> Uses $(CPP) to attempt to preprocess an include directive. If\n> that fails, NO_OPENSSL is defined, causing the Makefile to fall back to using\n> mozilla's SHA implementation.\n\nShouldn't this be rather in configure.in? Main Makefile has only defaults\nfor different systems, but does not do tests.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"47315","messageId":"20070714060537.GA24396@lapse.madduck.net","threadId":"9017","inReplyTo":"81b0412b0707130557g6cf04365j232654734b148c3f@mail.gmail.com","subject":"Re: failing to send patches to the list","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-07-14T06:05:37Z","receivedAt":"2007-07-14T06:05:37Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"also sprach Alex Riesen [2007.07.13.1457 +0200]:\n> I suggest you try \"git format-patch -s --stdout |less\" before\n> sending format-patch without parameters produces nothing.\n\nI did. I simply misquoted in the email. Fact is that sendmail did\nsend an email, which VGER recognised to be a diff; yet it never\nshowed up.\n\nI think the missing message ID is likely the problem. I'll look into\nit.\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \nspamtraps: madduck.bogus@madduck.net\n \nhumpty was pushed.\n"},{"id":"47336","messageId":"20070714065242.GA27136@lapse.madduck.net","threadId":"9017","inReplyTo":"20070713155516.GA2712@sigill.intra.peff.net","subject":"Re: failing to send patches to the list","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-07-14T06:52:42Z","receivedAt":"2007-07-14T06:52:42Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"also sprach Jeff King [2007.07.13.1755 +0200]:\n> vger will reject messages without a message-id. git-format-patch by\n> default does not generate a message-id, so unless sendmail generates one\n> on the fly, that is your problem.\n> \n> In general, git-format-patch output is probably not suitable for direct\n> sending...have you looked at git-send-email?\n\nI just ran a test and found out: sendmail does generate a message ID\non the fly on the client, so this cannot be the problem.\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \nspamtraps: madduck.bogus@madduck.net\n \nhttp://www.transnationalrepublic.org/\n"},{"id":"47333","messageId":"20070714065928.GB27136@lapse.madduck.net","threadId":"9017","inReplyTo":"f79742$j44$2@sea.gmane.org","subject":"Re: failing to send patches to the list","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-07-14T06:59:28Z","receivedAt":"2007-07-14T06:59:28Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"also sprach Jakub Narebski [2007.07.14.0258 +0200]:\n> Shouldn't this be rather in configure.in? Main Makefile has only\n> defaults for different systems, but does not do tests.\n\nYou are right, except git HEAD already comes with a Makefile (rather\nthan a Makefile.in), so I just ran it while testing out patches.\nI introduced the test because I thought the computer could find out\nabout libssl for me, rather than myself having to forget to specify\nNO_OPENSSL every time.\n\nI agree that this should be (also) in configure.ac; the question is\nmore whether we *could* also add it to the Makefile to make\nfrom-source compilations easier.\n\nOn the other hand, I wonder: if the mozilla/sha.h implementation is\nin the tree anyway, why even bother with libssl? The SHA\nimplementation is unlikely to be changed anytime soon, so the extra\nlibrary dependency seems overkill just for the SHA hash\nfunctionality.\n\nJust my 2ยข\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \nspamtraps: madduck.bogus@madduck.net\n \n\"to get back my youth i would do anything in the world, except take\n exercise, get up early, or be respectable.\"\n -- oscar wilde\n"},{"id":"47342","messageId":"20070714105455.GB14842@muzzle","threadId":"9017","inReplyTo":"20070713095644.GA26743@lapse.madduck.net","subject":"Re: git-svn patch faulty (was: failing to send patches to the list)","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-07-14T10:54:55Z","receivedAt":"2007-07-14T10:54:55Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"martin f krafft wrote:\n> Hi there,\n> \n> still not having figured out the problem with the list (and I did\n> contact postmaster@), I just discovered that in fact the patch only\n> handles git-svn clone, not git-svn init. Thus, it's best to ignore\n> it for now. I am sorry for not taking enough care before publishing\n> it.\n\nHeh, I haven't used git-svn init in months :)\n\n-- \nEric Wong\n"}]}