{"thread":{"id":"8971","subject":"[PATCH 1/2] t0030: Remove repeated instructions and add missing &&","startedAt":"2007-07-10T21:53:45Z","lastAt":"2007-07-10T21:53:45Z","messageCount":1,"participants":["Carlos Rica"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"46985","messageId":"4693FFE9.3070508@gmail.com","threadId":"8971","inReplyTo":null,"subject":"[PATCH 1/2] t0030: Remove repeated instructions and add missing &&","fromName":"Carlos Rica","fromEmail":"jasampler@gmail.com","sentAt":"2007-07-10T21:53:45Z","receivedAt":"2007-07-10T21:53:45Z","isPatch":true,"sender":{"key":"jasampler@gmail.com","avatar":null},"body":"Moved some tests to another test_expect_success block.\n\nMany tests now reuse the same \"expect\" file. Also replacing\nmany printf \"\" >expect with one >expect instruction.\n\nAdded missing && which concatenated tests in some\ntest_expect_success blocks.\n\nSigned-off-by: Carlos Rica <jasampler@gmail.com>\n---\n t/t0030-stripspace.sh |   37 +++++++++++++------------------------\n 1 files changed, 13 insertions(+), 24 deletions(-)\n\ndiff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh\nindex fdc9fdc..4a2980c 100755\n--- a/t/t0030-stripspace.sh\n+++ b/t/t0030-stripspace.sh\n@@ -85,39 +85,36 @@ test_expect_success \\\n '\n\n test_expect_success \\\n-    'consecutive blank lines at the beginning should be removed' '\n-    printf \"\" > expect &&\n+    'only consecutive blank lines should be completely removed' '\n+    > expect &&\n+\n     printf \"\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"\\n\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"$sss\\n$sss\\n$sss\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"$sss$sss\\n$sss\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"\\n$sss\\n$sss$sss\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"$sss$sss$sss$sss\\n\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"\\n$sss$sss$sss$sss\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"\" > expect &&\n     printf \"\\n\\n$sss$sss$sss$sss\\n\" | git stripspace >actual &&\n-    git diff expect actual &&\n+    git diff expect actual\n+'\n\n+test_expect_success \\\n+    'consecutive blank lines at the beginning should be removed' '\n     printf \"$ttt\\n\" > expect &&\n     printf \"\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n@@ -139,26 +136,22 @@ test_expect_success \\\n     git diff expect actual &&\n\n     printf \"$ttt\\n\" > expect &&\n+\n     printf \"$sss\\n$sss\\n$sss\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"\\n$sss\\n$sss$sss\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$sss$sss\\n$sss\\n\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$sss$sss$sss\\n\\n\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"\\n$sss$sss$sss\\n\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"\\n\\n$sss$sss$sss\\n$ttt\\n\" | git stripspace >actual &&\n     git diff expect actual\n '\n@@ -186,26 +179,22 @@ test_expect_success \\\n     git diff expect actual &&\n\n     printf \"$ttt\\n\" > expect &&\n+\n     printf \"$ttt\\n$sss\\n$sss\\n$sss\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$ttt\\n\\n$sss\\n$sss$sss\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$ttt\\n$sss$sss\\n$sss\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$ttt\\n$sss$sss$sss\\n\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$ttt\\n\\n$sss$sss$sss\\n\\n\" | git stripspace >actual &&\n     git diff expect actual &&\n\n-    printf \"$ttt\\n\" > expect &&\n     printf \"$ttt\\n\\n\\n$sss$sss$sss\\n\" | git stripspace >actual &&\n     git diff expect actual\n '\n@@ -224,7 +213,7 @@ test_expect_success \\\n     'text plus spaces without newline at end should end with newline' '\n     test `printf \"$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n     test `printf \"$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n-    test `printf \"$ttt$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0\n+    test `printf \"$ttt$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n     test `printf \"$ttt$sss$sss\" | git stripspace | wc -l` -gt 0 &&\n     test `printf \"$ttt$ttt$sss$sss\" | git stripspace | wc -l` -gt 0 &&\n     test `printf \"$ttt$sss$sss$sss\" | git stripspace | wc -l` -gt 0\n@@ -340,13 +329,13 @@ test_expect_success \\\n     printf \"\" >expect &&\n\n     printf \"\" | git stripspace >actual &&\n-    git diff expect actual\n+    git diff expect actual &&\n\n     printf \"$sss$sss\" | git stripspace >actual &&\n-    git diff expect actual\n+    git diff expect actual &&\n\n     printf \"$sss$sss$sss\" | git stripspace >actual &&\n-    git diff expect actual\n+    git diff expect actual &&\n\n     printf \"$sss$sss$sss$sss\" | git stripspace >actual &&\n     git diff expect actual\n-- \n1.5.0\n"}]}