{"thread":{"id":"8896","subject":"[PATCH] Fix guilt to work correctly even if the refs are packed","startedAt":"2007-07-06T14:57:07Z","lastAt":"2007-07-06T15:12:38Z","messageCount":2,"participants":["Theodore Ts'o","Josef Sipek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"46629","messageId":"E1I6pF5-0003V9-2R@candygram.thunk.org","threadId":"8896","inReplyTo":null,"subject":"[PATCH] Fix guilt to work correctly even if the refs are packed","fromName":"Theodore Ts'o","fromEmail":"tytso@mit.edu","sentAt":"2007-07-06T14:57:07Z","receivedAt":"2007-07-06T14:57:07Z","isPatch":true,"sender":{"key":"tytso@mit.edu","avatar":"https://avatars.githubusercontent.com/u/51416?v=4"},"body":"\nExplicitly referencing .git/refs/heads/$branch is bad; use git\nshow-ref -h instead.\n\nSigned-off-by: \"Theodore Ts'o\" <tytso@mit.edu>\n---\n guilt |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/guilt b/guilt\nindex 814f755..54f9087 100755\n--- a/guilt\n+++ b/guilt\n@@ -247,7 +247,7 @@ head_check()\n \t# if the expected hash is empty, just return\n \t[ -z \"$1\" ] && return 0\n \n-\tif [ \"`cat \"$GIT_DIR/refs/heads/$branch\"`\" != \"$1\" ]; then\n+\tif [ \"`git show-ref -s \"refs/heads/$branch\"`\" != \"$1\" ]; then\n \t\techo \"Expected HEAD commit $1\" >&2\n \t\techo \"                 got `cat \"$GIT_DIR/refs/heads/$branch\"`\" >&2\n \t\treturn 1\n-- \n1.5.3.rc0.11.ge2b1a\n"},{"id":"46635","messageId":"20070706151238.GA1607@filer.fsl.cs.sunysb.edu","threadId":"8896","inReplyTo":"E1I6pF5-0003V9-2R@candygram.thunk.org","subject":"Re: [PATCH] Fix guilt to work correctly even if the refs are packed","fromName":"Josef Sipek","fromEmail":"jsipek@fsl.cs.sunysb.edu","sentAt":"2007-07-06T15:12:38Z","receivedAt":"2007-07-06T15:12:38Z","isPatch":true,"sender":{"key":"jsipek@fsl.cs.sunysb.edu","avatar":null},"body":"On Fri, Jul 06, 2007 at 10:57:07AM -0400, Theodore Ts'o wrote:\n> \n> Explicitly referencing .git/refs/heads/$branch is bad; use git\n> show-ref -h instead.\n \nApplied, I fixed up the commit message; you say -h but the code used -s.\n\nThanks.\n\nJosef \"Jeff\" Sipek.\n\n-- \nIf I have trouble installing Linux, something is wrong. Very wrong.\n\t\t- Linus Torvalds\n"}]}