{"thread":{"id":"8882","subject":"Email address from username and hostname preferred over $EMAIL","startedAt":"2007-07-05T17:57:37Z","lastAt":"2007-07-06T15:02:39Z","messageCount":8,"participants":["mkraai@beckman.com","Pierre Habouzit","Linus Torvalds","Brandon Casey","Junio C Hamano","Josh Triplett"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"46561","messageId":"OF40A04FE5.AA34B1BF-ON8825730F.005D733A-8825730F.0062A716@beckman.com","threadId":"8882","inReplyTo":null,"subject":"Email address from username and hostname preferred over $EMAIL","fromName":"","fromEmail":"mkraai@beckman.com","sentAt":"2007-07-05T17:57:37Z","receivedAt":"2007-07-05T17:57:37Z","isPatch":false,"sender":{"key":"mkraai@beckman.com","avatar":null},"body":"Howdy,\n\nGit prefers to use an email address constructed from the username and \nhostname to the value of the EMAIL environment variable. I think it \nshould prefer the latter to the former. This problem was introduced by \nec563e8153cba89728a271a26c8a94e7a42d8152.\n\n-- \nMatt\n\nThe server made the following annotations \n---------------------------------------------------------------------------------\nThis message contains information that may be privileged or confidential and is the property of Beckman Coulter, Inc. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.\n\n---------------------------------------------------------------------------------\n"},{"id":"46564","messageId":"20070705202140.GA24349@artemis.corp","threadId":"8882","inReplyTo":"OF40A04FE5.AA34B1BF-ON8825730F.005D733A-8825730F.0062A716@beckman.com","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"Pierre Habouzit","fromEmail":"madcoder@debian.org","sentAt":"2007-07-05T20:21:40Z","receivedAt":"2007-07-05T20:21:40Z","isPatch":false,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"On Thu, Jul 05, 2007 at 10:57:37AM -0700, mkraai@beckman.com wrote:\n> Howdy,\n> \n> Git prefers to use an email address constructed from the username and \n> hostname to the value of the EMAIL environment variable. I think it \n> should prefer the latter to the former. This problem was introduced by \n> ec563e8153cba89728a271a26c8a94e7a42d8152.\n\n no, ec563e8153cba89728a271a26c8a94e7a42d8152 is about making the\nemails and usernames be taken from EMAIL iff there is none specified in\nthe different .gitconfig's (which is sane as $EMAIL is a system wide\ndefault setting and that .git/config is definitely meant as an ovveride\nof that setting).\n\n\n-- \n·O· Pierre Habouzit\n··O madcoder@debian.org\nOOO http://www.madism.org\n"},{"id":"46565","messageId":"OFFAD14F99.03920E32-ON8825730F.006FFB5F-8825730F.00725068@beckman.com","threadId":"8882","inReplyTo":"20070705202140.GA24349@artemis.corp","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"","fromEmail":"mkraai@beckman.com","sentAt":"2007-07-05T20:48:41Z","receivedAt":"2007-07-05T20:48:41Z","isPatch":false,"sender":{"key":"mkraai@beckman.com","avatar":null},"body":"Yes, ec563e8153cba89728a271a26c8a94e7a42d8152 made user.email take \nprecedence over $EMAIL, but it also made the constructed email address \ntake precedence over $EMAIL. It made fmt_ident prefer git_default_email \nto $EMAIL, and git_default_email is set to the constructed email address \nby setup_ident if it's not already set by user.email.\n\n\n\n\nPierre Habouzit \n07/05/2007 01:21 PM\n\nTo\nmkraai@beckman.com\ncc\ngit@vger.kernel.org\nSubject\nRe: Email address from username and hostname preferred over $EMAIL\n\n\n\n\n\n\nOn Thu, Jul 05, 2007 at 10:57:37AM -0700, mkraai@beckman.com wrote:\n> Howdy,\n> \n> Git prefers to use an email address constructed from the username and \n> hostname to the value of the EMAIL environment variable. I think it \n> should prefer the latter to the former. This problem was introduced by \n> ec563e8153cba89728a271a26c8a94e7a42d8152.\n\n no, ec563e8153cba89728a271a26c8a94e7a42d8152 is about making the\nemails and usernames be taken from EMAIL iff there is none specified in\nthe different .gitconfig's (which is sane as $EMAIL is a system wide\ndefault setting and that .git/config is definitely meant as an ovveride\nof that setting).\n\n\n-- \n·O· Pierre Habouzit\n··O madcoder@debian.org\nOOO http://www.madism.org\n\n\nThe server made the following annotations \n---------------------------------------------------------------------------------\nThis message contains information that may be privileged or confidential and is the property of Beckman Coulter, Inc. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.\n\n---------------------------------------------------------------------------------\n"},{"id":"46566","messageId":"alpine.LFD.0.98.0707051357360.9434@woody.linux-foundation.org","threadId":"8882","inReplyTo":"OF40A04FE5.AA34B1BF-ON8825730F.005D733A-8825730F.0062A716@beckman.com","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2007-07-05T21:10:14Z","receivedAt":"2007-07-05T21:10:14Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Thu, 5 Jul 2007, mkraai@beckman.com wrote:\n> \n> Git prefers to use an email address constructed from the username and \n> hostname to the value of the EMAIL environment variable. I think it \n> should prefer the latter to the former. This problem was introduced by \n> ec563e8153cba89728a271a26c8a94e7a42d8152.\n\nIt did that very much on purpose. \"git_default_email\" must take \nprecedence, because that's the one that is filled in by the config file \nsyntax.\n\nSo just use\n\n\t[user]\n\t\tname = ..\n\t\temail = ..\n\nand be happy. Only in the absense of that will git start guessing, and \nyeah, it will not generally use EMAIL, unless it cannot get anything at \nall from username/hostname.\n\nIf you want it to prefer $EMAIL, you'd need to change the initialization \nof git_default_email, methinks.\n\n\t\tLinus\n"},{"id":"46580","messageId":"468D917F.9090707@nrlssc.navy.mil","threadId":"8882","inReplyTo":"alpine.LFD.0.98.0707051357360.9434@woody.linux-foundation.org","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2007-07-06T00:49:03Z","receivedAt":"2007-07-06T00:49:03Z","isPatch":false,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Linus Torvalds wrote:\n\n> If you want it to prefer $EMAIL, you'd need to change the initialization \n> of git_default_email, methinks.\n> \n> \t\tLinus\n\nI just sent an email to the list, and not in reply to this thread\nbecause I thought I read a comment about not posting a patch deep in\na thread.\n\nBut, I'm thinking I should have just posted it as a reply to the thread\nsince I quoted a portion of your message.\n\n-brandon\n"},{"id":"46582","messageId":"7vir8yib4d.fsf@assigned-by-dhcp.cox.net","threadId":"8882","inReplyTo":"468D917F.9090707@nrlssc.navy.mil","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-06T01:17:38Z","receivedAt":"2007-07-06T01:17:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brandon Casey writes:\n\n> Linus Torvalds wrote:\n>\n>> If you want it to prefer $EMAIL, you'd need to change the\n>> initialization of git_default_email, methinks.\n>>\n>> \t\tLinus\n>\n> I just sent an email to the list, and not in reply to this thread\n> because I thought I read a comment about not posting a patch deep in\n> a thread.\n>\n> But, I'm thinking I should have just posted it as a reply to the thread\n> since I quoted a portion of your message.\n\nAre Brandon Casey and Matt Kraai the same person?\n\nI do not mind threadedness of the patch too much, but the patch\nrecently posted by the latter does not have any description\nother than the title.\n\nOther than that, I think the change itself seems sane.\n"},{"id":"46592","messageId":"468DBA95.3070101@freedesktop.org","threadId":"8882","inReplyTo":"alpine.LFD.0.98.0707051357360.9434@woody.linux-foundation.org","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"Josh Triplett","fromEmail":"josh@freedesktop.org","sentAt":"2007-07-06T03:44:21Z","receivedAt":"2007-07-06T03:44:21Z","isPatch":false,"sender":{"key":"josh@joshtriplett.org","avatar":"https://avatars.githubusercontent.com/u/162737?v=4"},"body":"Linus Torvalds wrote:\n> On Thu, 5 Jul 2007, mkraai@beckman.com wrote:\n>> Git prefers to use an email address constructed from the username and \n>> hostname to the value of the EMAIL environment variable. I think it \n>> should prefer the latter to the former. This problem was introduced by \n>> ec563e8153cba89728a271a26c8a94e7a42d8152.\n> \n> It did that very much on purpose. \"git_default_email\" must take \n> precedence, because that's the one that is filled in by the config file \n> syntax.\n> \n> So just use\n> \n> \t[user]\n> \t\tname = ..\n> \t\temail = ..\n> \n> and be happy. Only in the absense of that will git start guessing, and \n> yeah, it will not generally use EMAIL, unless it cannot get anything at \n> all from username/hostname.\n> \n> If you want it to prefer $EMAIL, you'd need to change the initialization \n> of git_default_email, methinks.\n\nWhen I originally wrote the patch, I did so intending that $EMAIL would always\noverride git's guess of user@hostname. I set GIT_{AUTHOR,COMMITTER}_EMAIL in\nmy environment specifically so that git would stop using guesses like\njosh@josh-mobile and start using my actual email address. I submitted the\n$EMAIL patch in hopes that eventually I could stop setting the git-specific\nemail addresses and just set $EMAIL, which I already do for other tools. In\norder for that to work, $EMAIL should always override git's guesses.\n\n- Josh Triplett\n\n"},{"id":"46631","messageId":"468E598F.90801@nrlssc.navy.mil","threadId":"8882","inReplyTo":"7vir8yib4d.fsf@assigned-by-dhcp.cox.net","subject":"Re: Email address from username and hostname preferred over $EMAIL","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2007-07-06T15:02:39Z","receivedAt":"2007-07-06T15:02:39Z","isPatch":false,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"Junio C Hamano wrote:\n> Brandon Casey writes:\n> Are Brandon Casey and Matt Kraai the same person?\n\nheh, no. :) I see now that my patch did not make it. I tried\nto use git-send-email on my system and it successfully delivered\nto my imap mailbox, but failed delivering to the other recipients.\n\n> I do not mind threadedness of the patch too much\n\nok.\n\n> , but the patch\n> recently posted by the latter does not have any description\n> other than the title.\n> \n> Other than that, I think the change itself seems sane.\n\nI'll go ahead and post my patch again since I think it is a\nlittle simpler and I like it better (imagine that :)\n\nBut it's such a simple fix it will be just an exercise for me.\n\n-brandon\n"}]}