{"thread":{"id":"8829","subject":"[PATCH] repack: don't report \"Nothing new to pack.\" if -q is given","startedAt":"2007-07-03T08:47:58Z","lastAt":"2007-07-04T05:10:37Z","messageCount":4,"participants":["Uwe Kleine-König","Peter Baumann","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"46339","messageId":"20070703084757.GA4694@lala","threadId":"8829","inReplyTo":null,"subject":"[PATCH] repack: don't report \"Nothing new to pack.\" if -q is given","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2007-07-03T08:47:58Z","receivedAt":"2007-07-03T08:47:58Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>\n---\nThis patch is on top of maint.  For master and next you need\ns/name/names/.\n\nBest regards\nUwe\n\n git-repack.sh |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/git-repack.sh b/git-repack.sh\nindex ddfa8b4..d980275 100755\n--- a/git-repack.sh\n+++ b/git-repack.sh\n@@ -65,7 +65,9 @@ args=\"$args $local $quiet $no_reuse_delta$extra\"\n name=$(git-pack-objects --non-empty --all --reflog $args </dev/null \"$PACKTMP\") ||\n \texit 1\n if [ -z \"$name\" ]; then\n-\techo Nothing new to pack.\n+\tif test -q \"$quiet\"; then\n+\t\techo Nothing new to pack.\n+\tfi\n else\n \tchmod a-w \"$PACKTMP-$name.pack\"\n \tchmod a-w \"$PACKTMP-$name.idx\"\n-- \n1.5.2.2.1451.gb0e5e\n\n\n-- \nUwe Kleine-König\n\nexit vi, lesson II:\n: w q ! <CR>\n\nNB: write the current file\n"},{"id":"46392","messageId":"20070703181923.GE4580@xp.machine.xx","threadId":"8829","inReplyTo":"20070703084757.GA4694@lala","subject":"Re: [PATCH] repack: don't report \"Nothing new to pack.\" if -q is given","fromName":"Peter Baumann","fromEmail":"waste.manager@gmx.de","sentAt":"2007-07-03T18:19:23Z","receivedAt":"2007-07-03T18:19:23Z","isPatch":true,"sender":{"key":"waste.manager@gmx.de","avatar":null},"body":"On Tue, Jul 03, 2007 at 10:47:58AM +0200, Uwe Kleine-König wrote:\n> Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>\n> ---\n> This patch is on top of maint.  For master and next you need\n> s/name/names/.\n> \n> Best regards\n> Uwe\n> \n>  git-repack.sh |    4 +++-\n>  1 files changed, 3 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-repack.sh b/git-repack.sh\n> index ddfa8b4..d980275 100755\n> --- a/git-repack.sh\n> +++ b/git-repack.sh\n> @@ -65,7 +65,9 @@ args=\"$args $local $quiet $no_reuse_delta$extra\"\n>  name=$(git-pack-objects --non-empty --all --reflog $args </dev/null \"$PACKTMP\") ||\n>  \texit 1\n>  if [ -z \"$name\" ]; then\n> -\techo Nothing new to pack.\n> +\tif test -q \"$quiet\"; then\n> +\t\techo Nothing new to pack.\n> +\tfi\n\nThis looks wrong, especially as I can't find a '-q' in the manpage of \"test\".\nPerhaps you ment something like the following code, which is already used in\nthe script:\n\n\tif test \"$quiet\" != '-q'; then\n\t\techo ...\n\tfi\n\n-Peter\n"},{"id":"46397","messageId":"20070703191716.GA22775@informatik.uni-freiburg.de","threadId":"8829","inReplyTo":"20070703181923.GE4580@xp.machine.xx","subject":"Re: [PATCH] repack: don't report \"Nothing new to pack.\" if -q is given","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2007-07-03T19:17:16Z","receivedAt":"2007-07-03T19:17:16Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>\n---\nPeter Baumann wrote:\n> On Tue, Jul 03, 2007 at 10:47:58AM +0200, Uwe Kleine-König wrote:\n> >  \texit 1\n> >  if [ -z \"$name\" ]; then\n> > -\techo Nothing new to pack.\n> > +\tif test -q \"$quiet\"; then\n> > +\t\techo Nothing new to pack.\n> > +\tfi\n> \n> This looks wrong, especially as I can't find a '-q' in the manpage of \"test\".\n> Perhaps you ment something like the following code, which is already used in\n> the script:\n> \n> \tif test \"$quiet\" != '-q'; then\n> \t\techo ...\n> \tfi\nactually I meant test -z \"$quiet\", but test \"$quiet\" != '-q' would be\nequally good.\n\nThanks for noticing.\n\nUwe\n\n git-repack.sh |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/git-repack.sh b/git-repack.sh\nindex ddfa8b4..1ce2760 100755\n--- a/git-repack.sh\n+++ b/git-repack.sh\n@@ -65,7 +65,9 @@ args=\"$args $local $quiet $no_reuse_delta$extra\"\n name=$(git-pack-objects --non-empty --all --reflog $args </dev/null \"$PACKTMP\") ||\n \texit 1\n if [ -z \"$name\" ]; then\n-\techo Nothing new to pack.\n+\tif test -z \"$quiet\"; then\n+\t\techo Nothing new to pack.\n+\tfi\n else\n \tchmod a-w \"$PACKTMP-$name.pack\"\n \tchmod a-w \"$PACKTMP-$name.idx\"\n-- \n1.5.2.2.1451.gb0e5e\n\n\n\n> > Best regards\n> > Uwe\n> > \n> >  git-repack.sh |    4 +++-\n> >  1 files changed, 3 insertions(+), 1 deletions(-)\n> > \n> > diff --git a/git-repack.sh b/git-repack.sh\n> > index ddfa8b4..d980275 100755\n> > --- a/git-repack.sh\n> > +++ b/git-repack.sh\n> > @@ -65,7 +65,9 @@ args=\"$args $local $quiet $no_reuse_delta$extra\"\n> >  name=$(git-pack-objects --non-empty --all --reflog $args </dev/null \"$PACKTMP\") ||\n\n> -Peter\n> \n\n-- \nUwe Kleine-König\n\n$ dc -e \"5735816763073014741799356604682P\"\n"},{"id":"46435","messageId":"7vmyyclpo2.fsf@assigned-by-dhcp.cox.net","threadId":"8829","inReplyTo":"20070703084757.GA4694@lala","subject":"Re: [PATCH] repack: don't report \"Nothing new to pack.\" if -q is given","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-04T05:10:37Z","receivedAt":"2007-07-04T05:10:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Uwe Kleine-König  <ukleinek@informatik.uni-freiburg.de> writes:\n\n> Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>\n> ---\n> This patch is on top of maint.  For master and next you need\n> s/name/names/.\n\nThanks.  But I won't be applying this to 'maint' for now; I do\nnot think it is big enough bugfix.\n"}]}