{"thread":{"id":"8736","subject":"[PATCH] Ignore submodule commits when fetching over dumb protocols","startedAt":"2007-06-26T21:19:41Z","lastAt":"2007-06-27T00:41:45Z","messageCount":3,"participants":["Sven Verdoolaege","Linus Torvalds","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"45849","messageId":"20070626211940.GA27221@liacs.nl","threadId":"8736","inReplyTo":null,"subject":"[PATCH] Ignore submodule commits when fetching over dumb protocols","fromName":"Sven Verdoolaege","fromEmail":"skimo@liacs.nl","sentAt":"2007-06-26T21:19:41Z","receivedAt":"2007-06-26T21:19:41Z","isPatch":true,"sender":{"key":"skimo@kotnet.org","avatar":null},"body":"Without this patch, the code would look for the submodule\ncommits in the superproject and (needlessly) fail when it\ncouldn't find them.\n\nSigned-off-by: Sven Verdoolaege <skimo@liacs.nl>\n---\n fetch.c |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/fetch.c b/fetch.c\nindex dda33e5..811be87 100644\n--- a/fetch.c\n+++ b/fetch.c\n@@ -46,6 +46,9 @@ static int process_tree(struct tree *tree)\n \twhile (tree_entry(&desc, &entry)) {\n \t\tstruct object *obj = NULL;\n \n+\t\t/* submodule commits are not stored in the superproject */\n+\t\tif (S_ISGITLINK(entry.mode))\n+\t\t\tcontinue;\n \t\tif (S_ISDIR(entry.mode)) {\n \t\t\tstruct tree *tree = lookup_tree(entry.sha1);\n \t\t\tif (tree)\n-- \n1.5.2.2.549.gaeb59\n"},{"id":"45851","messageId":"alpine.LFD.0.98.0706261434540.8675@woody.linux-foundation.org","threadId":"8736","inReplyTo":"20070626211940.GA27221@liacs.nl","subject":"Re: [PATCH] Ignore submodule commits when fetching over dumb protocols","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2007-06-26T21:36:37Z","receivedAt":"2007-06-26T21:36:37Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Tue, 26 Jun 2007, Sven Verdoolaege wrote:\n>\n> Without this patch, the code would look for the submodule\n> commits in the superproject and (needlessly) fail when it\n> couldn't find them.\n\nAcked-by: Linus Torvalds <torvalds@linux-foundation.org>\n\nThis should probably be put in the maintenance branch, since I think we've \ntried to make sure that the current 1.5.x series plumbing can handle \nsuperproject data even if it doesn't then have the porcelain to make it \nall easy..\n\n\t\tLinus\n"},{"id":"45863","messageId":"7vzm2mw7na.fsf@assigned-by-dhcp.pobox.com","threadId":"8736","inReplyTo":"alpine.LFD.0.98.0706261434540.8675@woody.linux-foundation.org","subject":"Re: [PATCH] Ignore submodule commits when fetching over dumb protocols","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-06-27T00:41:45Z","receivedAt":"2007-06-27T00:41:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Torvalds <torvalds@linux-foundation.org> writes:\n\n> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>\n>\n> This should probably be put in the maintenance branch, since I think we've \n> tried to make sure that the current 1.5.x series plumbing can handle \n> superproject data even if it doesn't then have the porcelain to make it \n> all easy..\n\nThanks, both.\n"}]}