{"thread":{"id":"8681","subject":"Failure in t5516, tests 15 and 16","startedAt":"2007-06-22T14:50:46Z","lastAt":"2007-06-27T01:59:42Z","messageCount":4,"participants":["Brian Gernhardt","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"45573","messageId":"4FAE3A62-A0D1-4C88-8413-88F1D75A2730@silverinsanity.com","threadId":"8681","inReplyTo":null,"subject":"Failure in t5516, tests 15 and 16","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-06-22T14:50:46Z","receivedAt":"2007-06-22T14:50:46Z","isPatch":false,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"Tests 15 and 16 in script \"t5516-fetch-push.sh\" fails with \"notice:  \nHEAD points to an unborn branch (master)\".  Is this just bad tests or  \nan actual failure?  This is with current master  \n(45fd8bd32dd68ce6b14a406d0abbd6f56490131c) on OS X.\n\nDetailed test results follow.\n\n~~ Brian\n\n----- 8< -----\n\n* expecting success:\n\n         mk_test &&\n         if git show-ref --verify -q refs/tags/frotz\n         then\n                 git tag -d frotz\n         fi &&\n         git branch -f frotz master &&\n         git push testrepo frotz &&\n         check_push_result $the_commit heads/frotz &&\n         test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\nInitialized empty Git repository in .git/\nnotice: HEAD points to an unborn branch (master)\nnotice: No default references\nDeleted tag frotz.\nupdating 'refs/heads/frotz'\n   from 0000000000000000000000000000000000000000\n   to   9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nGenerating pack...\nDone counting 5 objects.\nDeltifying 5 objects...\n  100% (5/5) done\nWriting 5 objects...\n  100% (5/5) done\nTotal 5 (delta 0), reused 0 (delta 0)\nUnpacking 5 objects...\n  100% (5/5) done\nrefs/heads/frotz: 0000000000000000000000000000000000000000 ->  \n9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nnotice: HEAD points to an unborn branch (master)\n* FAIL 15: push with colon-less refspec (3)\n\n\n                 mk_test &&\n                 if git show-ref --verify -q refs/tags/frotz\n                 then\n                         git tag -d frotz\n                 fi &&\n                 git branch -f frotz master &&\n                 git push testrepo frotz &&\n                 check_push_result $the_commit heads/frotz &&\n                 test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\n\n* expecting success:\n\n         mk_test &&\n         if git show-ref --verify -q refs/heads/frotz\n         then\n                 git branch -D frotz\n         fi &&\n         git tag -f frotz &&\n         git push testrepo frotz &&\n         check_push_result $the_commit tags/frotz &&\n         test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\n\nInitialized empty Git repository in .git/\nnotice: HEAD points to an unborn branch (master)\nnotice: No default references\nDeleted branch frotz.\nupdating 'refs/tags/frotz'\n   from 0000000000000000000000000000000000000000\n   to   9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nGenerating pack...\nDone counting 5 objects.\nDeltifying 5 objects...\n  100% (5/5) done\nWriting 5 objects...\n  100% (5/5) done\nTotal 5 (delta 0), reused 0 (delta 0)\nUnpacking 5 objects...\n  100% (5/5) done\nrefs/tags/frotz: 0000000000000000000000000000000000000000 ->  \n9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nnotice: HEAD points to an unborn branch (master)\n* FAIL 16: push with colon-less refspec (4)\n\n\n                 mk_test &&\n                 if git show-ref --verify -q refs/heads/frotz\n                 then\n                         git branch -D frotz\n                 fi &&\n                 git tag -f frotz &&\n                 git push testrepo frotz &&\n                 check_push_result $the_commit tags/frotz &&\n                 test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\n\n\n* failed 2 among 16 test(s)\n"},{"id":"45869","messageId":"CFDE3792-403B-4582-B7FB-BC142B79AE63@silverinsanity.com","threadId":"8681","inReplyTo":"4FAE3A62-A0D1-4C88-8413-88F1D75A2730@silverinsanity.com","subject":"Re: Failure in t5516, tests 15 and 16","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-06-27T01:29:45Z","receivedAt":"2007-06-27T01:29:45Z","isPatch":false,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Jun 22, 2007, at 10:50 AM, Brian Gernhardt wrote:\n\n> Tests 15 and 16 in script \"t5516-fetch-push.sh\" fails with \"notice:  \n> HEAD points to an unborn branch (master)\".  Is this just bad tests  \n> or an actual failure?  This is with current master  \n> (45fd8bd32dd68ce6b14a406d0abbd6f56490131c) on OS X.\n\nOkay, I just did used the wonderful \"git bisect run\" to find out  \nwhere this error started happening.  The answer appears to be in the  \nfirst commit the tests appeared in:  \n1ed10b886bc69c129c06772ee4310c00e001657f\n\nI dislike that immensely.  Can anyone help me figure out why the test  \nfails?  There is no error message printed.  I thought the \"HEAD  \npoints to an unborn branch\" was the error, but that doesn't seem to  \nbe it.\n\nAgain, the test results are below.\n\n~~ Brian\n\n----- 8< -----\n\n* expecting success:\n\n         mk_test &&\n         if git show-ref --verify -q refs/tags/frotz\n         then\n                 git tag -d frotz\n         fi &&\n         git branch -f frotz master &&\n         git push testrepo frotz &&\n         check_push_result $the_commit heads/frotz &&\n         test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\nInitialized empty Git repository in .git/\nnotice: HEAD points to an unborn branch (master)\nnotice: No default references\nDeleted tag frotz.\nupdating 'refs/heads/frotz'\n   from 0000000000000000000000000000000000000000\n   to   9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nGenerating pack...\nDone counting 5 objects.\nDeltifying 5 objects...\n  100% (5/5) done\nWriting 5 objects...\n  100% (5/5) done\nTotal 5 (delta 0), reused 0 (delta 0)\nUnpacking 5 objects...\n  100% (5/5) done\nrefs/heads/frotz: 0000000000000000000000000000000000000000 ->  \n9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nnotice: HEAD points to an unborn branch (master)\n* FAIL 15: push with colon-less refspec (3)\n\n\n                 mk_test &&\n                 if git show-ref --verify -q refs/tags/frotz\n                 then\n                         git tag -d frotz\n                 fi &&\n                 git branch -f frotz master &&\n                 git push testrepo frotz &&\n                 check_push_result $the_commit heads/frotz &&\n                 test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\n\n* expecting success:\n\n         mk_test &&\n         if git show-ref --verify -q refs/heads/frotz\n         then\n                 git branch -D frotz\n         fi &&\n         git tag -f frotz &&\n         git push testrepo frotz &&\n         check_push_result $the_commit tags/frotz &&\n         test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\n\nInitialized empty Git repository in .git/\nnotice: HEAD points to an unborn branch (master)\nnotice: No default references\nDeleted branch frotz.\nupdating 'refs/tags/frotz'\n   from 0000000000000000000000000000000000000000\n   to   9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nGenerating pack...\nDone counting 5 objects.\nDeltifying 5 objects...\n  100% (5/5) done\nWriting 5 objects...\n  100% (5/5) done\nTotal 5 (delta 0), reused 0 (delta 0)\nUnpacking 5 objects...\n  100% (5/5) done\nrefs/tags/frotz: 0000000000000000000000000000000000000000 ->  \n9ad36e1e54b2130a20d55abb4f0f3ca8494ead3f\nnotice: HEAD points to an unborn branch (master)\n* FAIL 16: push with colon-less refspec (4)\n\n\n                 mk_test &&\n                 if git show-ref --verify -q refs/heads/frotz\n                 then\n                         git branch -D frotz\n                 fi &&\n                 git tag -f frotz &&\n                 git push testrepo frotz &&\n                 check_push_result $the_commit tags/frotz &&\n                 test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\n\n\n* failed 2 among 16 test(s)\n"},{"id":"45870","messageId":"7v4pkuuq5u.fsf@assigned-by-dhcp.pobox.com","threadId":"8681","inReplyTo":"CFDE3792-403B-4582-B7FB-BC142B79AE63@silverinsanity.com","subject":"Re: Failure in t5516, tests 15 and 16","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-06-27T01:44:45Z","receivedAt":"2007-06-27T01:44:45Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brian Gernhardt <benji@silverinsanity.com> writes:\n\n> On Jun 22, 2007, at 10:50 AM, Brian Gernhardt wrote:\n>\n>> Tests 15 and 16 in script \"t5516-fetch-push.sh\" fails with \"notice:\n>> HEAD points to an unborn branch (master)\".  Is this just bad tests\n>> or an actual failure?  This is with current master\n>> (45fd8bd32dd68ce6b14a406d0abbd6f56490131c) on OS X.\n\nCan you check \"cd t && sh -x t5516-fetch-push.sh -i -v\"?\n\nI am suspecting that\n\n                test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n\nmay have an interesting effect when \"wc -l\" emits extra\nwhitespaces.  Does this fix it for you?\n\n\n\ndiff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh\nindex 08d58e1..c0fa2ba 100755\n--- a/t/t5516-fetch-push.sh\n+++ b/t/t5516-fetch-push.sh\n@@ -226,7 +226,7 @@ test_expect_success 'push with colon-less refspec (3)' '\n \tgit branch -f frotz master &&\n \tgit push testrepo frotz &&\n \tcheck_push_result $the_commit heads/frotz &&\n-\ttest \"$( cd testrepo && git show-ref | wc -l )\" = 1\n+\ttest 1 = $(cd testrepo && git show-ref | wc -l)\n '\n \n test_expect_success 'push with colon-less refspec (4)' '\n@@ -239,7 +239,7 @@ test_expect_success 'push with colon-less refspec (4)' '\n \tgit tag -f frotz &&\n \tgit push testrepo frotz &&\n \tcheck_push_result $the_commit tags/frotz &&\n-\ttest \"$( cd testrepo && git show-ref | wc -l )\" = 1\n+\ttest 1 = $(cd testrepo && git show-ref | wc -l)\n \n '\n \n"},{"id":"45876","messageId":"0EE674FF-3749-43CB-B1CB-7FCF5860D025@silverinsanity.com","threadId":"8681","inReplyTo":"7v4pkuuq5u.fsf@assigned-by-dhcp.pobox.com","subject":"Re: Failure in t5516, tests 15 and 16","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-06-27T01:59:42Z","receivedAt":"2007-06-27T01:59:42Z","isPatch":false,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Jun 26, 2007, at 9:44 PM, Junio C Hamano wrote:\n\n> Can you check \"cd t && sh -x t5516-fetch-push.sh -i -v\"?\n>\n> I am suspecting that\n>\n>                 test \"$( cd testrepo && git show-ref | wc -l )\" = 1\n>\n> may have an interesting effect when \"wc -l\" emits extra\n> whitespaces.  Does this fix it for you?\n\nExactly right.  This bit me a while back on some other test as well.   \nShould have thought of it this time.  Removing the quotes (done  \nmanually, as it was faster than extracting your patch from the mail)  \nfixed it and that test works properly now.  I'm now getting errors in  \nsome CVS test...  I'll figure that out later, but it appears  \ncompletely unrelated.\n\nI'm beginning to despise several of the OS X utilities.  I wonder if  \nthis is inherited from some BSD, or if it's all new.  Doesn't matter  \nthough, if you'd be so kind as to remove those quotes from git.git.  :-)\n\n~~ Brian\n"}]}