{"thread":{"id":"8677","subject":"[PATCH] git-svn: favor ~/.subversion/ ssl client cert settings","startedAt":"2007-06-21T23:15:43Z","lastAt":"2007-06-22T00:25:08Z","messageCount":2,"participants":["Michael Krelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"45531","messageId":"11824677432401-git-send-email-hacker@klever.net","threadId":"8677","inReplyTo":null,"subject":"[PATCH] git-svn: favor ~/.subversion/ ssl client cert settings","fromName":"Michael Krelin","fromEmail":"hacker@klever.net","sentAt":"2007-06-21T23:15:43Z","receivedAt":"2007-06-21T23:15:43Z","isPatch":true,"sender":{"key":"hacker@klever.net","avatar":"https://gravatar.com/avatar/19b2d40c72f6de8c4de70062857b9339d55829fef1a1b1e60c98bbebc8add9aa?d=mp&s=160"},"body":"---\n git-svn.perl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 50128d7..9dfea97 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -2925,6 +2925,7 @@ sub new {\n \t    SVN::Client::get_ssl_server_trust_file_provider(),\n \t    SVN::Client::get_simple_prompt_provider(\n \t      \\&Git::SVN::Prompt::simple, 2),\n+\t    SVN::Client::get_ssl_client_cert_file_provider(),\n \t    SVN::Client::get_ssl_client_cert_prompt_provider(\n \t      \\&Git::SVN::Prompt::ssl_client_cert, 2),\n \t    SVN::Client::get_ssl_client_cert_pw_prompt_provider(\n-- \n1.5.2.2\n"},{"id":"45533","messageId":"7vfy4kbztn.fsf@assigned-by-dhcp.pobox.com","threadId":"8677","inReplyTo":"11824677432401-git-send-email-hacker@klever.net","subject":"Re: [PATCH] git-svn: favor ~/.subversion/ ssl client cert settings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-06-22T00:25:08Z","receivedAt":"2007-06-22T00:25:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sorry, but I am not familiar with SVN API.\n\nIn plain English, what does this change mean and what does it\nbuy us?  An expected answer is something like:\n\n\tWithout this change, there is no way to authenticate\n        with client SSL certificates, as certificates registered\n        in ~/.subvsersion are ignored.\n\nBTW, if that is what you meant, it contradicts the word \"favor\"\nin the proposed commit title.  \"Favor\" would mean \"We do support\nit already but in lower precedence than something else, which is\ninconvenient, so let's move it up so that it is used if found\nwithout bothering other possibilities\".  \n\nIf that is what you really meant, then the answer would be in\nthe form of:\n\n\tCurently, even when the client wants to use SSL\n        certificate to authenticate with the server, X\n        authenticator is tried first which causes Y that is\n        irritating.  This patch makes the client certificate\n        authenticator be tried first.\n\nBut if that is what is going on, we need to judge if the\n\"irritation\" factor is universally true, or just affects people\nwho want to use client SSL cert; if the change makes it more\nconvenient for client cert people by making it less convenient\nfor others, the relative merit needs to be debated to justify\nthe change.\n\nI am guessing that you meant the former (we currently totally\nignore it, and the patch adds the missing support), but what\nwould I know...\n\nAnd if that is the case, then I think the word you wanted to use\nis not \"favor\" but \"honor\".\n\nIn any case, the patch needs a handful lines of proposed commit\nlog message to explain and justify the change, like the above\ntwo examples I showed here.\n"}]}