{"thread":{"id":"8572","subject":"Mail after commit","startedAt":"2007-06-12T15:32:14Z","lastAt":"2007-06-13T21:26:47Z","messageCount":6,"participants":["Claudio Scordino","Martin Langhoff","Jan-Benedict Glaw","Andy Parkins"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"44840","messageId":"466EBC7E.8040104@gmail.com","threadId":"8572","inReplyTo":null,"subject":"Mail after commit","fromName":"Claudio Scordino","fromEmail":"cloud.of.andor@gmail.com","sentAt":"2007-06-12T15:32:14Z","receivedAt":"2007-06-12T15:32:14Z","isPatch":false,"sender":{"key":"cloud.of.andor@gmail.com","avatar":null},"body":"Hi all.\n\nTo have an email sent after every commit, I've put the following command in \n.git/hooks/post-commit:\n\nrm -f /tmp/git-commit.patch ; git-format-patch --stdout -s `git log \n--pretty=oneline | awk '{print $1}' | sed -n '2p'` > /tmp/git-commit.patch ; \ngit-send-email --no-signed-off-by-cc --to XXX --from YYY /tmp/git-commit.patch \n; rm -f /tmp/git-commit.patch\n\nand it works, indeed.\n\nHowever, it's quite tricky.\n\nDoesn't exist any way to make it simpler ?\n\nRegards,\n\n Claudio\n"},{"id":"44869","messageId":"46a038f90706121335i79dc5967l782101bc743dc8e2@mail.gmail.com","threadId":"8572","inReplyTo":"466EBC7E.8040104@gmail.com","subject":"Re: Mail after commit","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2007-06-12T20:35:57Z","receivedAt":"2007-06-12T20:35:57Z","isPatch":false,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 6/13/07, Claudio Scordino wrote:\n> Doesn't exist any way to make it simpler ?\n\nI think most people setup gitweb, and follow its rss feed. Not exacty\nthe same, I know, but quite useful.\n\ncheers,\n\n\nmartin\n"},{"id":"44939","messageId":"20070613142516.GE22027@lug-owl.de","threadId":"8572","inReplyTo":"46a038f90706121335i79dc5967l782101bc743dc8e2@mail.gmail.com","subject":"Re: Mail after commit","fromName":"Jan-Benedict Glaw","fromEmail":"jbglaw@lug-owl.de","sentAt":"2007-06-13T14:25:16Z","receivedAt":"2007-06-13T14:25:16Z","isPatch":false,"sender":{"key":"jbglaw@lug-owl.de","avatar":null},"body":"On Wed, 2007-06-13 08:35:57 +1200, Martin Langhoff wrote:\n> On 6/13/07, Claudio Scordino wrote:\n> > Doesn't exist any way to make it simpler ?\n> \n> I think most people setup gitweb, and follow its rss feed. Not exacty\n> the same, I know, but quite useful.\n\nErm, no, not really. Emailing the patches is *quite* useful when\nthere's a dedicated review team.\n\nMfG, JBG\n\n-- \n Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481\nSignature of: The real problem with C++ for kernel modules is:\nthe second : the language just sucks.\n -- Linus Torvalds\n"},{"id":"44947","messageId":"200706131610.42779.andyparkins@gmail.com","threadId":"8572","inReplyTo":"20070613142516.GE22027@lug-owl.de","subject":"Re: Mail after commit","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-06-13T15:10:40Z","receivedAt":"2007-06-13T15:10:40Z","isPatch":false,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Wednesday 2007 June 13, Jan-Benedict Glaw wrote:\n\n> > I think most people setup gitweb, and follow its rss feed. Not exacty\n> > the same, I know, but quite useful.\n>\n> Erm, no, not really. Emailing the patches is *quite* useful when\n> there's a dedicated review team.\n\nAs an aside - I find it better to send announce emails on git-push rather than \ngit-commit. If you send an email on git-commit, then your working repository \nbecomes a whole lot less useful.\n\nFor example I often do:\n\n git commit -a -m \"Shelve what I'm doing right now\"\n git checkout -b temporary-branch HEAD^^^\n vim fix-bug-that-I-never-want-anyone-to-see\n git checkout master\n git rebase temporary-branch\n git branch -d temporary-branch\n git reset HEAD^\n\nObviously this only works for commits I haven't pushed yet, but it's very \nuseful to be able to do - usually I need it because I missed a git-add of a \nfile out of a commit and didn't notice for a while.\n\nOnce I'm happy with my local history, then I git-push to the shared repository \nand an email is generated to let other members of the team know I've done \nsomething - they can then git-fetch and review if they feel like it.\n\nTo me, sending an email every commit would be like sending an email every time \nI pressed \"save\" in the editor.\n\n\n\nAndy\n-- \nDr Andy Parkins, M Eng (hons), MIET\nandyparkins@gmail.com\n"},{"id":"45004","messageId":"46a038f90706131419i66cf610flac4f3ca040a4355f@mail.gmail.com","threadId":"8572","inReplyTo":"20070613142516.GE22027@lug-owl.de","subject":"Re: Mail after commit","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2007-06-13T21:19:57Z","receivedAt":"2007-06-13T21:19:57Z","isPatch":false,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 6/14/07, Jan-Benedict Glaw wrote:\n> On Wed, 2007-06-13 08:35:57 +1200, Martin Langhoff wrote:\n> > On 6/13/07, Claudio Scordino wrote:\n> > > Doesn't exist any way to make it simpler ?\n> >\n> > I think most people setup gitweb, and follow its rss feed. Not exacty\n> > the same, I know, but quite useful.\n>\n> Erm, no, not really. Emailing the patches is *quite* useful when\n> there's a dedicated review team.\n\nI'm sure the review team can read the RSS feed ;-) I've also seen\nRSS-to-IMAP gateways that make it easy to \"reply\" to the patch from\nyour MUA.\n\nNot _exactly_ the same, but quite useful.\n\n\nmartin\n"},{"id":"45005","messageId":"20070613212647.GA19958@lug-owl.de","threadId":"8572","inReplyTo":"46a038f90706131419i66cf610flac4f3ca040a4355f@mail.gmail.com","subject":"Re: Mail after commit","fromName":"Jan-Benedict Glaw","fromEmail":"jbglaw@lug-owl.de","sentAt":"2007-06-13T21:26:47Z","receivedAt":"2007-06-13T21:26:47Z","isPatch":false,"sender":{"key":"jbglaw@lug-owl.de","avatar":null},"body":"On Thu, 2007-06-14 09:19:57 +1200, Martin Langhoff wrote:\n> On 6/14/07, Jan-Benedict Glaw wrote:\n> > On Wed, 2007-06-13 08:35:57 +1200, Martin Langhoff > > wrote:\n> > > On 6/13/07, Claudio Scordino wrote:\n> > > > Doesn't exist any way to make it simpler ?\n> > >\n> > > I think most people setup gitweb, and follow its rss feed. Not exacty\n> > > the same, I know, but quite useful.\n> >\n> > Erm, no, not really. Emailing the patches is *quite* useful when\n> > there's a dedicated review team.\n> \n> I'm sure the review team can read the RSS feed ;-) I've also seen\n> RSS-to-IMAP gateways that make it easy to \"reply\" to the patch from\n> your MUA.\n\nWell, why import it to the mail platform via RSS when there's a direct\nway:) Almost all interesting patches require review (and commenting),\nand we're working with the email client all the day. So it's just\nstraight forward ;-)\n\nMfG, JBG\n\n-- \n Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481\nSignature of: \"really soon now\": an unspecified period of time, likly to\nthe second : be greater than any reasonable definition\n of \"soon\".\n"}]}