{"thread":{"id":"8561","subject":"[PATCH 3/5] Rename sections from \"module\" to \"submodule\" in .gitmodules","startedAt":"2007-06-11T19:55:17Z","lastAt":"2007-06-11T19:55:17Z","messageCount":1,"participants":["Lars Hjemli"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"44752","messageId":"11815917171856-git-send-email-hjemli@gmail.com","threadId":"8561","inReplyTo":null,"subject":"[PATCH 3/5] Rename sections from \"module\" to \"submodule\" in .gitmodules","fromName":"Lars Hjemli","fromEmail":"hjemli@gmail.com","sentAt":"2007-06-11T19:55:17Z","receivedAt":"2007-06-11T19:55:17Z","isPatch":true,"sender":{"key":"hjemli@gmail.com","avatar":null},"body":"On 6/10/07, Junio C Hamano <gitster@pobox.com> wrote:\n> \"Lars Hjemli\" <hjemli@gmail.com> writes:\n>\n> > Hmm, maybe I should just rename [module] to [submodule] right now? It\n> > would be better forward compatible with the proposed extension, it\n> > would 'harmonize' the section names used in .gitmodules and\n> > .git/config, and it would offer a clean break from what's currently\n> > supported in 'master'.\n>\n> Yes, the difference between '[submodule]' vs '[module]' in\n> .git/config and .gitmodules confused me while looking at your\n> latest patch series.  I am in favor of unifying them.  We would\n> not be breaking any released version if we harmonize them now.\n\nHere it is.\n\nSigned-off-by: Lars Hjemli <hjemli@gmail.com>\n---\n\nThis seem to be a bad mail day for me. I'm resending this patch since\nsomeone apparently ate the previous one :-(\n\n\n git-submodule.sh           |    2 +-\n t/t7400-submodule-basic.sh |    2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex 4a6d64d..6c83c52 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -66,7 +66,7 @@ modules_init()\n \t\turl=$(git-config submodule.\"$path\".url)\n \t\ttest -z \"$url\" || continue\n \n-\t\turl=$(GIT_CONFIG=.gitmodules git-config module.\"$path\".url)\n+\t\turl=$(GIT_CONFIG=.gitmodules git-config submodule.\"$path\".url)\n \t\ttest -z \"$url\" &&\n \t\tdie \"No url found for submodule '$path' in .gitmodules\"\n \ndiff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh\nindex 74fafce..9f2d4f9 100755\n--- a/t/t7400-submodule-basic.sh\n+++ b/t/t7400-submodule-basic.sh\n@@ -40,7 +40,7 @@ test_expect_success 'Prepare submodule testing' '\n \tgit-add a lib z &&\n \tgit-commit -m \"super commit 1\" &&\n \tmv lib .subrepo &&\n-\tGIT_CONFIG=.gitmodules git-config module.lib.url git://example.com/lib.git\n+\tGIT_CONFIG=.gitmodules git-config submodule.lib.url git://example.com/lib.git\n '\n \n test_expect_success 'status should only print one line' '\n-- \n1.5.2.1.914.gbd3a7\n"}]}