{"thread":{"id":"8520","subject":"[RFC][PATCH 04/10] Sparse: fix some \"symbol not declared\" warnings (Part 2)","startedAt":"2007-06-08T22:13:46Z","lastAt":"2007-06-08T22:13:46Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":10},"messages":[{"id":"44399","messageId":"4669D49A.4080106@ramsay1.demon.co.uk","threadId":"8520","inReplyTo":null,"subject":"[RFC][PATCH 04/10] Sparse: fix some \"symbol not declared\" warnings (Part 2)","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2007-06-08T22:13:46Z","receivedAt":"2007-06-08T22:13:46Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nThe complete warning message reads something like:\n\n    symbol 'whatever' was not declared. Should be static?\n\nIn this commit, the answer is yes; all of these symbols have\nno need to be visible beyond the compilation unit, so make\nthem static.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n builtin-branch.c |    4 ++--\n builtin-revert.c |    6 +++---\n commit.c         |    2 +-\n daemon.c         |    2 +-\n refs.c           |    2 +-\n upload-pack.c    |    2 +-\n wt-status.c      |    2 +-\n 7 files changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/builtin-branch.c b/builtin-branch.c\nindex 7408285..b2104fe 100644\n--- a/builtin-branch.c\n+++ b/builtin-branch.c\n@@ -55,7 +55,7 @@ static int parse_branch_color_slot(const char *var, int ofs)\n \tdie(\"bad config variable '%s'\", var);\n }\n \n-int git_branch_config(const char *var, const char *value)\n+static int git_branch_config(const char *var, const char *value)\n {\n \tif (!strcmp(var, \"color.branch\")) {\n \t\tbranch_use_color = git_config_colorbool(var, value);\n@@ -72,7 +72,7 @@ int git_branch_config(const char *var, const char *value)\n \treturn git_default_config(var, value);\n }\n \n-const char *branch_get_color(enum color_branch ix)\n+static const char *branch_get_color(enum color_branch ix)\n {\n \tif (branch_use_color)\n \t\treturn branch_colors[ix];\ndiff --git a/builtin-revert.c b/builtin-revert.c\nindex ea2f15b..f58d32e 100644\n--- a/builtin-revert.c\n+++ b/builtin-revert.c\n@@ -25,7 +25,7 @@ static const char *cherry_pick_usage = \"git-cherry-pick [--edit] [-n] [-r] [-x]\n \n static int edit;\n static int replay;\n-enum { REVERT, CHERRY_PICK } action;\n+static enum { REVERT, CHERRY_PICK } action;\n static int no_commit;\n static struct commit *commit;\n static int needed_deref;\n@@ -104,7 +104,7 @@ static char *get_oneline(const char *message)\n \treturn result;\n }\n \n-char *get_encoding(const char *message)\n+static char *get_encoding(const char *message)\n {\n \tconst char *p = message, *eol;\n \n@@ -126,7 +126,7 @@ char *get_encoding(const char *message)\n \treturn NULL;\n }\n \n-struct lock_file msg_file;\n+static struct lock_file msg_file;\n static int msg_fd;\n \n static void add_to_msg(const char *string)\ndiff --git a/commit.c b/commit.c\nindex bee066f..be0c76d 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -27,7 +27,7 @@ struct sort_node\n \n const char *commit_type = \"commit\";\n \n-struct cmt_fmt_map {\n+static struct cmt_fmt_map {\n \tconst char *n;\n \tsize_t cmp_len;\n \tenum cmit_fmt v;\ndiff --git a/daemon.c b/daemon.c\nindex b79e905..64f1f34 100644\n--- a/daemon.c\n+++ b/daemon.c\n@@ -439,7 +439,7 @@ static void parse_extra_args(struct interp *table, char *extra_args, int buflen)\n \t}\n }\n \n-void fill_in_extra_table_entries(struct interp *itable)\n+static void fill_in_extra_table_entries(struct interp *itable)\n {\n \tchar *hp;\n \ndiff --git a/refs.c b/refs.c\nindex 89876bf..820e6ac 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -150,7 +150,7 @@ static struct ref_list *sort_ref_list(struct ref_list *list)\n  * Future: need to be in \"struct repository\"\n  * when doing a full libification.\n  */\n-struct cached_refs {\n+static struct cached_refs {\n \tchar did_loose;\n \tchar did_packed;\n \tstruct ref_list *loose;\ndiff --git a/upload-pack.c b/upload-pack.c\nindex d3a09e7..1046ea9 100644\n--- a/upload-pack.c\n+++ b/upload-pack.c\n@@ -62,7 +62,7 @@ static ssize_t send_client_data(int fd, const char *data, ssize_t sz)\n \treturn safe_write(fd, data, sz);\n }\n \n-FILE *pack_pipe = NULL;\n+static FILE *pack_pipe = NULL;\n static void show_commit(struct commit *commit)\n {\n \tif (commit->object.flags & BOUNDARY)\ndiff --git a/wt-status.c b/wt-status.c\nindex a055990..fd8a877 100644\n--- a/wt-status.c\n+++ b/wt-status.c\n@@ -197,7 +197,7 @@ static void wt_read_cache(struct wt_status *s)\n \tread_cache();\n }\n \n-void wt_status_print_initial(struct wt_status *s)\n+static void wt_status_print_initial(struct wt_status *s)\n {\n \tint i;\n \tchar buf[PATH_MAX];\n-- \n1.5.2\n"}]}