{"thread":{"id":"8518","subject":"[RFC][PATCH 08/10] Sparse: fix an \"incorrect type in argument n\" warning","startedAt":"2007-06-08T22:24:20Z","lastAt":"2007-06-08T22:24:20Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":10},"messages":[{"id":"44397","messageId":"4669D714.5050805@ramsay1.demon.co.uk","threadId":"8518","inReplyTo":null,"subject":"[RFC][PATCH 08/10] Sparse: fix an \"incorrect type in argument n\" warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2007-06-08T22:24:20Z","receivedAt":"2007-06-08T22:24:20Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, the warning referred to argument 3 in a call to\naccept() and alluded to the type of the actual and formal arguments\nbeing of a different signedness. The type of the formal parameter\nof accept is (socklen_t *), rather than (unsigned int *) as used\nhere, so make the necessary changes to use socklen_t in the\nappropriate places.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n daemon.c |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/daemon.c b/daemon.c\nindex 64f1f34..9daa850 100644\n--- a/daemon.c\n+++ b/daemon.c\n@@ -604,11 +604,11 @@ static unsigned int children_deleted;\n \n static struct child {\n \tpid_t pid;\n-\tint addrlen;\n+\tsocklen_t addrlen;\n \tstruct sockaddr_storage address;\n } live_child[MAX_CHILDREN];\n \n-static void add_child(int idx, pid_t pid, struct sockaddr *addr, int addrlen)\n+static void add_child(int idx, pid_t pid, struct sockaddr *addr, socklen_t addrlen)\n {\n \tlive_child[idx].pid = pid;\n \tlive_child[idx].addrlen = addrlen;\n@@ -702,7 +702,7 @@ static void check_max_connections(void)\n \t}\n }\n \n-static void handle(int incoming, struct sockaddr *addr, int addrlen)\n+static void handle(int incoming, struct sockaddr *addr, socklen_t addrlen)\n {\n \tpid_t pid = fork();\n \n@@ -917,7 +917,7 @@ static int service_loop(int socknum, int *socklist)\n \t\tfor (i = 0; i < socknum; i++) {\n \t\t\tif (pfd[i].revents & POLLIN) {\n \t\t\t\tstruct sockaddr_storage ss;\n-\t\t\t\tunsigned int sslen = sizeof(ss);\n+\t\t\t\tsocklen_t sslen = sizeof(ss);\n \t\t\t\tint incoming = accept(pfd[i].fd, (struct sockaddr *)&ss, &sslen);\n \t\t\t\tif (incoming < 0) {\n \t\t\t\t\tswitch (errno) {\n-- \n1.5.2\n"}]}