{"thread":{"id":"8486","subject":"[PATCH] Missing statics.","startedAt":"2007-06-07T20:44:59Z","lastAt":"2007-06-07T20:45:00Z","messageCount":2,"participants":["Pierre Habouzit"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"44262","messageId":"118124910076-git-send-email-madcoder@debian.org","threadId":"8486","inReplyTo":null,"subject":"[PATCH] Active_nr is unsigned, hence can't be < 0","fromName":"Pierre Habouzit","fromEmail":"madcoder@debian.org","sentAt":"2007-06-07T20:44:59Z","receivedAt":"2007-06-07T20:44:59Z","isPatch":true,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"Signed-off-by: Pierre Habouzit <madcoder@debian.org>\n---\n sha1_name.c |    2 --\n 1 files changed, 0 insertions(+), 2 deletions(-)\n\ndiff --git a/sha1_name.c b/sha1_name.c\nindex 7df01af..858f08c 100644\n--- a/sha1_name.c\n+++ b/sha1_name.c\n@@ -682,8 +682,6 @@ int get_sha1_with_mode(const char *name, unsigned char *sha1, unsigned *mode)\n \t\tnamelen = namelen - (cp - name);\n \t\tif (!active_cache)\n \t\t\tread_cache();\n-\t\tif (active_nr < 0)\n-\t\t\treturn -1;\n \t\tpos = cache_name_pos(cp, namelen);\n \t\tif (pos < 0)\n \t\t\tpos = -pos - 1;\n-- \n1.5.2.1\n"},{"id":"44261","messageId":"1181249100664-git-send-email-madcoder@debian.org","threadId":"8486","inReplyTo":"118124910076-git-send-email-madcoder@debian.org","subject":"[PATCH] Missing statics.","fromName":"Pierre Habouzit","fromEmail":"madcoder@debian.org","sentAt":"2007-06-07T20:45:00Z","receivedAt":"2007-06-07T20:45:00Z","isPatch":true,"sender":{"key":"madcoder@debian.org","avatar":"https://avatars.githubusercontent.com/u/44708?v=4"},"body":"Signed-off-by: Pierre Habouzit <madcoder@debian.org>\n---\n builtin-branch.c |    4 ++--\n builtin-revert.c |    2 +-\n daemon.c         |    2 +-\n wt-status.c      |    2 +-\n xdiff/xemit.c    |    4 ++--\n 5 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/builtin-branch.c b/builtin-branch.c\nindex 67f46c1..da48051 100644\n--- a/builtin-branch.c\n+++ b/builtin-branch.c\n@@ -55,7 +55,7 @@ static int parse_branch_color_slot(const char *var, int ofs)\n \tdie(\"bad config variable '%s'\", var);\n }\n \n-int git_branch_config(const char *var, const char *value)\n+static int git_branch_config(const char *var, const char *value)\n {\n \tif (!strcmp(var, \"color.branch\")) {\n \t\tbranch_use_color = git_config_colorbool(var, value);\n@@ -72,7 +72,7 @@ int git_branch_config(const char *var, const char *value)\n \treturn git_default_config(var, value);\n }\n \n-const char *branch_get_color(enum color_branch ix)\n+static const char *branch_get_color(enum color_branch ix)\n {\n \tif (branch_use_color)\n \t\treturn branch_colors[ix];\ndiff --git a/builtin-revert.c b/builtin-revert.c\nindex 80c348c..8f02ed7 100644\n--- a/builtin-revert.c\n+++ b/builtin-revert.c\n@@ -107,7 +107,7 @@ static char *get_oneline(const char *message)\n \treturn result;\n }\n \n-char *get_encoding(const char *message)\n+static char *get_encoding(const char *message)\n {\n \tconst char *p = message, *eol;\n \ndiff --git a/daemon.c b/daemon.c\nindex 674e30d..4c8c322 100644\n--- a/daemon.c\n+++ b/daemon.c\n@@ -439,7 +439,7 @@ static void parse_extra_args(struct interp *table, char *extra_args, int buflen)\n \t}\n }\n \n-void fill_in_extra_table_entries(struct interp *itable)\n+static void fill_in_extra_table_entries(struct interp *itable)\n {\n \tchar *hp;\n \ndiff --git a/wt-status.c b/wt-status.c\nindex 4bfe8f1..5205420 100644\n--- a/wt-status.c\n+++ b/wt-status.c\n@@ -198,7 +198,7 @@ static void wt_read_cache(struct wt_status *s)\n \tread_cache();\n }\n \n-void wt_status_print_initial(struct wt_status *s)\n+static void wt_status_print_initial(struct wt_status *s)\n {\n \tint i;\n \tchar buf[PATH_MAX];\ndiff --git a/xdiff/xemit.c b/xdiff/xemit.c\nindex e291dc7..86315b7 100644\n--- a/xdiff/xemit.c\n+++ b/xdiff/xemit.c\n@@ -99,8 +99,8 @@ static void xdl_find_func(xdfile_t *xf, long i, char *buf, long sz, long *ll) {\n }\n \n \n-int xdl_emit_common(xdfenv_t *xe, xdchange_t *xscr, xdemitcb_t *ecb,\n-\t\t    xdemitconf_t const *xecfg) {\n+static int xdl_emit_common(xdfenv_t *xe, xdchange_t *xscr, xdemitcb_t *ecb,\n+                           xdemitconf_t const *xecfg) {\n \txdfile_t *xdf = &xe->xdf1;\n \tconst char *rchg = xdf->rchg;\n \tlong ix;\n-- \n1.5.2.1\n"}]}