{"thread":{"id":"8443","subject":"Git requires zip?","startedAt":"2007-06-05T16:16:36Z","lastAt":"2007-06-09T14:37:56Z","messageCount":5,"participants":["Linus Torvalds","Johannes Schindelin","René Scharfe"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"44078","messageId":"alpine.LFD.0.98.0706050908520.23741@woody.linux-foundation.org","threadId":"8443","inReplyTo":null,"subject":"Git requires zip?","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2007-06-05T16:16:36Z","receivedAt":"2007-06-05T16:16:36Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\nIt really shouldn't, but \"make test\" seems very unhappy if the machine \ndoesn't have it, and I don't see anything that disables the tests for that \ncase..\n\n\t\tLinus\n"},{"id":"44086","messageId":"Pine.LNX.4.64.0706051819290.4046@racer.site","threadId":"8443","inReplyTo":"alpine.LFD.0.98.0706050908520.23741@woody.linux-foundation.org","subject":"Re: Git requires zip?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-06-05T17:21:43Z","receivedAt":"2007-06-05T17:21:43Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 5 Jun 2007, Linus Torvalds wrote:\n\n> It really shouldn't, but \"make test\" seems very unhappy if the machine \n> doesn't have it, and I don't see anything that disables the tests for \n> that case..\n\nI seem to remember that I patched it already.\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/46854/focus=46899\n\nUnfortunately, the patch was incorrect, and I forgot to do it properly. \nWill try this afternoon.\n\nSorry,\nDscho\n"},{"id":"44182","messageId":"Pine.LNX.4.64.0706061956540.4046@racer.site","threadId":"8443","inReplyTo":"Pine.LNX.4.64.0706051819290.4046@racer.site","subject":"[PATCH] t5000: skip ZIP tests if unzip was not found","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-06-06T18:57:40Z","receivedAt":"2007-06-06T18:57:40Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\n\tOn Tue, 5 Jun 2007, Johannes Schindelin wrote:\n\n\t> I seem to remember that I patched it already.\n\t> \n\t> http://thread.gmane.org/gmane.comp.version-control.git/46854/focus=46899\n\t> \n\t> Unfortunately, the patch was incorrect, and I forgot to do it \n\t> properly. Will try this afternoon.\n\n\tSo, took me some more time. Sorry.\n\n t/t5000-tar-tree.sh |    7 +++++++\n 1 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex e223c07..5500505 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -108,6 +108,13 @@ test_expect_success \\\n     'git-archive --format=zip' \\\n     'git-archive --format=zip HEAD >d.zip'\n \n+$UNZIP -v 2>/dev/null\n+if [ $? -eq 127 ]; then\n+\techo \"Skipping ZIP tests, because unzip was not found\"\n+\ttest_done\n+\texit\n+fi\n+\n test_expect_success \\\n     'extract ZIP archive' \\\n     '(mkdir d && cd d && $UNZIP ../d.zip)'\n"},{"id":"44433","messageId":"466A4930.2020602@lsrfire.ath.cx","threadId":"8443","inReplyTo":"Pine.LNX.4.64.0706061956540.4046@racer.site","subject":"[PATCH] t5000: silence unzip availability check","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2007-06-09T06:31:12Z","receivedAt":"2007-06-09T06:31:12Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"unzip -v on (at least) Ubuntu prints a screenful of version info\nto stdout.  Get rid of it since we only want to know if unzip is\ninstalled or not.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex 5500505..a6c5bf6 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -108,7 +108,7 @@ test_expect_success \\\n     'git-archive --format=zip' \\\n     'git-archive --format=zip HEAD >d.zip'\n \n-$UNZIP -v 2>/dev/null\n+$UNZIP -v >/dev/null 2>&1\n if [ $? -eq 127 ]; then\n \techo \"Skipping ZIP tests, because unzip was not found\"\n \ttest_done\n"},{"id":"44447","messageId":"Pine.LNX.4.64.0706091526380.4059@racer.site","threadId":"8443","inReplyTo":"466A4930.2020602@lsrfire.ath.cx","subject":"Re: [PATCH] t5000: silence unzip availability check","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-06-09T14:37:56Z","receivedAt":"2007-06-09T14:37:56Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 9 Jun 2007, René Scharfe wrote:\n\n> unzip -v on (at least) Ubuntu prints a screenful of version info\n> to stdout.  Get rid of it since we only want to know if unzip is\n> installed or not.\n\nMakes sense, absolutely.\n\nACK,\nDscho"}]}