{"thread":{"id":"8416","subject":"[tig PATCH] Fix integer type mismatch on 64-bit systems","startedAt":"2007-06-03T21:12:06Z","lastAt":"2007-06-04T06:47:34Z","messageCount":2,"participants":["Steven Grimm","Jonas Fonseca"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43911","messageId":"20070603211206.GA16445@midwinter.com","threadId":"8416","inReplyTo":null,"subject":"[tig PATCH] Fix integer type mismatch on 64-bit systems","fromName":"Steven Grimm","fromEmail":"koreth@midwinter.com","sentAt":"2007-06-03T21:12:06Z","receivedAt":"2007-06-03T21:12:06Z","isPatch":true,"sender":{"key":"koreth@midwinter.com","avatar":"https://gravatar.com/avatar/71b4d2e8b62f168bdc9e9205341159e3567003b4f9e2127c617c5fa0a1f5bad2?d=mp&s=160"},"body":"fprintf wants an int parameter for the field width of a \"%.*s\" expression, but\nthe code was passing a size_t instead. This potentially broke systems where\nsizeof(size_t) != sizeof(int). And even on systems where it did't break,\nit still caused a compiler warning.\n---\n tig.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/tig.c b/tig.c\nindex 6adfb33..b09d91b 100644\n--- a/tig.c\n+++ b/tig.c\n@@ -1153,7 +1153,7 @@ read_option(char *opt, size_t optlen, char *value, size_t valuelen)\n \n \tif (status == ERR) {\n \t\tfprintf(stderr, \"Error on line %d, near '%.*s': %s\\n\",\n-\t\t\tconfig_lineno, optlen, opt, config_msg);\n+\t\t\tconfig_lineno, (int) optlen, opt, config_msg);\n \t\tconfig_errors = TRUE;\n \t}\n \n-- \n1.5.2.35.ga334\n"},{"id":"43945","messageId":"2c6b72b30706032347m6a67fcf7h6b56c1d1078c1ffd@mail.gmail.com","threadId":"8416","inReplyTo":"20070603211206.GA16445@midwinter.com","subject":"Re: [tig PATCH] Fix integer type mismatch on 64-bit systems","fromName":"Jonas Fonseca","fromEmail":"jonas.fonseca@gmail.com","sentAt":"2007-06-04T06:47:34Z","receivedAt":"2007-06-04T06:47:34Z","isPatch":true,"sender":{"key":"jonas.fonseca@gmail.com","avatar":"https://gravatar.com/avatar/9b7fa23cce50269e5d164312b6ac5ae818a180f837b38f28f3bdf689dd7f96cd?d=mp&s=160"},"body":"On 6/3/07, Steven Grimm <koreth@midwinter.com> wrote:\n> fprintf wants an int parameter for the field width of a \"%.*s\" expression, but\n> the code was passing a size_t instead. This potentially broke systems where\n> sizeof(size_t) != sizeof(int). And even on systems where it did't break,\n> it still caused a compiler warning.\n\nThanks, I also fixed another such occurrence.\n\nBTW, in good git spirit you are encouraged to sign off your patches. :)\n\n-- \nJonas Fonseca\n"}]}