{"thread":{"id":"84","subject":"[PATCH] Fix +x-related show-diff false positives","startedAt":"2005-04-17T11:44:51Z","lastAt":"2005-04-17T11:44:51Z","messageCount":1,"participants":["Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"466","messageId":"20050417114451.GB1487@pasky.ji.cz","threadId":"84","inReplyTo":null,"subject":"[PATCH] Fix +x-related show-diff false positives","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-04-17T11:44:51Z","receivedAt":"2005-04-17T11:44:51Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"  Hi,\n\n  the following patch fixes show-diff listing all +x files as differring.\n\nSigned-off-by: Petr Baudis <pasky@ucw.cz>\n--- read-cache.c\n+++ read-cache.c\t2005-04-17 13:42:13.322938268 +0200\n@@ -306,7 +306,7 @@\n \t    ce->ce_gid != htonl(st->st_gid))\n \t\tchanged |= OWNER_CHANGED;\n \t/* We consider only the owner x bit to be relevant for \"mode changes\" */\n-\tif (0100 & (ntohs(ce->ce_mode) ^ st->st_mode))\n+\tif (0100 & (ntohl(ce->ce_mode) ^ st->st_mode))\n \t\tchanged |= MODE_CHANGED;\n \tif (ce->ce_dev != htonl(st->st_dev) ||\n \t    ce->ce_ino != htonl(st->st_ino))\n\n  (It is against my tree, but I think it should apply cleanly to yours\ntoo; perhaps with a tiny offset.)\n\n  Kind regards,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"}]}