{"thread":{"id":"8388","subject":"[PATCH] Use =20 when rfc2047 encoding spaces.","startedAt":"2007-06-01T21:08:12Z","lastAt":"2007-06-03T00:46:47Z","messageCount":5,"participants":["Kristian Høgsberg","Jeffrey C. Ollie","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43762","messageId":"11807320922292-git-send-email-hoegsberg@gmail.com","threadId":"8388","inReplyTo":null,"subject":"[PATCH] Use =20 when rfc2047 encoding spaces.","fromName":"Kristian Høgsberg","fromEmail":"hoegsberg@gmail.com","sentAt":"2007-06-01T21:08:12Z","receivedAt":"2007-06-01T21:08:12Z","isPatch":true,"sender":{"key":"hoegsberg@gmail.com","avatar":null},"body":"Encode ' ' using '=20' even though rfc2047 allows using '_' for\nreadability. Unfortunately, much software doesn't understand this and just\nleaves the underscore in place. Using '=20' seems to work better.\n\nSigned-off-by: Kristian Høgsberg \n---\n commit.c | 8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/commit.c b/commit.c\nindex bee066f..92b46f1 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -511,12 +511,14 @@ static int add_rfc2047(char *buf, const char *line, int len,\n \tbp += i;\n \tfor (i = 0; i < len; i++) {\n \t\tunsigned ch = line[i] & 0xFF;\n-\t\tif (is_rfc2047_special(ch)) {\n+\t\t/* We encode ' ' using '=20' even though rfc2047\n+\t\t * allows using '_' for readability. Unfortunately,\n+\t\t * doesn't understand this and just leaves the\n+\t\t * underscore in place. */\n+\t\tif (is_rfc2047_special(ch) || ch == ' ') {\n \t\t\tsprintf(bp, \"=%02X\", ch);\n \t\t\tbp += 3;\n \t\t}\n-\t\telse if (ch == ' ')\n-\t\t\t*bp++ = '_';\n \t\telse\n \t\t\t*bp++ = ch;\n \t}\n-- \n1.5.0.6\n"},{"id":"43763","messageId":"1180732323.3890.33.camel@lt21223.campus.dmacc.edu","threadId":"8388","inReplyTo":"11807320922292-git-send-email-hoegsberg@gmail.com","subject":"Re: [PATCH] Use =20 when rfc2047 encoding spaces.","fromName":"Jeffrey C. Ollie","fromEmail":"jeff@ocjtech.us","sentAt":"2007-06-01T21:12:03Z","receivedAt":"2007-06-01T21:12:03Z","isPatch":true,"sender":{"key":"jeff@ocjtech.us","avatar":"https://gravatar.com/avatar/95918a1992f277a811c471ae7275f7e4c9d1a2e517ad290bd6aa93b97e8d34f3?d=mp&s=160"},"body":"On Fri, 2007-06-01 at 17:08 -0400, Kristian Høgsberg wrote:\n>\n> -\t\tif (is_rfc2047_special(ch)) {\n> +\t\t/* We encode ' ' using '=20' even though rfc2047\n> +\t\t * allows using '_' for readability. Unfortunately,\n> +\t\t * doesn't understand this and just leaves the\n> +\t\t * underscore in place. */\n> +\t\tif (is_rfc2047_special(ch) || ch == ' ') {\n\nLooks like \"much software\" got left out of the comment.\n\nJeff\n\n"},{"id":"43821","messageId":"7vd50eqjef.fsf@assigned-by-dhcp.cox.net","threadId":"8388","inReplyTo":"11807320922292-git-send-email-hoegsberg@gmail.com","subject":"Re: [PATCH] Use =20 when rfc2047 encoding spaces.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-06-02T18:51:52Z","receivedAt":"2007-06-02T18:51:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kristian Høgsberg writes:\n\n> Encode ' ' using '=20' even though rfc2047 allows using '_' for\n> readability..\n\nThanks.\n\nYour message was marked as iso-8859-1 even though it was utf-8\n(your signed-off-by line), so I'll fix it up with your From:\nheader.\n"},{"id":"43822","messageId":"7v8xb2qj37.fsf@assigned-by-dhcp.cox.net","threadId":"8388","inReplyTo":"7vd50eqjef.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Use =20 when rfc2047 encoding spaces.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-06-02T18:58:36Z","receivedAt":"2007-06-02T18:58:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Kristian Høgsberg writes:\n>\n>> Encode ' ' using '=20' even though rfc2047 allows using '_' for\n>> readability..\n>\n> Thanks.\n>\n> Your message was marked as iso-8859-1 even though it was utf-8\n> (your signed-off-by line), so I'll fix it up with your From:\n> header.\n\nOh, another thing. Before you submit a patch, make sure the\nwhole testsuite in t/ passes by running \"make test\".\n"},{"id":"43841","messageId":"Pine.LNX.4.64.0706030145420.4046@racer.site","threadId":"8388","inReplyTo":"7v8xb2qj37.fsf@assigned-by-dhcp.cox.net","subject":"[PATCH] Update to SubmittingPatches","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-06-03T00:46:47Z","receivedAt":"2007-06-03T00:46:47Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nMake people aware of our testsuite, and of non-ASCII encodings.\n\nSigned-off-by: Johannes Schindelin \n---\n\n\tOn Sat, 2 Jun 2007, Junio C Hamano wrote:\n\n\t> Junio C Hamano writes:\n\t> \n\t> > Kristian Høgsberg writes:\n\t> >\n\t> >> Encode ' ' using '=20' even though rfc2047 allows using '_' for\n\t> >> readability..\n\t> >\n\t> > Thanks.\n\t> >\n\t> > Your message was marked as iso-8859-1 even though it was utf-8\n\t> > (your signed-off-by line), so I'll fix it up with your From:\n\t> > header.\n\t> \n\t> Oh, another thing. Before you submit a patch, make sure the\n\t> whole testsuite in t/ passes by running \"make test\".\n\n\tWe should remind people of both.\n\n Documentation/SubmittingPatches | 4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex b5f2ecd..b6e5847 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -14,6 +14,8 @@ Checklist (and a short version for the impatient):\n \t commit message (or just use the option \"-s\" when\n \t committing) to confirm that you agree to the Developer's\n \t Certificate of Origin\n+\t- make sure that you have tests for the bug you are fixing\n+\t- make sure that the test suit passes after your commit\n \n \tPatch:\n \n@@ -33,6 +35,8 @@ Checklist (and a short version for the impatient):\n \t- if you change, add, or remove a command line option or\n \t make some other user interface change, the associated\n \t documentation should be updated as well.\n+\t- if your name is not writable in ASCII, make sure that \n+\t you send off a message in the correct encoding.\n \n Long version:\n \n-- \n1.5.2.2663.gd77e7-dirty\n"}]}