{"thread":{"id":"8384","subject":"Re: [PATCH] gitweb: use decode_utf8 directly","startedAt":"2007-06-01T16:13:16Z","lastAt":"2007-06-01T16:13:16Z","messageCount":1,"participants":["Martin Koegler"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43745","messageId":"20070601161316.GA19526@auto.tuwien.ac.at","threadId":"8384","inReplyTo":null,"subject":"Re: [PATCH] gitweb: use decode_utf8 directly","fromName":"Martin Koegler","fromEmail":"mkoegler@auto.tuwien.ac.at","sentAt":"2007-06-01T16:13:16Z","receivedAt":"2007-06-01T16:13:16Z","isPatch":true,"sender":{"key":"mkoegler@auto.tuwien.ac.at","avatar":null},"body":"Alexandre Julliard wrote:\n>Junio C Hamano <junkio@cox.net> writes:\n> > I would say that the patch is an improvement from the current\n> > code so it should hit 'master'; I was a bit busy lately and then\n> > am sick, and also we are post -rc1 freeze now and I was being\n> > cautious, just in case some nacks from more informed parties\n> > arrive late.\n> \n> Sorry for the late nack, but it turns out that this patch breaks diff\n> output on the Wine server for files that are not utf-8.\n> \n> The cause is apparently that decode_utf8() returns undef for invalid\n> sequences instead of substituting a replacement char like\n> decode(\"utf8\") does.\n> \n> That may be considered an Encode bug since we are running a fairly old\n> version (1.99, coming with Debian 3.1), but I'd rather not upgrade\n> perl on the server. Could the patch be reverted, or done differently?\n\nI hit the same problem:\nhttp://marc.info/?l=git&m=117978122420441&w=2\n\nOn my system, I use this patch as workaround:\nhttp://marc.info/?l=git&m=118038526531694&w=2\n\nmfg Martin Kögler\n"}]}