{"thread":{"id":"8378","subject":"[PATCH (tig)] Supply explicit permission bits to 'install'.","startedAt":"2007-05-31T19:20:32Z","lastAt":"2007-05-31T19:54:22Z","messageCount":2,"participants":["Jeffrey C. Ollie","Jonas Fonseca"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43691","messageId":"11806392321132-git-send-email-jeff@ocjtech.us","threadId":"8378","inReplyTo":null,"subject":"[PATCH (tig)] Supply explicit permission bits to 'install'.","fromName":"Jeffrey C. Ollie","fromEmail":"jeff@ocjtech.us","sentAt":"2007-05-31T19:20:32Z","receivedAt":"2007-05-31T19:20:32Z","isPatch":true,"sender":{"key":"jeff@ocjtech.us","avatar":"https://gravatar.com/avatar/95918a1992f277a811c471ae7275f7e4c9d1a2e517ad290bd6aa93b97e8d34f3?d=mp&s=160"},"body":"'install' will install files with permissions set to '0755' if the\npermissions are not specified on the command line.  Having the execute\nbits set on non-executable content is not desireable.  Specify mode\n0644 for non-executable content as well as specify mode 0755 for\nexecutable content (in case the defaults change or are different on\ndifferent systems).  Also tell 'install' to preserve timestamps.\n\nSigned-off-by: Jeffrey C. Ollie <jeff@ocjtech.us>\n---\n Makefile |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 57196b0..f9adecb 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -38,7 +38,7 @@ doc-html: $(HTMLDOC)\n install: all\n \tmkdir -p $(DESTDIR)$(bindir) && \\\n \tfor prog in $(PROGS); do \\\n-\t\tinstall $$prog $(DESTDIR)$(bindir); \\\n+\t\tinstall -p -m 0755 $$prog $(DESTDIR)$(bindir); \\\n \tdone\n \n install-doc-man: doc-man\n@@ -46,8 +46,8 @@ install-doc-man: doc-man\n \t\t $(DESTDIR)$(mandir)/man5\n \tfor doc in $(MANDOC); do \\\n \t\tcase \"$$doc\" in \\\n-\t\t*.1) install $$doc $(DESTDIR)$(mandir)/man1 ;; \\\n-\t\t*.5) install $$doc $(DESTDIR)$(mandir)/man5 ;; \\\n+\t\t*.1) install -p -m 0644 $$doc $(DESTDIR)$(mandir)/man1 ;; \\\n+\t\t*.5) install -p -m 0644 $$doc $(DESTDIR)$(mandir)/man5 ;; \\\n \t\tesac \\\n \tdone\n \n-- \n1.5.2.GIT\n"},{"id":"43694","messageId":"20070531195422.GA9260@diku.dk","threadId":"8378","inReplyTo":"11806392321132-git-send-email-jeff@ocjtech.us","subject":"Re: [PATCH (tig)] Supply explicit permission bits to 'install'.","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2007-05-31T19:54:22Z","receivedAt":"2007-05-31T19:54:22Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Jeffrey C. Ollie <jeff@ocjtech.us> wrote Thu, May 31, 2007:\n> 'install' will install files with permissions set to '0755' if the\n> permissions are not specified on the command line.  Having the execute\n> bits set on non-executable content is not desireable.  Specify mode\n> 0644 for non-executable content as well as specify mode 0755 for\n> executable content (in case the defaults change or are different on\n> different systems).  Also tell 'install' to preserve timestamps.\n\nThank you. I updated the patch to install HTML files with explicit\npermissions.\n\n-- \nJonas Fonseca\n"}]}