{"thread":{"id":"8362","subject":"Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux","startedAt":"2007-05-30T06:51:09Z","lastAt":"2007-05-30T13:43:09Z","messageCount":5,"participants":["Johannes Sixt","Nguyen Thai Ngoc Duy","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"43623","messageId":"465D1EDD.658483B4@eudaptics.com","threadId":"8362","inReplyTo":"11804928354163-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux","fromName":"Johannes Sixt","fromEmail":"j.sixt@eudaptics.com","sentAt":"2007-05-30T06:51:09Z","receivedAt":"2007-05-30T06:51:09Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"\"Nguyễn Thái Ngọc Duy\" wrote:\n> \n> The following patches allow to cross compile mingw port from Linux less painful.\n\nThank you. Could you please push this to the mob branch?\n\ngit push mob@repo.or.cz:/srv/git/git/mingw.git +mybranch:mob\n\nThe series should be based on mingw.git's master branch (not devel)!\n\n-- Hannes\n"},{"id":"43628","messageId":"465D6796.27B65043@eudaptics.com","threadId":"8362","inReplyTo":"1180492848275-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH 4/4] Don't link with libsocket in MINGW port","fromName":"Johannes Sixt","fromEmail":"j.sixt@eudaptics.com","sentAt":"2007-05-30T12:01:26Z","receivedAt":"2007-05-30T12:01:26Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"\"Nguyễn Thái Ngọc Duy\" wrote:\n> \n> From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n> \n> There is a check in configure.ac to determine if libc has function\n> socket(). It is used to link with libsocket on SunOS.\n> \n> On Windows, libc does not have socket() as well but it is provided\n> by winsock, not libsocket. So don't link with libsocket if you are\n> on Windows.\n\n>  ifdef NEEDS_SOCKET\n> +ifndef MINGW\n>         EXTLIBS += -lsocket\n>  endif\n> +endif\n\nThis looks wrong. NEEDS_SOCKET is set in the architecture sections of\nMakefile where necessary, but the MinGW section doesn't want it and\ndoesn't set it. If ./configure sets it, then you should fix\nconfigure.ac, not work around in Makefile.\n\n-- Hannes\n\nPS: Appologies for the mangled name - this MUA is from the stone age.\n"},{"id":"43633","messageId":"fcaeb9bf0705300608y6ae9eb12i71635746defbec10@mail.gmail.com","threadId":"8362","inReplyTo":"465D6796.27B65043@eudaptics.com","subject":"Re: [PATCH 4/4] Don't link with libsocket in MINGW port","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2007-05-30T13:08:59Z","receivedAt":"2007-05-30T13:08:59Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On 5/30/07, Johannes Sixt <J.Sixt@eudaptics.com> wrote:\n> This looks wrong. NEEDS_SOCKET is set in the architecture sections of\n> Makefile where necessary, but the MinGW section doesn't want it and\n> doesn't set it. If ./configure sets it, then you should fix\n> configure.ac, not work around in Makefile.\n\nI did so because I didn't have SunOS to test so I'd rather not touch\nthe code detecting NEEDS_SOCKET in configure.ac. How about this patch:\n\ndiff --git a/configure.ac b/configure.ac\nindex 4a12cb0..0516fdb 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -173,6 +173,12 @@ test -n \"$NEEDS_LIBICONV\" && LIBS=\"$LIBS -liconv\"\n AC_CHECK_LIB([c], [socket],\n [NEEDS_SOCKET=],\n [NEEDS_SOCKET=YesPlease])\n+if test \"$NEEDS_SOCKET\" = YesPlease; then # more check\n+\tAC_CHECK_LIB([socket], [socket],\n+\t[LIBSOCKET_HAS_SOCKET=],\n+\t[LIBSOCKET_HAS_SOCKET=1])\n+\ttest -n \"$LIBSOCKET_HAS_SOCKET\" && NEEDS_SOCKET=\n+fi\n AC_SUBST(NEEDS_SOCKET)\n test -n \"$NEEDS_SOCKET\" && LIBS=\"$LIBS -lsocket\"\n\nIf someone has a SunOS, please test the above patch. Thanks\n-- \nDuy\n"},{"id":"43635","messageId":"Pine.LNX.4.64.0705301411190.4011@racer.site","threadId":"8362","inReplyTo":"465D1EDD.658483B4@eudaptics.com","subject":"Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-05-30T13:11:59Z","receivedAt":"2007-05-30T13:11:59Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 30 May 2007, Johannes Sixt wrote:\n\n> \"Nguyễn Thái Ngọc Duy\" wrote:\n> > \n> > The following patches allow to cross compile mingw port from Linux less painful.\n> \n> Thank you. Could you please push this to the mob branch?\n> \n> git push mob@repo.or.cz:/srv/git/git/mingw.git +mybranch:mob\n> \n> The series should be based on mingw.git's master branch (not devel)!\n\nIs there any good reason why you do that in such a secretive manner? I \nhave not seen this series on the list, just your replies.\n\nCiao,\nDscho\n"},{"id":"43637","messageId":"Pine.LNX.4.64.0705301442100.4011@racer.site","threadId":"8362","inReplyTo":"fcaeb9bf0705300618s712be8auf29ba7bd3579bd16@mail.gmail.com","subject":"Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-05-30T13:43:09Z","receivedAt":"2007-05-30T13:43:09Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 30 May 2007, Nguyen Thai Ngoc Duy wrote:\n\n> On 5/30/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:\n> > \n> > On Wed, 30 May 2007, Johannes Sixt wrote:\n> > \n> > > \"Nguyễn Thái Ngọc Duy\" wrote:\n> > > >\n> > > > The following patches allow to cross compile mingw port from Linux less\n> > painful.\n> > >\n> > > Thank you. Could you please push this to the mob branch?\n> > >\n> > > git push mob@repo.or.cz:/srv/git/git/mingw.git +mybranch:mob\n> > >\n> > > The series should be based on mingw.git's master branch (not devel)!\n> > \n> > Is there any good reason why you do that in such a secretive manner? I\n> > have not seen this series on the list, just your replies.\n> \n> It's vger that should be blamed, not me :) I sent the series to\n> Johannes Sixt and CC git@vger but they never came.\n\nThat explains it. I notice that your mail did not come through again... \nMaybe vger should grow a facility where you can check _why_ a mail does \nnot go through. Sort of frustrating otherwise.\n\nCiao,\nDscho\n"}]}