{"thread":{"id":"8331","subject":"[PATCH] move template_dir logic to configure script.","startedAt":"2007-05-26T23:07:28Z","lastAt":"2007-05-29T06:46:47Z","messageCount":2,"participants":["Han-Wen Nienhuys","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"43380","messageId":"4658BDB0.9040501@xs4all.nl","threadId":"8331","inReplyTo":null,"subject":"[PATCH] move template_dir logic to configure script.","fromName":"Han-Wen Nienhuys","fromEmail":"hanwen@xs4all.nl","sentAt":"2007-05-26T23:07:28Z","receivedAt":"2007-05-26T23:07:28Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"\n---\n config.mak.in |    2 +-\n configure.ac  |    6 ++++++\n 2 files changed, 7 insertions(+), 1 deletions(-)\n\ndiff --git a/config.mak.in b/config.mak.in\nindex 9a57840..12a541f 100644\n--- a/config.mak.in\n+++ b/config.mak.in\n@@ -12,7 +12,7 @@ exec_prefix = @exec_prefix@\n bindir = @bindir@\n #gitexecdir = @libexecdir@/git-core/\n datarootdir = @datarootdir@\n-template_dir = @datadir@/git-core/templates/\n+template_dir = @template_dir@\n \n mandir=@mandir@\n \ndiff --git a/configure.ac b/configure.ac\nindex 7cfb3a0..d1622a6 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -323,6 +323,12 @@ GIT_PARSE_WITH(iconv))\n # change being considered an inode change from the update-cache perspective.\n \n \n+\n+AC_SUBST(template_dir)\n+if test \"$template_dir\" = \"\"; then\n+  template_dir='${datadir}/git-core/templates/'\n+fi\n+\n ## Output files\n AC_CONFIG_FILES([\"${config_file}\":\"${config_in}\":\"${config_append}\"])\n AC_OUTPUT\n-- \n1.5.0.6\n\n\n-- \n Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"43542","messageId":"7vk5us6sa0.fsf@assigned-by-dhcp.cox.net","threadId":"8331","inReplyTo":"4658BDB0.9040501@xs4all.nl","subject":"Re: [PATCH] move template_dir logic to configure script.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-29T06:46:47Z","receivedAt":"2007-05-29T06:46:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Han-Wen Nienhuys <hanwen@xs4all.nl> writes:\n\n> ---\n\nCould I have at least three lines above the --- marker, please?\n\n (1) Defend _why_ this is a good change --- I would agree that\n     this would make it more flexible, and I suspect that your\n     main thrust with this is on some platforms (perhaps\n     Windows?) you would want to have template_dir that is\n     somewhere away from datarootdir.\n\n (2) an empty line between (1) and (3)\n\n (3) Signed-off-by: line.\n\n>  config.mak.in |    2 +-\n>  configure.ac  |    6 ++++++\n>  2 files changed, 7 insertions(+), 1 deletions(-)\n"}]}