{"thread":{"id":"8227","subject":"[PATCH] Update bash completion to ignore some more plumbing commands","startedAt":"2007-05-19T21:35:21Z","lastAt":"2007-05-22T21:06:24Z","messageCount":3,"participants":["Jonas Fonseca","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"42651","messageId":"20070519213521.GA32221@diku.dk","threadId":"8227","inReplyTo":null,"subject":"[PATCH] Update bash completion to ignore some more plumbing commands","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2007-05-19T21:35:21Z","receivedAt":"2007-05-19T21:35:21Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Signed-off-by: Jonas Fonseca <fonseca@diku.dk>\n---\n contrib/completion/git-completion.bash |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\n I am not sure if it is OK to exclude checkout-index as it is\n the only method of exporting the source as a directory. Also,\n I don't understand why git-diff-* is not excluded.\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 46356e8..e758242 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -262,7 +262,9 @@ __git_commands ()\n \t\tapplypatch)       : ask gittus;;\n \t\tarchimport)       : import;;\n \t\tcat-file)         : plumbing;;\n+\t\tcheck-attr)       : plumbing;;\n \t\tcheck-ref-format) : plumbing;;\n+\t\tcheckout-index)   : plumbing;;\n \t\tcommit-tree)      : plumbing;;\n \t\tconvert-objects)  : plumbing;;\n \t\tcvsexportcommit)  : export;;\n@@ -271,8 +273,10 @@ __git_commands ()\n \t\tdaemon)           : daemon;;\n \t\tfast-import)      : import;;\n \t\tfsck-objects)     : plumbing;;\n+\t\tfetch--tool)      : plumbing;;\n \t\tfetch-pack)       : plumbing;;\n \t\tfmt-merge-msg)    : plumbing;;\n+\t\tfor-each-ref)     : plumbing;;\n \t\thash-object)      : plumbing;;\n \t\thttp-*)           : transport;;\n \t\tindex-pack)       : plumbing;;\n-- \n1.5.2.rc3.800.ga489e-dirty\n\n-- \nJonas Fonseca\n"},{"id":"42842","messageId":"20070521061228.GJ3141@spearce.org","threadId":"8227","inReplyTo":"20070519213521.GA32221@diku.dk","subject":"Re: [PATCH] Update bash completion to ignore some more plumbing commands","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-05-21T06:12:28Z","receivedAt":"2007-05-21T06:12:28Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Jonas Fonseca <fonseca@diku.dk> wrote:\n> Signed-off-by: Jonas Fonseca <fonseca@diku.dk>\n> ---\n>  contrib/completion/git-completion.bash |    4 ++++\n>  1 files changed, 4 insertions(+), 0 deletions(-)\n\nOK, sorry this missed 1.5.2.  I've applied it into my fastimport\nmaster branch, I guess it will be in the next 1.5.2 based release.\n;-)\n \n>  I am not sure if it is OK to exclude checkout-index as it is\n>  the only method of exporting the source as a directory. Also,\n\nIt might make sense to exclude checkout-index as plumbing, but I\nuse it myself so often (and tab complete it too) that I want to\nkeep it in.  So I deleted that one line out of your patch when I\napplied it.\n\n>  I don't understand why git-diff-* is not excluded.\n\nBecause I personally also use git diff-tree a lot.  The others\n(diff-files, diff-index) I *never* use directly so I'm thinking\nmaybe they should get flagged as plumbing and get removed from\nthe completion.\n\n-- \nShawn.\n"},{"id":"42990","messageId":"20070522210624.GA7518@diku.dk","threadId":"8227","inReplyTo":"20070521061228.GJ3141@spearce.org","subject":"Re: [PATCH] Update bash completion to ignore some more plumbing commands","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2007-05-22T21:06:24Z","receivedAt":"2007-05-22T21:06:24Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Shawn O. Pearce <spearce@spearce.org> wrote Mon, May 21, 2007:\n> Jonas Fonseca <fonseca@diku.dk> wrote:\n> > Signed-off-by: Jonas Fonseca <fonseca@diku.dk>\n> > ---\n> >  contrib/completion/git-completion.bash |    4 ++++\n> >  1 files changed, 4 insertions(+), 0 deletions(-)\n> \n> OK, sorry this missed 1.5.2.  I've applied it into my fastimport\n> master branch, I guess it will be in the next 1.5.2 based release.\n> ;-)\n\nGood! :) I didn't know, it was maintained in the fastimport branch. You\nmight consider mentioning it in the header of the file.\n\n> >  I am not sure if it is OK to exclude checkout-index as it is\n> >  the only method of exporting the source as a directory. Also,\n> \n> It might make sense to exclude checkout-index as plumbing, but I\n> use it myself so often (and tab complete it too) that I want to\n> keep it in.  So I deleted that one line out of your patch when I\n> applied it.\n\nVery well.\n\n> >  I don't understand why git-diff-* is not excluded.\n> \n> Because I personally also use git diff-tree a lot.  The others\n> (diff-files, diff-index) I *never* use directly so I'm thinking\n> maybe they should get flagged as plumbing and get removed from\n> the completion.\n\nOK.\n\n-- \nJonas Fonseca\n"}]}