{"thread":{"id":"8214","subject":"[PATCH] gitweb: Fix \"Use of uninitialized value\" warning in git_feed","startedAt":"2007-05-19T00:47:51Z","lastAt":"2007-05-19T02:49:11Z","messageCount":4,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"42574","messageId":"1179535671566-git-send-email-jnareb@gmail.com","threadId":"8214","inReplyTo":null,"subject":"[PATCH] gitweb: Fix \"Use of uninitialized value\" warning in git_feed","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-05-19T00:47:51Z","receivedAt":"2007-05-19T00:47:51Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Initial (root) commit has no parents, and $co{'parent'} is\nundefined. Use '--root' for initial commit.\n\nThis fixes \"Use of uninitialized value in open at gitweb/gitweb.perl\nline 4925.\" warning.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex fa8cc02..091cf9c 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4923,7 +4923,8 @@ XML\n \n \t\t# get list of changed files\n \t\topen my $fd, \"-|\", git_cmd(), \"diff-tree\", '-r', @diff_opts,\n-\t\t\t$co{'parent'}, $co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n+\t\t\t$co{'parent'} || \"--root\",\n+\t\t\t$co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n \t\t\tor next;\n \t\tmy @difftree = map { chomp; $_ } <$fd>;\n \t\tclose $fd\n-- \n1.5.1.4\n"},{"id":"42578","messageId":"7vtzu937t6.fsf@assigned-by-dhcp.cox.net","threadId":"8214","inReplyTo":"1179535671566-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Fix \"Use of uninitialized value\" warning in git_feed","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-19T01:45:25Z","receivedAt":"2007-05-19T01:45:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Initial (root) commit has no parents, and $co{'parent'} is\n> undefined. Use '--root' for initial commit.\n>\n> This fixes \"Use of uninitialized value in open at gitweb/gitweb.perl\n> line 4925.\" warning.\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> ---\n>  gitweb/gitweb.perl |    3 ++-\n>  1 files changed, 2 insertions(+), 1 deletions(-)\n>\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index fa8cc02..091cf9c 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -4923,7 +4923,8 @@ XML\n>  \n>  \t\t# get list of changed files\n>  \t\topen my $fd, \"-|\", git_cmd(), \"diff-tree\", '-r', @diff_opts,\n> -\t\t\t$co{'parent'}, $co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n> +\t\t\t$co{'parent'} || \"--root\",\n> +\t\t\t$co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n>  \t\t\tor next;\n>  \t\tmy @difftree = map { chomp; $_ } <$fd>;\n>  \t\tclose $fd\n\nI do not think you would need to make --root conditional...\n"},{"id":"42579","messageId":"200705190408.40702.jnareb@gmail.com","threadId":"8214","inReplyTo":"7vtzu937t6.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: Fix \"Use of uninitialized value\" warning in git_feed","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-05-19T02:08:40Z","receivedAt":"2007-05-19T02:08:40Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n>> Initial (root) commit has no parents, and $co{'parent'} is\n>> undefined. Use '--root' for initial commit.\n>>\n>> This fixes \"Use of uninitialized value in open at gitweb/gitweb.perl\n>> line 4925.\" warning.\n[...]\n>> --- a/gitweb/gitweb.perl\n>> +++ b/gitweb/gitweb.perl\n>> @@ -4923,7 +4923,8 @@ XML\n>>  \n>>  \t\t# get list of changed files\n>>  \t\topen my $fd, \"-|\", git_cmd(), \"diff-tree\", '-r', @diff_opts,\n>> -\t\t\t$co{'parent'}, $co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n>> +\t\t\t$co{'parent'} || \"--root\",\n>> +\t\t\t$co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n>>  \t\t\tor next;\n>>  \t\tmy @difftree = map { chomp; $_ } <$fd>;\n>>  \t\tclose $fd\n> \n> I do not think you would need to make --root conditional...\n\nI need at last make $co{'parent'} conditional, i.e. at least \n\"$co{'parent'} || ()\" or equivalent (e.g. like for $file_name).\nI cannot omit $co{'parent'} because parents might be rewritten;\nfeeds accept now path limiting. So why not this way?\n-- \nJakub Narebski\nPoland\n"},{"id":"42581","messageId":"7vps4x34uw.fsf@assigned-by-dhcp.cox.net","threadId":"8214","inReplyTo":"200705190408.40702.jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Fix \"Use of uninitialized value\" warning in git_feed","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-19T02:49:11Z","receivedAt":"2007-05-19T02:49:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Junio C Hamano wrote:\n>> Jakub Narebski <jnareb@gmail.com> writes:\n>> \n>>> Initial (root) commit has no parents, and $co{'parent'} is\n>>> undefined. Use '--root' for initial commit.\n>>>\n>>> This fixes \"Use of uninitialized value in open at gitweb/gitweb.perl\n>>> line 4925.\" warning.\n> [...]\n>>> --- a/gitweb/gitweb.perl\n>>> +++ b/gitweb/gitweb.perl\n>>> @@ -4923,7 +4923,8 @@ XML\n>>>  \n>>>  \t\t# get list of changed files\n>>>  \t\topen my $fd, \"-|\", git_cmd(), \"diff-tree\", '-r', @diff_opts,\n>>> -\t\t\t$co{'parent'}, $co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n>>> +\t\t\t$co{'parent'} || \"--root\",\n>>> +\t\t\t$co{'id'}, \"--\", (defined $file_name ? $file_name : ())\n>>>  \t\t\tor next;\n>>>  \t\tmy @difftree = map { chomp; $_ } <$fd>;\n>>>  \t\tclose $fd\n>> \n>> I do not think you would need to make --root conditional...\n>\n> I need at last make $co{'parent'} conditional, i.e. at least \n> \"$co{'parent'} || ()\" or equivalent (e.g. like for $file_name).\n> I cannot omit $co{'parent'} because parents might be rewritten;\n> feeds accept now path limiting. So why not this way?\n\nAh, clever (buuuuuuut misleading) ;-)\n"}]}