{"thread":{"id":"820","subject":"[PATCH] Anal retentive 'const unsigned char *sha1'","startedAt":"2005-06-03T15:05:39Z","lastAt":"2005-06-08T18:52:19Z","messageCount":2,"participants":["Jason McMullan","Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"4491","messageId":"20050603150539.GA3239@jmcmullan.timesys","threadId":"820","inReplyTo":null,"subject":"[PATCH] Anal retentive 'const unsigned char *sha1'","fromName":"Jason McMullan","fromEmail":"jason.mcmullan@timesys.com","sentAt":"2005-06-03T15:05:39Z","receivedAt":"2005-06-03T15:05:39Z","isPatch":true,"sender":{"key":"jason.mcmullan@timesys.com","avatar":null},"body":"Anal Retentive: make 'sha1' parameters const where possible\n\nSigned-off-by: Jason McMullan <jason.mcmullan@timesys.com>\n\ndiff --git a/blob.c b/blob.c\n--- a/blob.c\n+++ b/blob.c\n@@ -4,7 +4,7 @@\n \n const char *blob_type = \"blob\";\n \n-struct blob *lookup_blob(unsigned char *sha1)\n+struct blob *lookup_blob(const unsigned char *sha1)\n {\n \tstruct object *obj = lookup_object(sha1);\n \tif (!obj) {\ndiff --git a/blob.h b/blob.h\n--- a/blob.h\n+++ b/blob.h\n@@ -9,7 +9,7 @@ struct blob {\n \tstruct object object;\n };\n \n-struct blob *lookup_blob(unsigned char *sha1);\n+struct blob *lookup_blob(const unsigned char *sha1);\n \n int parse_blob_buffer(struct blob *item, void *buffer, unsigned long size);\n \ndiff --git a/cache.h b/cache.h\n--- a/cache.h\n+++ b/cache.h\n@@ -157,7 +157,7 @@ extern void * unpack_sha1_file(void *map\n extern void * read_sha1_file(const unsigned char *sha1, char *type, unsigned long *size);\n extern int write_sha1_file(void *buf, unsigned long len, const char *type, unsigned char *return_sha1);\n \n-extern int check_sha1_signature(unsigned char *sha1, void *buf, unsigned long size, const char *type);\n+extern int check_sha1_signature(const unsigned char *sha1, void *buf, unsigned long size, const char *type);\n \n /* Read a tree into the cache */\n extern int read_tree(void *buffer, unsigned long size, int stage);\ndiff --git a/commit.c b/commit.c\n--- a/commit.c\n+++ b/commit.c\n@@ -4,7 +4,7 @@\n \n const char *commit_type = \"commit\";\n \n-static struct commit *check_commit(struct object *obj, unsigned char *sha1)\n+static struct commit *check_commit(struct object *obj, const unsigned char *sha1)\n {\n \tif (obj->type != commit_type) {\n \t\terror(\"Object %s is a %s, not a commit\", \n@@ -14,7 +14,7 @@ static struct commit *check_commit(struc\n \treturn (struct commit *) obj;\n }\n \n-struct commit *lookup_commit_reference(unsigned char *sha1)\n+struct commit *lookup_commit_reference(const unsigned char *sha1)\n {\n \tstruct object *obj = parse_object(sha1);\n \n@@ -25,7 +25,7 @@ struct commit *lookup_commit_reference(u\n \treturn check_commit(obj, sha1);\n }\n \n-struct commit *lookup_commit(unsigned char *sha1)\n+struct commit *lookup_commit(const unsigned char *sha1)\n {\n \tstruct object *obj = lookup_object(sha1);\n \tif (!obj) {\ndiff --git a/commit.h b/commit.h\n--- a/commit.h\n+++ b/commit.h\n@@ -19,8 +19,8 @@ struct commit {\n \n extern const char *commit_type;\n \n-struct commit *lookup_commit(unsigned char *sha1);\n-struct commit *lookup_commit_reference(unsigned char *sha1);\n+struct commit *lookup_commit(const unsigned char *sha1);\n+struct commit *lookup_commit_reference(const unsigned char *sha1);\n \n int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size);\n \ndiff --git a/delta.c b/delta.c\n--- a/delta.c\n+++ b/delta.c\n@@ -17,7 +17,7 @@ struct delta {\n \t} u;\n };\n \n-struct delta *lookup_delta(unsigned char *sha1)\n+struct delta *lookup_delta(const unsigned char *sha1)\n {\n \tstruct object *obj = lookup_object(sha1);\n \tif (!obj) {\ndiff --git a/delta.h b/delta.h\n--- a/delta.h\n+++ b/delta.h\n@@ -12,7 +12,7 @@ extern void *patch_delta(void *src_buf, \n /* handling of delta objects */\n struct delta;\n struct object_list;\n-extern struct delta *lookup_delta(unsigned char *sha1);\n+extern struct delta *lookup_delta(const unsigned char *sha1);\n extern int parse_delta_buffer(struct delta *item, void *buffer, unsigned long size);\n extern int parse_delta(struct delta *item, unsigned char sha1);\n extern int process_deltas(void *src, unsigned long src_size,\ndiff --git a/object.c b/object.c\n--- a/object.c\n+++ b/object.c\n@@ -10,7 +10,7 @@ struct object **objs;\n int nr_objs;\n static int obj_allocs;\n \n-static int find_object(unsigned char *sha1)\n+static int find_object(const unsigned char *sha1)\n {\n \tint first = 0, last = nr_objs;\n \n@@ -31,7 +31,7 @@ static int find_object(unsigned char *sh\n         return -first-1;\n }\n \n-struct object *lookup_object(unsigned char *sha1)\n+struct object *lookup_object(const unsigned char *sha1)\n {\n \tint pos = find_object(sha1);\n \tif (pos >= 0)\n@@ -39,7 +39,7 @@ struct object *lookup_object(unsigned ch\n \treturn NULL;\n }\n \n-void created_object(unsigned char *sha1, struct object *obj)\n+void created_object(const unsigned char *sha1, struct object *obj)\n {\n \tint pos = find_object(sha1);\n \n@@ -98,7 +98,7 @@ void mark_reachable(struct object *obj, \n \t}\n }\n \n-struct object *parse_object(unsigned char *sha1)\n+struct object *parse_object(const unsigned char *sha1)\n {\n \tunsigned long mapsize;\n \tvoid *map = map_sha1_file(sha1, &mapsize);\ndiff --git a/object.h b/object.h\n--- a/object.h\n+++ b/object.h\n@@ -20,12 +20,12 @@ struct object {\n extern int nr_objs;\n extern struct object **objs;\n \n-struct object *lookup_object(unsigned char *sha1);\n+struct object *lookup_object(const unsigned char *sha1);\n \n-void created_object(unsigned char *sha1, struct object *obj);\n+void created_object(const unsigned char *sha1, struct object *obj);\n \n /** Returns the object, having parsed it to find out what it is. **/\n-struct object *parse_object(unsigned char *sha1);\n+struct object *parse_object(const unsigned char *sha1);\n \n void add_ref(struct object *refer, struct object *target);\n \ndiff --git a/sha1_file.c b/sha1_file.c\n--- a/sha1_file.c\n+++ b/sha1_file.c\n@@ -257,7 +257,7 @@ static char *find_sha1_file(const unsign\n \treturn NULL;\n }\n \n-int check_sha1_signature(unsigned char *sha1, void *map, unsigned long size, const char *type)\n+int check_sha1_signature(const unsigned char *sha1, void *map, unsigned long size, const char *type)\n {\n \tchar header[100];\n \tunsigned char real_sha1[20];\ndiff --git a/tag.c b/tag.c\n--- a/tag.c\n+++ b/tag.c\n@@ -3,7 +3,7 @@\n \n const char *tag_type = \"tag\";\n \n-struct tag *lookup_tag(unsigned char *sha1)\n+struct tag *lookup_tag(const unsigned char *sha1)\n {\n         struct object *obj = lookup_object(sha1);\n         if (!obj) {\ndiff --git a/tag.h b/tag.h\n--- a/tag.h\n+++ b/tag.h\n@@ -12,7 +12,7 @@ struct tag {\n \tchar *signature; /* not actually implemented */\n };\n \n-extern struct tag *lookup_tag(unsigned char *sha1);\n+extern struct tag *lookup_tag(const unsigned char *sha1);\n extern int parse_tag_buffer(struct tag *item, void *data, unsigned long size);\n extern int parse_tag(struct tag *item);\n \ndiff --git a/tree.c b/tree.c\n--- a/tree.c\n+++ b/tree.c\n@@ -73,7 +73,7 @@ int read_tree(void *buffer, unsigned lon\n \treturn read_tree_recursive(buffer, size, \"\", 0, stage);\n }\n \n-struct tree *lookup_tree(unsigned char *sha1)\n+struct tree *lookup_tree(const unsigned char *sha1)\n {\n \tstruct object *obj = lookup_object(sha1);\n \tif (!obj) {\ndiff --git a/tree.h b/tree.h\n--- a/tree.h\n+++ b/tree.h\n@@ -24,7 +24,7 @@ struct tree {\n \tstruct tree_entry_list *entries;\n };\n \n-struct tree *lookup_tree(unsigned char *sha1);\n+struct tree *lookup_tree(const unsigned char *sha1);\n \n int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size);\n \n======== end ========\n\n-- \nJason McMullan <jason.mcmullan@timesys.com>\nTimeSys Corporation\n"},{"id":"4713","messageId":"20050608185219.GG982@pasky.ji.cz","threadId":"820","inReplyTo":"20050603150539.GA3239@jmcmullan.timesys","subject":"Re: [PATCH] Anal retentive 'const unsigned char *sha1'","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-06-08T18:52:19Z","receivedAt":"2005-06-08T18:52:19Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Jun 03, 2005 at 05:05:39PM CEST, I got a letter\nwhere Jason McMullan <jason.mcmullan@timesys.com> told me that...\n> Anal Retentive: make 'sha1' parameters const where possible\n> \n> Signed-off-by: Jason McMullan <jason.mcmullan@timesys.com>\n\nThis seems as a generally Good Thing (tm). const is nice, isn't it?\nAny particular reason for not applying it?\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"}]}