{"thread":{"id":"8189","subject":"[PATCH] Document core.excludesfile for git-add","startedAt":"2007-05-17T05:08:50Z","lastAt":"2007-05-17T15:45:09Z","messageCount":5,"participants":["Michael Hendricks","Junio C Hamano","Petr Baudis","Johan Herland"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"42375","messageId":"1179378530822-git-send-email-michael@ndrix.org","threadId":"8189","inReplyTo":null,"subject":"[PATCH] Document core.excludesfile for git-add","fromName":"Michael Hendricks","fromEmail":"michael@ndrix.org","sentAt":"2007-05-17T05:08:50Z","receivedAt":"2007-05-17T05:08:50Z","isPatch":true,"sender":{"key":"michael@ndrix.org","avatar":"https://gravatar.com/avatar/315311e6daa79f24e5648f9534420c24ec48eada42efd4110f1d17167ff44fa8?d=mp&s=160"},"body":"During the discussion of core.excludesfile in the user-manual, I realized\nthat the configuration wasn't mentioned in the man pages.\n\nSigned-off-by: Michael Hendricks \n---\n Documentation/git-add.txt | 9 +++++++++\n 1 files changed, 9 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-add.txt b/Documentation/git-add.txt\nindex 27b9c0f..a0c9f68 100644\n--- a/Documentation/git-add.txt\n+++ b/Documentation/git-add.txt\n@@ -69,6 +69,15 @@ OPTIONS\n \tfor command-line options).\n \n \n+Configuration\n+-------------\n+\n+The optional configuration variable 'core.excludesfile' indicates a path to a\n+file containing patterns of file names to exclude from git-add, similar to\n+$GIT_DIR/info/exclude. Patterns in the exclude file are used in addition to\n+those in info/exclude. See link:repository-layout.html[repository layout].\n+\n+\n EXAMPLES\n --------\n git-add Documentation/\\\\*.txt::\n-- \n1.5.2.rc3.39.gaf9b-dirty\n"},{"id":"42378","messageId":"7vwsz89ftr.fsf@assigned-by-dhcp.cox.net","threadId":"8189","inReplyTo":"1179378530822-git-send-email-michael@ndrix.org","subject":"Re: [PATCH] Document core.excludesfile for git-add","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-17T05:31:12Z","receivedAt":"2007-05-17T05:31:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, but wouldn't this belong to Documentation/config.txt\ninstead, I wonder?\n"},{"id":"42401","messageId":"20070517143542.GB15709@ginosko.local","threadId":"8189","inReplyTo":"7vwsz89ftr.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Document core.excludesfile for git-add","fromName":"Michael Hendricks","fromEmail":"michael@ndrix.org","sentAt":"2007-05-17T14:35:44Z","receivedAt":"2007-05-17T14:35:44Z","isPatch":true,"sender":{"key":"michael@ndrix.org","avatar":"https://gravatar.com/avatar/315311e6daa79f24e5648f9534420c24ec48eada42efd4110f1d17167ff44fa8?d=mp&s=160"},"body":"On Wed, May 16, 2007 at 10:31:12PM -0700, Junio C Hamano wrote:\n> Thanks, but wouldn't this belong to Documentation/config.txt\n> instead, I wonder?\n\nIt appears to my untrained eye that core.excludesfiles only works for\ngit-add. It seems to have no effect on git-status and the only code\nthat mentions core.excludesfile is builtin-add.c\n\n-- \nMichael\n"},{"id":"42408","messageId":"20070517153921.GQ4489@pasky.or.cz","threadId":"8189","inReplyTo":"20070517143542.GB15709@ginosko.local","subject":"Re: [PATCH] Document core.excludesfile for git-add","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-05-17T15:39:21Z","receivedAt":"2007-05-17T15:39:21Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Thu, May 17, 2007 at 04:35:44PM CEST, Michael Hendricks wrote:\n> On Wed, May 16, 2007 at 10:31:12PM -0700, Junio C Hamano wrote:\n> > Thanks, but wouldn't this belong to Documentation/config.txt\n> > instead, I wonder?\n> \n> It appears to my untrained eye that core.excludesfiles only works for\n> git-add. It seems to have no effect on git-status and the only code\n> that mentions core.excludesfile is builtin-add.c\n\nI believe the current policy should be that all config options are at\nleast briefly listed in config.txt and possibly are described in more\ndetail in the documentation of relevant command.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nEver try. Ever fail. No matter. // Try again. Fail again. Fail better.\n\t\t-- Samuel Beckett\n"},{"id":"42409","messageId":"200705171745.09307.johan@herland.net","threadId":"8189","inReplyTo":"20070517143542.GB15709@ginosko.local","subject":"Re: [PATCH] Document core.excludesfile for git-add","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2007-05-17T15:45:09Z","receivedAt":"2007-05-17T15:45:09Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Thursday 17 May 2007, Michael Hendricks wrote:\n> On Wed, May 16, 2007 at 10:31:12PM -0700, Junio C Hamano wrote:\n> > Thanks, but wouldn't this belong to Documentation/config.txt\n> > instead, I wonder?\n> \n> It appears to my untrained eye that core.excludesfiles only works for\n> git-add. It seems to have no effect on git-status and the only code\n> that mentions core.excludesfile is builtin-add.c\n\nIf so, we should probably fix that. The set of ignore files parsed by \nrelevant git commands should be consistent. We don't want a situation \nwhere exclude patterns in a file are picked up by some git commands, but\nnot by others.\n\n...Johan\n\n-- \nJohan Herland, \nwww.herland.net\n"}]}