{"thread":{"id":"8109","subject":"[RFC] format-patch stuff","startedAt":"2007-05-12T15:36:54Z","lastAt":"2007-05-12T23:03:24Z","messageCount":5,"participants":["Daniel Barkalow","Junio C Hamano","Frank Lichtenheld","david@lang.hm"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"41928","messageId":"Pine.LNX.4.64.0705121109520.18541@iabervon.org","threadId":"8109","inReplyTo":null,"subject":"[RFC] format-patch stuff","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2007-05-12T15:36:54Z","receivedAt":"2007-05-12T15:36:54Z","isPatch":false,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"It would be nice if git-format-patch would generate a [PATCH 0/n] message \nat the start of the series if some option were given. This would, of \ncourse, have to be editted afterwards to include actual information, but \nit would at least be pre-generated in series and with the configured \nheaders and such.\n\nShouldn't the format.headers configuration automatically apply the correct \nline termination? Currently, you need to know to put in \\r\\n at the end of \neach one, and the example isn't even right (only puts \\n).\n\nOnce we've got library support for remotes configuration, it would be nice \nto be able to have \"mailto:\" remotes with emailed patch configuration \nstuff per-destination.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"},{"id":"41965","messageId":"7vy7jtx01y.fsf@assigned-by-dhcp.cox.net","threadId":"8109","inReplyTo":"Pine.LNX.4.64.0705121109520.18541@iabervon.org","subject":"Re: [RFC] format-patch stuff","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-12T20:24:25Z","receivedAt":"2007-05-12T20:24:25Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniel Barkalow writes:\n\n> It would be nice if git-format-patch would generate a [PATCH 0/n] message \n> at the start of the series if some option were given. This would, of \n> course, have to be editted afterwards to include actual information, but \n> it would at least be pre-generated in series and with the configured \n> headers and such.\n\nIt would be helpful for git-send-email users. I've done that by\nhand by copying 0001-*.txt to 0000-*.txt and editing as needed\nby hand.\n\n> Shouldn't the format.headers configuration automatically apply the correct \n> line termination? Currently, you need to know to put in \\r\\n at the end of \n> each one, and the example isn't even right (only puts \\n).\n\nSorry, I do not follow. Where does that \"\\r\\n\" come from? If\nyou are talking about RFC 2822 line ending conventions, I think\nthat is a job for MUA (including git-send-email). Remember,\nMUA's are not the only consumer of format-patch output.\n\nAlthough \"2.3. Body\" says \"CR and LF MUST only occur together as\nCRLF\", the body of the text we output from format-patch is a\nstraight text with LF termination and let the MUA handle that\nSMTP specific conversion. I do not think there is reason to\ntreat the header part any differently.\n"},{"id":"41974","messageId":"20070512214034.GD7184@planck.djpig.de","threadId":"8109","inReplyTo":"7vy7jtx01y.fsf@assigned-by-dhcp.cox.net","subject":"Re: [RFC] format-patch stuff","fromName":"Frank Lichtenheld","fromEmail":"frank@lichtenheld.de","sentAt":"2007-05-12T21:40:34Z","receivedAt":"2007-05-12T21:40:34Z","isPatch":false,"sender":{"key":"frank@lichtenheld.de","avatar":"https://gravatar.com/avatar/b9f1d4b120e138f157c9e480d0818197c474628923786adb98f30017cdb99c3c?d=mp&s=160"},"body":"On Sat, May 12, 2007 at 01:24:25PM -0700, Junio C Hamano wrote:\n> Daniel Barkalow writes:\n> \n> > It would be nice if git-format-patch would generate a [PATCH 0/n] message \n> > at the start of the series if some option were given. This would, of \n> > course, have to be editted afterwards to include actual information, but \n> > it would at least be pre-generated in series and with the configured \n> > headers and such.\n> \n> It would be helpful for git-send-email users. I've done that by\n> hand by copying 0001-*.txt to 0000-*.txt and editing as needed\n> by hand.\n\nBut git-send-email users can already use --compose which serves\nexactly this use case, doesn't it?\n\nI would have thought such an option would be useful exactly for\ngit-send-email non-users ;)\n\nGruesse,\n-- \nFrank Lichtenheld \nwww: http://www.djpig.de/\n"},{"id":"41980","messageId":"Pine.LNX.4.64.0705121553300.31357@asgard.lang.hm","threadId":"8109","inReplyTo":"Pine.LNX.4.64.0705121109520.18541@iabervon.org","subject":"Re: [RFC] format-patch stuff","fromName":"","fromEmail":"david@lang.hm","sentAt":"2007-05-12T22:54:28Z","receivedAt":"2007-05-12T22:54:28Z","isPatch":false,"sender":{"key":"david@lang.hm","avatar":null},"body":"On Sat, 12 May 2007, Daniel Barkalow wrote:\n\n> It would be nice if git-format-patch would generate a [PATCH 0/n] message\n> at the start of the series if some option were given. This would, of\n> course, have to be editted afterwards to include actual information, but\n> it would at least be pre-generated in series and with the configured\n> headers and such.\n\ninstead of the 0/n message be empty, have it start off listing the subject \nlines of the patches to follow (makeing it easier to add any comments \nabout them)\n\nDavid Lang\n"},{"id":"41982","messageId":"7viraxve4j.fsf@assigned-by-dhcp.cox.net","threadId":"8109","inReplyTo":"Pine.LNX.4.64.0705121553300.31357@asgard.lang.hm","subject":"Re: [RFC] format-patch stuff","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-12T23:03:24Z","receivedAt":"2007-05-12T23:03:24Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"david@lang.hm writes:\n\n> On Sat, 12 May 2007, Daniel Barkalow wrote:\n>\n>> It would be nice if git-format-patch would generate a [PATCH 0/n] message\n>> at the start of the series if some option were given. This would, of\n>> course, have to be editted afterwards to include actual information, but\n>> it would at least be pre-generated in series and with the configured\n>> headers and such.\n>\n> instead of the 0/n message be empty, have it start off listing the\n> subject lines of the patches to follow (makeing it easier to add any\n> comments about them)\n\nSounds sane. \"git-format-patch -n --cover origin..master\"?\n"}]}