{"thread":{"id":"8102","subject":"[PATCH 0/3] Fix assorted white space damage","startedAt":"2007-05-12T11:09:13Z","lastAt":"2007-05-13T18:57:33Z","messageCount":6,"participants":["Marco Costalba","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"41910","messageId":"e5bfff550705120409v629425aesc910927c26871323@mail.gmail.com","threadId":"8102","inReplyTo":null,"subject":"[PATCH 0/3] Fix assorted white space damage","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2007-05-12T11:09:13Z","receivedAt":"2007-05-12T11:09:13Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Following there is a 3 patch series to remove stealth whitespace.\n\nI have used the new 'cleanfile' script by H. Peter Anvin, just merged\nin Linux tree.\n\nThe script cleans up various classes of stealth whitespace. In\nparticular, it cleans up:\n\n - Whitespace (spaces or tabs)before newline;\n - DOS line endings (CR before LF);\n - Space before tab (spaces are deleted or converted to tabs);\n - Empty lines at end of file.\n\n\nTested with\n\nmake\nmake install\nmake test\n\n\n Marco\n"},{"id":"41969","messageId":"7vhcqhwz2n.fsf@assigned-by-dhcp.cox.net","threadId":"8102","inReplyTo":"e5bfff550705120409v629425aesc910927c26871323@mail.gmail.com","subject":"Re: [PATCH 0/3] Fix assorted white space damage","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-12T20:45:36Z","receivedAt":"2007-05-12T20:45:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Allow me to chuck these at this moment. Could you redo this as\nthe first thing after v1.5.2 final, please?\n"},{"id":"41995","messageId":"7vzm49ts2f.fsf@assigned-by-dhcp.cox.net","threadId":"8102","inReplyTo":"e5bfff550705120409v629425aesc910927c26871323@mail.gmail.com","subject":"Re: [PATCH 0/3] Fix assorted white space damage","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-13T01:45:12Z","receivedAt":"2007-05-13T01:45:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Marco Costalba\" writes:\n\n> Following there is a 3 patch series to remove stealth whitespace.\n>\n> I have used the new 'cleanfile' script by H. Peter Anvin, just merged\n> in Linux tree.\n>\n> The script cleans up various classes of stealth whitespace. In\n> particular, it cleans up:\n>\n> - Whitespace (spaces or tabs)before newline;\n> - DOS line endings (CR before LF);\n> - Space before tab (spaces are deleted or converted to tabs);\n> - Empty lines at end of file.\n\nI haven't checked the script, but \"git-apply --whitespace=strip\"\ncan be used to do pretty much the same job with this sequence,\nexcept the last one (do it with a copy of repository if you do\nnot want \"git clean -x\" to lose untracked):\n\n\n\t$ git checkout master\n $ rm -f .git/index\n $ git checkout HEAD -- t/\n $ git clean -x -d\n\t$ git diff -R --binary HEAD >P.diff\n $ git apply --index --whitespace=strip P.diff\n\nThen you can check the results, and make a commit.\n\nIn the above I explicitly \"saved\" t/ because we have some test\nvectors that need to have trailing whitespaces.\n"},{"id":"41996","messageId":"e5bfff550705122029s2066ec0bwfebfec844a08dc3c@mail.gmail.com","threadId":"8102","inReplyTo":"7vhcqhwz2n.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 0/3] Fix assorted white space damage","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2007-05-13T03:29:23Z","receivedAt":"2007-05-13T03:29:23Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 5/12/07, Junio C Hamano wrote:\n> Allow me to chuck these at this moment. Could you redo this as\n> the first thing after v1.5.2 final, please?\n>\n>\n\nOk. I will be off-line for the next week.\n\nI will redo when coming back.\n\n\n Marco\n"},{"id":"42011","messageId":"Pine.LNX.4.64.0705131230230.6410@racer.site","threadId":"8102","inReplyTo":"7vzm49ts2f.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 0/3] Fix assorted white space damage","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-05-13T10:31:24Z","receivedAt":"2007-05-13T10:31:24Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 12 May 2007, Junio C Hamano wrote:\n\n> In the above I explicitly \"saved\" t/ because we have some test vectors \n> that need to have trailing whitespaces.\n\nAFAICT the documentation has trailing whitespace also, to indicate that \nthe paragraph does not end here. Correct me if I'm wrong, and these \ntrailing whitespaces are not necessary.\n\nCiao,\nDscho\n"},{"id":"42043","messageId":"7vk5vcsg9u.fsf@assigned-by-dhcp.cox.net","threadId":"8102","inReplyTo":"Pine.LNX.4.64.0705131230230.6410@racer.site","subject":"Re: [PATCH 0/3] Fix assorted white space damage","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-13T18:57:33Z","receivedAt":"2007-05-13T18:57:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> AFAICT the documentation has trailing whitespace also, to indicate that \n> the paragraph does not end here. Correct me if I'm wrong, and these \n> trailing whitespaces are not necessary.\n\nThanks for the tip --- I did not know about deliberate trailing\nwhitespaces there.\n\nIt should be easy to verify by comparing the build products\nbefore and after trailing whitespace removal, so I will try to\nremember doing that.\n"}]}