{"thread":{"id":"8031","subject":"[PATCH] [TRIVIAL] Change default man page path to /usr/share/man","startedAt":"2007-05-08T10:49:31Z","lastAt":"2007-06-20T20:20:15Z","messageCount":12,"participants":["Ismail Dönmez","Uwe Kleine-König","Brian Gernhardt","Linus Torvalds","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"41438","messageId":"200705081349.34964.ismail@pardus.org.tr","threadId":"8031","inReplyTo":null,"subject":"[PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2007-05-08T10:49:31Z","receivedAt":"2007-05-08T10:49:31Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"Hi,\n\nAccording to FHS standard default man page path is $prefix/share/man [0] , \nattached patch fixes this for GIT.\n\n[0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES\n\nSigned-off-by: Ismail Donmez \n\nRegards,\nismail\n\n-- \nLe mieux est l'ennemi du bien.\n\n\n--- Documentation/Makefile\t2007-02-26 21:20:28.000000000 +0200\n+++ Documentation/Makefile\t2007-02-28 01:18:07.672166995 +0200\n@@ -26,7 +26,7 @@\n \n prefix?=$(HOME)\n bindir?=$(prefix)/bin\n-mandir?=$(prefix)/man\n+mandir?=$(prefix)/share/man\n man1dir=$(mandir)/man1\n man7dir=$(mandir)/man7\n # DESTDIR=\n"},{"id":"41460","messageId":"20070508150220.GA18860@informatik.uni-freiburg.de","threadId":"8031","inReplyTo":"200705081349.34964.ismail@pardus.org.tr","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2007-05-08T15:02:20Z","receivedAt":"2007-05-08T15:02:20Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Hallo,\n\nIsmail Dönmez wrote:\n> According to FHS standard default man page path is $prefix/share/man [0] , \n> attached patch fixes this for GIT.\nAccording to some GNU standard it's $prefix/man.\n\nE.g. autoconf managed projects use $prefix/man if you don't give\n--mandir=... to configure.\n\nPersonally I prefer FHS, so I have \n\n\tmandir=$(prefix)/share/man\n\nin my config.mak.\n\nBest regards\nUwe\n\n-- \nUwe Kleine-König\n\nhttp://www.google.com/search?q=72+PS+point+in+inch\n"},{"id":"41464","messageId":"200705081823.37602.ismail@pardus.org.tr","threadId":"8031","inReplyTo":"20070508150220.GA18860@informatik.uni-freiburg.de","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2007-05-08T15:23:33Z","receivedAt":"2007-05-08T15:23:33Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"Hi,\nOn Tuesday 08 May 2007 18:02:20 Uwe Kleine-König wrote:\n> Ismail Dönmez wrote:\n> > According to FHS standard default man page path is $prefix/share/man [0]\n> > , attached patch fixes this for GIT.\n>\n> According to some GNU standard it's $prefix/man.\n>\n> E.g. autoconf managed projects use $prefix/man if you don't give\n> --mandir=... to configure.\n\nJust noticed one can do make mandir=/usr/share/man\n\n> Personally I prefer FHS, so I have\n>\n> \tmandir=$(prefix)/share/man\n>\n> in my config.mak.\n\nSame here, IMHO FHS makes more sense and AFAIK most distros \nuses /usr/share/man.\n\nRegards,\nismail\n\n-- \nLe mieux est l'ennemi du bien.\n"},{"id":"41479","messageId":"3AF7D319-64EC-49DD-BDBB-D438EBA0CD6A@silverinsanity.com","threadId":"8031","inReplyTo":"20070508150220.GA18860@informatik.uni-freiburg.de","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-05-08T17:44:46Z","receivedAt":"2007-05-08T17:44:46Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn May 8, 2007, at 11:02 AM, Uwe Kleine-König wrote:\n\n> Personally I prefer FHS, so I have\n>\n> \tmandir=$(prefix)/share/man\n>\n> in my config.mak.\n\nThe Perl man files Git(3pm) and private-Error(3pm) seem to ignore \nthat setting though. :-(\n\nI just have a \"mybuild\" target in config.mak that calls make all, \ndoc, test, install, and install-doc before cleaning up files from the \nwrong places (man instead of share/man, Perl's System dir on OS X) \nand running \"stow -R\" to catch new files.\n\n~~ Brian"},{"id":"41843","messageId":"200705112025.58095.ismail@pardus.org.tr","threadId":"8031","inReplyTo":"200705081349.34964.ismail@pardus.org.tr","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2007-05-11T17:25:57Z","receivedAt":"2007-05-11T17:25:57Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"On Tuesday 08 May 2007 13:49:31 you wrote:\n> Hi,\n>\n> According to FHS standard default man page path is $prefix/share/man [0] ,\n> attached patch fixes this for GIT.\n>\n> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES\n>\n> Signed-off-by: Ismail Donmez \n\nACK? NAK? Do we care about this? :)\n\nPatch attached again for convenience.\n\nRegards,\nismail\n\n-- \nPerfect is the enemy of good\n\n\n--- Documentation/Makefile\t2007-02-26 21:20:28.000000000 +0200\n+++ Documentation/Makefile\t2007-02-28 01:18:07.672166995 +0200\n@@ -26,7 +26,7 @@\n \n prefix?=$(HOME)\n bindir?=$(prefix)/bin\n-mandir?=$(prefix)/man\n+mandir?=$(prefix)/share/man\n man1dir=$(mandir)/man1\n man7dir=$(mandir)/man7\n # DESTDIR=\n"},{"id":"41847","messageId":"alpine.LFD.0.98.0705111041140.3986@woody.linux-foundation.org","threadId":"8031","inReplyTo":"200705112025.58095.ismail@pardus.org.tr","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2007-05-11T17:42:53Z","receivedAt":"2007-05-11T17:42:53Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 11 May 2007, Ismail Dönmez wrote:\n> \n> ACK? NAK? Do we care about this? :)\n\nI'll Ack it, for what it's worth.\n\nAs it is, I actually end up doing\n\n\tmake prefix=/usr/local/share install-doc\n\n(or something like that) to get things in the right place.\n\nI think the old \"$(prefix)/man\" is just because I still mentally live in \nthe early 90's most of the time.\n\n\t\tLinus"},{"id":"41848","messageId":"7v646zb1p4.fsf@assigned-by-dhcp.cox.net","threadId":"8031","inReplyTo":"200705112025.58095.ismail@pardus.org.tr","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-11T19:27:35Z","receivedAt":"2007-05-11T19:27:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ismail Dönmez writes:\n\n> On Tuesday 08 May 2007 13:49:31 you wrote:\n>> Hi,\n>>\n>> According to FHS standard default man page path is $prefix/share/man [0] ,\n>> attached patch fixes this for GIT.\n>>\n>> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES\n>>\n>> Signed-off-by: Ismail Donmez \n>\n> ACK? NAK? Do we care about this? :)\n\nI would not say the patch is wrong per-se, but:\n\n - People who do not override prefix to install in $HOME would\n suddenly get their mandir under $HOME/share/man; the fact\n nobody complained so far suggests me that these people have\n $MANPATH pointing at $HOME/man, which means your patch breaks\n things for them, unless they have been overriding mandir in\n which case your patch does not matter to them;\n\n - Distros who package git and want to conform to FHS would have\n been overriding not just prefix but mandir anyway, so your patch\n is not an improvement to them;\n\n - People who override prefix to install locally in /usr or\n /usr/local does \"make prefix=\" thing anyway, and the fact\n nobody complained so far suggests me that they have already\n known they need to override mandir as well if they do not\n like /usr/local/man, so your patch is not an improvement to\n them.\n\nThat makes one half negative plus two and half neutral.\n"},{"id":"41849","messageId":"200705112242.44618.ismail@pardus.org.tr","threadId":"8031","inReplyTo":"7v646zb1p4.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2007-05-11T19:42:44Z","receivedAt":"2007-05-11T19:42:44Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"On Friday 11 May 2007 22:27:35 you wrote:\n> Ismail Dönmez writes:\n> > On Tuesday 08 May 2007 13:49:31 you wrote:\n> >> Hi,\n> >>\n> >> According to FHS standard default man page path is $prefix/share/man [0]\n> >> , attached patch fixes this for GIT.\n> >>\n> >> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES\n> >>\n> >> Signed-off-by: Ismail Donmez \n> >\n> > ACK? NAK? Do we care about this? :)\n>\n> I would not say the patch is wrong per-se, but:\n>\n> - People who do not override prefix to install in $HOME would\n> suddenly get their mandir under $HOME/share/man; the fact\n> nobody complained so far suggests me that these people have\n> $MANPATH pointing at $HOME/man, which means your patch breaks\n> things for them, unless they have been overriding mandir in\n> which case your patch does not matter to them;\n\nOr nobody is reading man pages? *g*\n\n> - Distros who package git and want to conform to FHS would have\n> been overriding not just prefix but mandir anyway, so your patch\n> is not an improvement to them;\n\nTrue that.\n\n> - People who override prefix to install locally in /usr or\n> /usr/local does \"make prefix=\" thing anyway, and the fact\n> nobody complained so far suggests me that they have already\n> known they need to override mandir as well if they do not\n> like /usr/local/man, so your patch is not an improvement to\n> them.\n\nMost(All?) distros /usr/share/man in MANPATH so I believe this patch shouldn't \nbreak anything but well you have the final say. I am ok with doing \nmake mandir=/usr/share/man install-doc .\n\nRegards,\nismail\n\n-- \nPerfect is the enemy of good\n"},{"id":"41850","messageId":"7vwszf9md5.fsf@assigned-by-dhcp.cox.net","threadId":"8031","inReplyTo":"200705112242.44618.ismail@pardus.org.tr","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-11T19:44:06Z","receivedAt":"2007-05-11T19:44:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ismail Dönmez writes:\n\n> Most(All?) distros /usr/share/man in MANPATH so I believe this\n> patch shouldn't break anything but well you have the final\n> say. I am ok with doing make mandir=/usr/share/man install-doc\n\nMy preference is to do this early after 1.5.2. I do not want to\ntouch builds with trivial changes before the final.\n"},{"id":"41851","messageId":"200705112250.07340.ismail@pardus.org.tr","threadId":"8031","inReplyTo":"7vwszf9md5.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2007-05-11T19:50:03Z","receivedAt":"2007-05-11T19:50:03Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"On Friday 11 May 2007 22:44:06 Junio C Hamano wrote:\n> Ismail Dönmez writes:\n> > Most(All?) distros /usr/share/man in MANPATH so I believe this\n> > patch shouldn't break anything but well you have the final\n> > say. I am ok with doing make mandir=/usr/share/man install-doc\n>\n> My preference is to do this early after 1.5.2. I do not want to\n> touch builds with trivial changes before the final.\n\nOk with me, thank you.\n\nRegards,\nismail\n\n-- \nPerfect is the enemy of good\n"},{"id":"45434","messageId":"200706202242.13100.ismail@pardus.org.tr","threadId":"8031","inReplyTo":"7vwszf9md5.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Ismail Dönmez","fromEmail":"ismail@pardus.org.tr","sentAt":"2007-06-20T19:42:08Z","receivedAt":"2007-06-20T19:42:08Z","isPatch":true,"sender":{"key":"ismail@pardus.org.tr","avatar":null},"body":"On Friday 11 May 2007 22:44:06 Junio C Hamano wrote:\n> Ismail Dönmez writes:\n> > Most(All?) distros /usr/share/man in MANPATH so I believe this\n> > patch shouldn't break anything but well you have the final\n> > say. I am ok with doing make mandir=/usr/share/man install-doc\n>\n> My preference is to do this early after 1.5.2. I do not want to\n> touch builds with trivial changes before the final.\n\nStill not applied to 1.5.2.2. Patch attached for convenience.\n\nRegards,\nismail\n\n-- \nPerfect is the enemy of good\n\n\n--- Documentation/Makefile\t2007-02-26 21:20:28.000000000 +0200\n+++ Documentation/Makefile\t2007-02-28 01:18:07.672166995 +0200\n@@ -26,7 +26,7 @@\n \n prefix?=$(HOME)\n bindir?=$(prefix)/bin\n-mandir?=$(prefix)/man\n+mandir?=$(prefix)/share/man\n man1dir=$(mandir)/man1\n man7dir=$(mandir)/man7\n # DESTDIR=\n"},{"id":"45439","messageId":"7vfy4mtm2o.fsf@assigned-by-dhcp.pobox.com","threadId":"8031","inReplyTo":"200706202242.13100.ismail@pardus.org.tr","subject":"Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-06-20T20:20:15Z","receivedAt":"2007-06-20T20:20:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ismail Dönmez writes:\n\n> On Friday 11 May 2007 22:44:06 Junio C Hamano wrote:\n>> Ismail Dönmez writes:\n>> > Most(All?) distros /usr/share/man in MANPATH so I believe this\n>> > patch shouldn't break anything but well you have the final\n>> > say. I am ok with doing make mandir=/usr/share/man install-doc\n>>\n>> My preference is to do this early after 1.5.2. I do not want to\n>> touch builds with trivial changes before the final.\n>\n> Still not applied to 1.5.2.2. Patch attached for convenience.\n\nThanks.\n\nI do not think this patch should happen to 1.5.2.X for any value\nof X; but I am willing to apply it to 'master' (hence 1.5.3 and\nlater).\n"}]}