{"thread":{"id":"8020","subject":"gitweb css - pixels?!","startedAt":"2007-05-07T23:13:42Z","lastAt":"2007-05-17T08:31:27Z","messageCount":16,"participants":["Chris Riddoch","Allan Wind","Jan Hudec","Petr Baudis","Junio C Hamano","Jakub Narebski","David Kågedal"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"41373","messageId":"6efbd9b70705071613p23017509qaf9af12c1d14f9cb@mail.gmail.com","threadId":"8020","inReplyTo":null,"subject":"gitweb css - pixels?!","fromName":"Chris Riddoch","fromEmail":"riddochc@gmail.com","sentAt":"2007-05-07T23:13:42Z","receivedAt":"2007-05-07T23:13:42Z","isPatch":false,"sender":{"key":"riddochc@gmail.com","avatar":null},"body":"Hi, folks.\n\nI've been gradually converting my ~/src directory full of tarballs\nI've found interesting enough to download to a ~/repos/ directory\ncontaining bare git repositories of the projects.  I was thinking it\nmight be worth my while to set up gitweb so I can peruse my collection\nof projects.\n\nI noticed myself squinting, on my 1400x1050 laptop screen, at the 10\nand 12-*pixel* font settings gitweb's CSS specifies before thinking to\nmyself that I should bring this to the list's attention.\n\nI'm no CSS guru, or I'd just provide a patch.  It seems that *all* the\nmeasurements specified in the CSS file are in pixels, not ems or\npercentages.  There's got to be a better way.  I can't be the only\nperson who would rather use my nice screen to render attractive,\nreadable fonts rather than to render the smallest possible fonts?\n\n-- \nepistemological humility\n  Chris Riddoch\n"},{"id":"41383","messageId":"20070508012351.GB12978@lifeintegrity.com","threadId":"8020","inReplyTo":"6efbd9b70705071613p23017509qaf9af12c1d14f9cb@mail.gmail.com","subject":"Re: gitweb css - pixels?!","fromName":"Allan Wind","fromEmail":"allan_wind@lifeintegrity.com","sentAt":"2007-05-08T01:23:51Z","receivedAt":"2007-05-08T01:23:51Z","isPatch":false,"sender":{"key":"allan_wind@lifeintegrity.com","avatar":null},"body":"On 2007-05-07T17:13:42-0600, Chris Riddoch wrote:\n> I noticed myself squinting, on my 1400x1050 laptop screen, at the 10\n> and 12-*pixel* font settings gitweb's CSS specifies before thinking to\n> myself that I should bring this to the list's attention.\n\nctrl-+ (ctrl plus possible a couple of times) fixes that if you are\nusing a browser from the Mozilla Foundation.  It was perfectly readable\nfor me, but I fortunate enough to have a large LCD.\n\n\n/Allan\n"},{"id":"41411","messageId":"6efbd9b70705072143q46380a34v4cb55e803d164680@mail.gmail.com","threadId":"8020","inReplyTo":"20070508012351.GB12978@lifeintegrity.com","subject":"Re: gitweb css - pixels?!","fromName":"Chris Riddoch","fromEmail":"riddochc@gmail.com","sentAt":"2007-05-08T04:43:58Z","receivedAt":"2007-05-08T04:43:58Z","isPatch":false,"sender":{"key":"riddochc@gmail.com","avatar":null},"body":"On 5/7/07, Allan Wind <allan_wind@lifeintegrity.com> wrote:\n> On 2007-05-07T17:13:42-0600, Chris Riddoch wrote:\n> > I noticed myself squinting, on my 1400x1050 laptop screen, at the 10\n> > and 12-*pixel* font settings gitweb's CSS specifies before thinking to\n> > myself that I should bring this to the list's attention.\n>\n> ctrl-+ (ctrl plus possible a couple of times) fixes that if you are\n> using a browser from the Mozilla Foundation.  It was perfectly readable\n> for me, but I fortunate enough to have a large LCD.\n\nYes, I'm aware of that feature.  Very handy.  And entirely too necessary.\n\nSeriously, this isn't something to push on to users.  Entirely too\nmany websites don't follow sensible accessibility standards; shouldn't\ngitweb be fixed?\n\n-- \nepistemological humility\n  Chris Riddoch\n"},{"id":"41427","messageId":"20070508083644.GA9007@efreet.light.src","threadId":"8020","inReplyTo":"6efbd9b70705071613p23017509qaf9af12c1d14f9cb@mail.gmail.com","subject":"Re: gitweb css - pixels?!","fromName":"Jan Hudec","fromEmail":"bulb@ucw.cz","sentAt":"2007-05-08T08:36:44Z","receivedAt":"2007-05-08T08:36:44Z","isPatch":false,"sender":{"key":"bulb@ucw.cz","avatar":null},"body":"On Mon, May 07, 2007 at 17:13:42 -0600, Chris Riddoch wrote:\n> Hi, folks.\n> \n> I've been gradually converting my ~/src directory full of tarballs\n> I've found interesting enough to download to a ~/repos/ directory\n> containing bare git repositories of the projects.  I was thinking it\n> might be worth my while to set up gitweb so I can peruse my collection\n> of projects.\n> \n> I noticed myself squinting, on my 1400x1050 laptop screen, at the 10\n> and 12-*pixel* font settings gitweb's CSS specifies before thinking to\n> myself that I should bring this to the list's attention.\n> \n> I'm no CSS guru, or I'd just provide a patch.  It seems that *all* the\n> measurements specified in the CSS file are in pixels, not ems or\n> percentages.  There's got to be a better way.  I can't be the only\n> person who would rather use my nice screen to render attractive,\n> readable fonts rather than to render the smallest possible fonts?\n\nWell, there should be three ways to set font sizes:\n\n 1. Use the symbolic small, normal, large..., which are derived from user\n    settings (normal is user setting, large is one step larger etc.). IMHO\n    this would be the best variant.\n 2. Use *points* (pt) instead of *pixels* (px). Unfortunately most browsers\n    don't know what their DPI is and will treat 1pt as 1px, even though they\n    have more than 72dpi. I believe this applies to all Micro$oft browsers.\n 3. Use designation relative to previous font. One step up is 1.2em, one step\n    down is 0.8333333em. I am not sure this actually works in Micro$oft\n    browsers. Also rounding errors may quickly get you to completely\n    different font size that you wanted.\n\n-- \n\t\t\t\t\t\t Jan 'Bulb' Hudec <bulb@ucw.cz>\n"},{"id":"41526","messageId":"20070509014150.7477.48489.stgit@rover","threadId":"8020","inReplyTo":"6efbd9b70705071613p23017509qaf9af12c1d14f9cb@mail.gmail.com","subject":"[PATCH] gitweb: Do not use absolute font sizes","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2007-05-09T01:41:50Z","receivedAt":"2007-05-09T01:41:50Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Avoid specifying font sizes in pixels, since that is just pure evil.\nPointed out by Chris Riddoch.\n\nNote that this is pretty much just a proposal; I didn't test if everything\nfits perfectly right, but things seem to be pretty much okay. repo.or.cz\nuses it now as a test drive - if you find any visual quirks, please point\nthem out, with a patch if possible since I'm total CSS noob and debugging\nCSS is an extremely painful experience for me.\n\nNote that this patch actually does change visual look of gitweb in Firefox\nwith my resolution and default settings - everything is bigger and I can't\nexplain the joy of actually seeing gitweb text that is in _readable_ size;\nalso, my horizontal screen real estate feels better used now. But judging\nfrom the look of most modern webpages on the 'net, most people prefer\nreading the web with strained eyes and/or a magnifying glass (I wonder what\nspecies of scientists should look into this mystifying phenomenon) - so,\nplease tell us what you think.\n\nMaybe we might want to get rid of absolute sizes other than font sizes in\nthe CSS file too in the long term.\n\nSigned-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n gitweb/gitweb.css |   19 +++++++++----------\n 1 files changed, 9 insertions(+), 10 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 6c662a1..df12d78 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -1,6 +1,5 @@\n body {\n \tfont-family: sans-serif;\n-\tfont-size: 12px;\n \tborder: solid #d9d8d1;\n \tborder-width: 1px;\n \tmargin: 10px;\n@@ -31,7 +30,7 @@ img.logo {\n div.page_header {\n \theight: 25px;\n \tpadding: 8px;\n-\tfont-size: 18px;\n+\tfont-size: 150%;\n \tfont-weight: bold;\n \tbackground-color: #d9d8d1;\n }\n@@ -113,7 +112,7 @@ span.signoff {\n \n div.log_link {\n \tpadding: 0px 8px;\n-\tfont-size: 10px;\n+\tfont-size: 70%;\n \tfont-family: sans-serif;\n \tfont-style: normal;\n \tposition: relative;\n@@ -204,13 +203,13 @@ table.blame {\n \n table.blame td {\n \tpadding: 0px 5px;\n-\tfont-size: 12px;\n+\tfont-size: 100%;\n \tvertical-align: top;\n }\n \n th {\n \tpadding: 2px 5px;\n-\tfont-size: 12px;\n+\tfont-size: 100%;\n \ttext-align: left;\n }\n \n@@ -232,14 +231,14 @@ tr.dark:hover {\n \n td {\n \tpadding: 2px 5px;\n-\tfont-size: 12px;\n+\tfont-size: 100%;\n \tvertical-align: top;\n }\n \n td.link, td.selflink {\n \tpadding: 2px 5px;\n \tfont-family: sans-serif;\n-\tfont-size: 10px;\n+\tfont-size: 70%;\n }\n \n td.selflink {\n@@ -416,7 +415,7 @@ div.index_include {\n }\n \n div.search {\n-\tfont-size: 12px;\n+\tfont-size: 100%;\n \tfont-weight: normal;\n \tmargin: 4px 8px;\n \tposition: absolute;\n@@ -444,7 +443,7 @@ a.rss_logo {\n \tbackground-color: #ff6600;\n \tfont-weight: bold;\n \tfont-family: sans-serif;\n-\tfont-size: 10px;\n+\tfont-size: 70%;\n \ttext-align: center;\n \ttext-decoration: none;\n }\n@@ -455,7 +454,7 @@ a.rss_logo:hover {\n \n span.refs span {\n \tpadding: 0px 4px;\n-\tfont-size: 10px;\n+\tfont-size: 70%;\n \tfont-weight: normal;\n \tborder: 1px solid;\n \tbackground-color: #ffaaff;\n"},{"id":"41539","messageId":"7vvef2y21o.fsf@assigned-by-dhcp.cox.net","threadId":"8020","inReplyTo":"20070509014150.7477.48489.stgit@rover","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-09T05:54:43Z","receivedAt":"2007-05-09T05:54:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@ucw.cz> writes:\n\n> Avoid specifying font sizes in pixels, since that is just pure evil.\n> Pointed out by Chris Riddoch.\n>\n> Note that this is pretty much just a proposal; I didn't test if everything\n> fits perfectly right, but things seem to be pretty much okay. repo.or.cz\n> uses it now as a test drive - if you find any visual quirks, please point\n> them out, with a patch if possible since I'm total CSS noob and debugging\n> CSS is an extremely painful experience for me.\n\nThis looks like going in the right direction, but...\n\n>  gitweb/gitweb.css |   19 +++++++++----------\n>  1 files changed, 9 insertions(+), 10 deletions(-)\n>\n> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\n> index 6c662a1..df12d78 100644\n> --- a/gitweb/gitweb.css\n> +++ b/gitweb/gitweb.css\n> @@ -1,6 +1,5 @@\n>  body {\n>  \tfont-family: sans-serif;\n> -\tfont-size: 12px;\n>  \tborder: solid #d9d8d1;\n>  \tborder-width: 1px;\n>  \tmargin: 10px;\n> @@ -31,7 +30,7 @@ img.logo {\n>  div.page_header {\n>  \theight: 25px;\n>  \tpadding: 8px;\n> -\tfont-size: 18px;\n> +\tfont-size: 150%;\n>  \tfont-weight: bold;\n>  \tbackground-color: #d9d8d1;\n>  }\n> @@ -113,7 +112,7 @@ span.signoff {\n>  \n>  div.log_link {\n>  \tpadding: 0px 8px;\n> -\tfont-size: 10px;\n> +\tfont-size: 70%;\n>  \tfont-family: sans-serif;\n>  \tfont-style: normal;\n>  \tposition: relative;\n\n\t[12, 18, 10] / 12 * 100 = [100, 150, 83.33]\n\nwhy not use 83% for what were originally 10px?\n"},{"id":"41545","messageId":"6efbd9b70705082348t720c2396l58dad56fd18bd84e@mail.gmail.com","threadId":"8020","inReplyTo":"20070509014150.7477.48489.stgit@rover","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"Chris Riddoch","fromEmail":"riddochc@gmail.com","sentAt":"2007-05-09T06:48:02Z","receivedAt":"2007-05-09T06:48:02Z","isPatch":true,"sender":{"key":"riddochc@gmail.com","avatar":null},"body":"On 5/8/07, Petr Baudis <pasky@ucw.cz> wrote:\n> Avoid specifying font sizes in pixels, since that is just pure evil.\n> Pointed out by Chris Riddoch.\n\nThanks!  It's definitely a step in the right direction.\n\nIn my browser, the decent-sized fonts make it apparent that we're\ntrying to fit a lot in a limited horizontal space.  In particular, the\nlinks (commit | committdiff | tree | snapshot) wrap in the space\nprovided, for me.  I dropped my default font size a little, and it's\njust fine... but it does make me think, perhaps that's something where\neither icons or abbreviations (with an appropriate key) might improve\nthe appearance of the page.  Perhaps something like: C | D | T | S.\nIt might even let us put more functionality in and improve our use of\nwhitespace even more.\n\nI like it.\n\n-- \nepistemological humility\n  Chris Riddoch\n"},{"id":"41590","messageId":"20070509134722.GU4489@pasky.or.cz","threadId":"8020","inReplyTo":"7vvef2y21o.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-05-09T13:47:22Z","receivedAt":"2007-05-09T13:47:22Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Wed, May 09, 2007 at 07:54:43AM CEST, Junio C Hamano wrote:\n> \t[12, 18, 10] / 12 * 100 = [100, 150, 83.33]\n> \n> why not use 83% for what were originally 10px?\n\nIt seemed to me that the small parts were way too large then (this is\nalso why I decided not to use 'large', 'medium' and 'small' - large was\ntoo small and small was too large, I felt), but I don't particularily\ncare about this detail.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nEver try. Ever fail. No matter. // Try again. Fail again. Fail better.\n\t\t-- Samuel Beckett\n"},{"id":"42145","messageId":"f2a3si$ein$1@sea.gmane.org","threadId":"8020","inReplyTo":"20070509014150.7477.48489.stgit@rover","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-05-14T16:53:01Z","receivedAt":"2007-05-14T16:53:01Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Petr Baudis wrote:\n\n> Note that this patch actually does change visual look of gitweb in Firefox\n> with my resolution and default settings - everything is bigger and I can't\n> explain the joy of actually seeing gitweb text that is in _readable_ size;\n> also, my horizontal screen real estate feels better used now.\n\nNot everyone has those huge monitors with extreme resultion. For me new\ngitweb look uses much to big font, so not very much fits in screen.\n\nI'd remove \n\n> --- a/gitweb/gitweb.css\n> +++ b/gitweb/gitweb.css\n> @@ -1,6 +1,5 @@\n>  body {\n>         font-family: sans-serif;\n> -       font-size: 12px;\n>         border: solid #d9d8d1;\n>         border-width: 1px;\n>         margin: 10px;\n\nchunk\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"42194","messageId":"87odkmgaj5.fsf@morpheus.local","threadId":"8020","inReplyTo":"f2a3si$ein$1@sea.gmane.org","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2007-05-15T01:06:54Z","receivedAt":"2007-05-15T01:06:54Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> Petr Baudis wrote:\n>\n>> Note that this patch actually does change visual look of gitweb in Firefox\n>> with my resolution and default settings - everything is bigger and I can't\n>> explain the joy of actually seeing gitweb text that is in _readable_ size;\n>> also, my horizontal screen real estate feels better used now.\n>\n> Not everyone has those huge monitors with extreme resultion. For me new\n> gitweb look uses much to big font, so not very much fits in screen.\n>\n> I'd remove \n>\n>> --- a/gitweb/gitweb.css\n>> +++ b/gitweb/gitweb.css\n>> @@ -1,6 +1,5 @@\n>>  body {\n>>         font-family: sans-serif;\n>> -       font-size: 12px;\n>>         border: solid #d9d8d1;\n>>         border-width: 1px;\n>>         margin: 10px;\n>\n> chunk\n\nBut then we'd be back to the brain-damaged explicit-pixel sizes.\n\ngitweb is simply using the font size you have configured your browser\nto use, and if you think that it too large, you are free to\nreconfigure it.\n\nUnfortunately, the problem is that too many web sites explicitly\nselect extra small font sizes, which means that you have to select a\n\"standard\" font size in your browser that is a bit larger than you'd\nactually like.\n\n-- \nDavid Kågedal\n"},{"id":"42224","messageId":"20070515150912.GA3653@efreet.light.src","threadId":"8020","inReplyTo":"87odkmgaj5.fsf@morpheus.local","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"Jan Hudec","fromEmail":"bulb@ucw.cz","sentAt":"2007-05-15T15:09:12Z","receivedAt":"2007-05-15T15:09:12Z","isPatch":true,"sender":{"key":"bulb@ucw.cz","avatar":null},"body":"On Mon, May 14, 2007 at 18:06:54 -0700, David Kågedal wrote:\n> Unfortunately, the problem is that too many web sites explicitly\n> select extra small font sizes, which means that you have to select a\n> \"standard\" font size in your browser that is a bit larger than you'd\n> actually like.\n\nIMHO gitweb should explicitely request being somewhat smaller than normal,\nbecause it has good use for long lines. Normally I want to set font so large,\nthat more than ~120 characters won't fit on the screen, since otherwise pages\nthat don't use margins are simply unreadable. However gitweb presents a table\nwith several columns, so having wider line is OK for it. Therefore explicit\n'font-size: small' would make sense.\n\n-- \n\t\t\t\t\t\t Jan 'Bulb' Hudec <bulb@ucw.cz>\n"},{"id":"42269","messageId":"200705160159.55590.jnareb@gmail.com","threadId":"8020","inReplyTo":"20070515150912.GA3653@efreet.light.src","subject":"Re: [PATCH] gitweb: Do not use absolute font sizes","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-05-15T23:59:55Z","receivedAt":"2007-05-15T23:59:55Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 15 May 2007, Jan Hudec wrote:\n> On Mon, May 14, 2007 at 18:06:54 -0700, David Kågedal wrote:\n\n>> Unfortunately, the problem is that too many web sites explicitly\n>> select extra small font sizes, which means that you have to select a\n>> \"standard\" font size in your browser that is a bit larger than you'd\n>> actually like.\n> \n> IMHO gitweb should explicitely request being somewhat smaller than normal,\n> because it has good use for long lines. Normally I want to set font so large,\n> that more than ~120 characters won't fit on the screen, since otherwise pages\n> that don't use margins are simply unreadable. However gitweb presents a table\n> with several columns, so having wider line is OK for it. Therefore explicit\n> 'font-size: small' would make sense.\n\nAnd thanks to commit 63fcbe00 by Pasky\n  \"gitweb: Do not use absolute font sizes\"\nit has to be added in only one place:\n\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex b57c8be..02623cb 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -1,5 +1,6 @@\n body {\n \tfont-family: sans-serif;\n+\tfont-size: small;\n \tborder: solid #d9d8d1;\n \tborder-width: 1px;\n \tmargin: 10px;\n"},{"id":"42334","messageId":"200705161251.38729.jnareb@gmail.com","threadId":"8020","inReplyTo":"20070515150912.GA3653@efreet.light.src","subject":"[PATCH] gitweb: Change base font size to \"small\"","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-05-16T10:51:38Z","receivedAt":"2007-05-16T10:51:38Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Commit 63fcbe00a66d7cb7d8bce9a36120a19a809a33b8 by Peter \"Pasky\" Baudis\n  \"gitweb: Do not use absolute font sizes\"\nmade gitweb use default font size, the font size you have configured\nyour browser to use, as a basis; other font sizes are given as\npercentage.\n\nDavid Kågedal noticed problem with this approach: too many web sites\nexplicitly select extra small font sizes, which means that you have to\nselect a \"standard\" font size in your browser that is a bit larger\nthan one would actually like.\n\nAdditionally, as Jan Hudec noticed, gitweb should explicitely request\nbeing somewhat smaller than normal, because it has good use for long\nlines.  Normally one would usually want to set font so large, that\nmore than ~120 characters won't fit on the screen, since otherwise\npages that don't use margins are simply unreadable.  However gitweb\npresents a table with several columns, so having wider line is OK for\nit.\n\nJan Hudec proposed to use 'font-size: small' to take above issues into\naccount.  This avoid using \"brain-damaged\" explicit-pixel sizes, while\ntaking into account nature of gitweb output.\n\nThanks to mentioned commit by Pasky we need to add 'font-size: small'\nin only one place, for BODY element.\n\nSee the original messages:\n  Message-ID: <87odkmgaj5.fsf@morpheus.local>\n  Message-ID: <20070515150912.GA3653@efreet.light.src>\n\n\nProposed-by: Jan Hudec <bulb@ucw.cz>\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nThis is commit wich has commit message larger than patch itself, but\nI think the explanation is as important as patch itself, perhaps even\nmore important.\n\n gitweb/gitweb.css |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex b57c8be..02623cb 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -1,5 +1,6 @@\n body {\n \tfont-family: sans-serif;\n+\tfont-size: small;\n \tborder: solid #d9d8d1;\n \tborder-width: 1px;\n \tmargin: 10px;\n-- \n1.5.1.4\n"},{"id":"42358","messageId":"20070517021723.GK4489@pasky.or.cz","threadId":"8020","inReplyTo":"200705161251.38729.jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Change base font size to \"small\"","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-05-17T02:17:23Z","receivedAt":"2007-05-17T02:17:23Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Wed, May 16, 2007 at 12:51:38PM CEST, Jakub Narebski wrote:\n> Proposed-by: Jan Hudec <bulb@ucw.cz>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n\nAcked-by: Petr Baudis <pasky@suse.cz>\n\njust for the record, since it seems to be already applied anyway. By the\nway, I think this commit message is more optimal than what ended up for\nsome reason (Jakub wasn't fast enough? ;-) as\nb211c320eb5d753a7a44a03eccb9a15cfbcc563b - especially the subject of\nthat commit is really weird.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nEver try. Ever fail. No matter. // Try again. Fail again. Fail better.\n\t\t-- Samuel Beckett\n"},{"id":"42369","messageId":"7v4pmcccut.fsf@assigned-by-dhcp.cox.net","threadId":"8020","inReplyTo":"20070517021723.GK4489@pasky.or.cz","subject":"Re: [PATCH] gitweb: Change base font size to \"small\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-17T04:07:06Z","receivedAt":"2007-05-17T04:07:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> On Wed, May 16, 2007 at 12:51:38PM CEST, Jakub Narebski wrote:\n>> Proposed-by: Jan Hudec <bulb@ucw.cz>\n>> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n>\n> Acked-by: Petr Baudis <pasky@suse.cz>\n>\n> just for the record, since it seems to be already applied anyway. By the\n> way, I think this commit message is more optimal than what ended up for\n> some reason (Jakub wasn't fast enough? ;-)\n\nMost likely timezone difference is the largest factor.\n"},{"id":"42382","messageId":"200705171031.28875.jnareb@gmail.com","threadId":"8020","inReplyTo":"20070517021723.GK4489@pasky.or.cz","subject":"Re: [PATCH] gitweb: Change base font size to \"small\"","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-05-17T08:31:27Z","receivedAt":"2007-05-17T08:31:27Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 17 May 2007, Petr Baudis wrote:\n> On Wed, May 16, 2007 at 12:51:38PM CEST, Jakub Narebski wrote:\n\n>> Proposed-by: Jan Hudec <bulb@ucw.cz>\n>> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> \n> Acked-by: Petr Baudis <pasky@suse.cz>\n> \n> just for the record, since it seems to be already applied anyway. By the\n> way, I think this commit message is more optimal than what ended up for\n> some reason (Jakub wasn't fast enough? ;-) as\n> b211c320eb5d753a7a44a03eccb9a15cfbcc563b - especially the subject of\n> that commit is really weird.\n\nSecond 'gitweb: Do not use absolute font sizes' commit in git.git repo\nis from (authordate) Wed May 16 01:59:55 2007 +0200, while this one:\n'gitweb: Change base font size to \"small\"' commit in my repo is from\nWed May 16 12:16:02 2007 +0200\n\nSo it looks like my patch without commit message in\n  Message-ID: <200705160159.55590.jnareb@gmail.com>\nwas taken, and commit message was added by Junio, and not ready commit\nfrom this subthread (in message you have replied to, and which you Ack)\n  Message-ID: <200705161251.38729.jnareb@gmail.com>\n\nGah, either I shouldn't have send bare patch, or I have should send\nreply that I'm working on commit message for this change.\n\n\nI have tagged my commit message in git/jnareb-git.git repo as \ngitweb/change-base-font-size:\n\n  http://repo.or.cz/w/git/jnareb-git.git?a=tag;h=gitweb/change-base-font-size\n\nto protect it against rebase + prune.\n-- \nJakub Narebski\nPoland\n"}]}