{"thread":{"id":"7941","subject":"[PATCH] cvsserver: Handle re-added files correctly","startedAt":"2007-05-02T00:43:14Z","lastAt":"2007-05-02T00:43:14Z","messageCount":1,"participants":["Frank Lichtenheld"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"40875","messageId":"1178066594239-git-send-email-frank@lichtenheld.de","threadId":"7941","inReplyTo":null,"subject":"[PATCH] cvsserver: Handle re-added files correctly","fromName":"Frank Lichtenheld","fromEmail":"frank@lichtenheld.de","sentAt":"2007-05-02T00:43:14Z","receivedAt":"2007-05-02T00:43:14Z","isPatch":true,"sender":{"key":"frank@lichtenheld.de","avatar":"https://gravatar.com/avatar/b9f1d4b120e138f157c9e480d0818197c474628923786adb98f30017cdb99c3c?d=mp&s=160"},"body":"We can't unconditionally assign revision 1.1 to\nnewly added files. In case the file did exist in the\npast and was deleted we need to honor the old\nrevision number.\n\nSigned-off-by: Frank Lichtenheld <frank@lichtenheld.de>\n---\n git-cvsserver.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n Found due to working on the test cases.\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 087e3ab..3e7bf5b 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -2519,7 +2519,7 @@ sub update\n                     #$log->debug(\"ADDED    $name\");\n                     $head->{$name} = {\n                         name => $name,\n-                        revision => 1,\n+                        revision => $head->{$name}{revision} ? $head->{$name}{revision}+1 : 1,\n                         filehash => $hash,\n                         commithash => $commit->{hash},\n                         modified => $commit->{date},\n-- \n1.5.1.2\n"}]}