{"thread":{"id":"7913","subject":"[PATCH 1/8] git-repack --max-pack-size: add new file statics","startedAt":"2007-04-30T23:17:32Z","lastAt":"2007-05-01T04:43:53Z","messageCount":3,"participants":["Dana How","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":8},"messages":[{"id":"40767","messageId":"4636790C.5060908@gmail.com","threadId":"7913","inReplyTo":null,"subject":"[PATCH 1/8] git-repack --max-pack-size: add new file statics","fromName":"Dana How","fromEmail":"danahow@gmail.com","sentAt":"2007-04-30T23:17:32Z","receivedAt":"2007-04-30T23:17:32Z","isPatch":true,"sender":{"key":"danahow@gmail.com","avatar":null},"body":"\nThis adds \"pack_size_limit\", which will contain the limit\nspecified by --max-pack-size, \"written_list\", the actual\nlist of objects written to the current pack, and \"nr_written\",\nthe number of objects in written_list.\n\nSigned-off-by: Dana L. How \n---\n builtin-pack-objects.c | 4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-pack-objects.c b/builtin-pack-objects.c\nindex b827627..ac2c15e 100644\n--- a/builtin-pack-objects.c\n+++ b/builtin-pack-objects.c\n@@ -52,7 +52,8 @@ struct object_entry {\n * nice \"minimum seek\" order.\n */\n static struct object_entry *objects;\n-static uint32_t nr_objects, nr_alloc, nr_result;\n+static struct object_entry **written_list;\n+static uint32_t nr_objects, nr_alloc, nr_result, nr_written;\n \n static int non_empty;\n static int no_reuse_delta;\n@@ -64,6 +65,7 @@ static char tmpname[PATH_MAX];\n static unsigned char pack_file_sha1[20];\n static int progress = 1;\n static int window = 10;\n+static uint32_t pack_size_limit;\n static int pack_to_stdout;\n static int num_preferred_base;\n static struct progress progress_state;\n-- \n1.5.2.rc0.766.gba60-dirty\n"},{"id":"40784","messageId":"7vzm4p89op.fsf@assigned-by-dhcp.cox.net","threadId":"7913","inReplyTo":"4636790C.5060908@gmail.com","subject":"Re: [PATCH 1/8] git-repack --max-pack-size: add new file statics","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-01T04:11:34Z","receivedAt":"2007-05-01T04:11:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dana How writes:\n\n> This adds \"pack_size_limit\", which will contain the limit\n> specified by --max-pack-size, \"written_list\", the actual\n> list of objects written to the current pack, and \"nr_written\",\n> the number of objects in written_list.\n>\n> Signed-off-by: Dana L. How \n> ---\n> builtin-pack-objects.c | 4 +++-\n> 1 files changed, 3 insertions(+), 1 deletions(-)\n>\n> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c\n> index b827627..ac2c15e 100644\n> --- a/builtin-pack-objects.c\n> +++ b/builtin-pack-objects.c\n> @@ -52,7 +52,8 @@ struct object_entry {\n> * nice \"minimum seek\" order.\n> */\n> static struct object_entry *objects;\n> -static uint32_t nr_objects, nr_alloc, nr_result;\n> +static struct object_entry **written_list;\n> +static uint32_t nr_objects, nr_alloc, nr_result, nr_written;\n> \n> static int non_empty;\n> static int no_reuse_delta;\n> @@ -64,6 +65,7 @@ static char tmpname[PATH_MAX];\n> static unsigned char pack_file_sha1[20];\n> static int progress = 1;\n> static int window = 10;\n> +static uint32_t pack_size_limit;\n> static int pack_to_stdout;\n> static int num_preferred_base;\n> static struct progress progress_state;\n> -- \n> 1.5.2.rc0.766.gba60-dirty\n\nThis by itself does not seem to do anything (no logic, no\ncommand line option parsing, nothing). Why is this a separate\npatch?\n"},{"id":"40787","messageId":"56b7f5510704302143i79aef70dg95ffa23c3138663a@mail.gmail.com","threadId":"7913","inReplyTo":"7vzm4p89op.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/8] git-repack --max-pack-size: add new file statics","fromName":"Dana How","fromEmail":"danahow@gmail.com","sentAt":"2007-05-01T04:43:53Z","receivedAt":"2007-05-01T04:43:53Z","isPatch":true,"sender":{"key":"danahow@gmail.com","avatar":null},"body":"On 4/30/07, Junio C Hamano wrote:\n> Dana How writes:\n> > This adds \"pack_size_limit\", which will contain the limit\n> > specified by --max-pack-size, \"written_list\", the actual\n> > list of objects written to the current pack, and \"nr_written\",\n> > the number of objects in written_list.\n> > ---\n> > builtin-pack-objects.c | 4 +++-\n> >\n> > diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c\n> > --- a/builtin-pack-objects.c\n> > +++ b/builtin-pack-objects.c\n> > @@ -52,7 +52,8 @@ struct object_entry {\n> > -static uint32_t nr_objects, nr_alloc, nr_result;\n> > +static struct object_entry **written_list;\n> > +static uint32_t nr_objects, nr_alloc, nr_result, nr_written;\n> > @@ -64,6 +65,7 @@ static char tmpname[PATH_MAX];\n> > +static uint32_t pack_size_limit;\n>\n> This by itself does not seem to do anything (no logic, no\n> command line option parsing, nothing). Why is this a separate\n> patch?\n\nRemember this all started with me submitting\none monolithic patch which attracted some complaints.\nAfter that, I broke the changes into patchsets\nwith 3 kinds of patches:\n(a) Changes (addtitions) to data structures and declarations;\n(b) Code restructuring and added forward function declarations\n adding _no_ functionality;\n(c) Added functionality, (almost) one function at a time.\n\nSo 1/8 is the only member of group (a).\nPreviously there were more changes in (a).\n\nI'm working on another change/feature. Based on your email,\nI will merge groups (a) and (b) in future patchsets.\n\nThanks,\n-- \nDana L. How danahow@gmail.com +1 650 804 5991 cell\n"}]}