{"thread":{"id":"7903","subject":"[PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","startedAt":"2007-04-30T11:04:03Z","lastAt":"2007-05-01T04:11:41Z","messageCount":9,"participants":["Jari Aalto","Johannes Schindelin","Julian Phillips","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"40736","messageId":"r6q2xgws.fsf@cante.net","threadId":"7903","inReplyTo":null,"subject":"[PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2007-04-30T11:04:03Z","receivedAt":"2007-04-30T11:04:03Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"\nAdded email address and message 'Send your patch to...'\n\nSigned-off-by: Jari Aalto \n---\n Documentation/SubmittingPatches | 9 ++++++++-\n 1 files changed, 8 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 2386f49..238d410 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -1,5 +1,7 @@\n Checklist (and a short version for the impatient):\n \n+\tCommits:\n+\n \t- make commits of logical units\n \t- check for unnecessary whitespace with \"git diff --check\"\n \t before committing\n@@ -12,8 +14,13 @@ Checklist (and a short version for the impatient):\n \t commit message (or just use the option \"-s\" when\n \t committing) to confirm that you agree to the Developer's\n \t Certificate of Origin\n+\n+\tPatch:\n+\n+\t- send your patch to by using\n+\t git-format-patch(1) with option \"-M\". See also\n+\t git-send-email(1).\n \t- do not PGP sign your patch\n-\t- use \"git format-patch -M\" to create the patch\n \t- do not attach your patch, but read in the mail\n \t body, unless you cannot teach your mailer to\n \t leave the formatting of the patch alone.\n-- \n1.5.1.2.GIT\n"},{"id":"40737","messageId":"Pine.LNX.4.64.0704301333400.29859@racer.site","threadId":"7903","inReplyTo":"r6q2xgws.fsf@cante.net","subject":"Re: [PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-04-30T11:36:19Z","receivedAt":"2007-04-30T11:36:19Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 30 Apr 2007, Jari Aalto wrote:\n\n> +\t- send your patch to by using\n> +\t git-format-patch(1) with option \"-M\". See also\n> +\t git-send-email(1).\n> \t- do not PGP sign your patch\n> -\t- use \"git format-patch -M\" to create the patch\n\nNACK.\n\nI never use send-email myself. There are even technical issues to my \nexcuse: sometimes I cannot send the mails from my machine. So, this should \nnot be a _replacement_ for `git format-patch -M && send mail manually`, \nbut only an _alternative_.\n\nHowever, my impression was that many people had problems when first \nsending patches with send-email. There should be _at least_ a word of \ncaution, that you should test the operation on something different than \nthe Git list first.\n\nCiao,\nDscho\n"},{"id":"40740","messageId":"abwqxe6t.fsf@cante.net","threadId":"7903","inReplyTo":"Pine.LNX.4.64.0704301333400.29859@racer.site","subject":"Re: [PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2007-04-30T12:02:50Z","receivedAt":"2007-04-30T12:02:50Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi,\n>\n> On Mon, 30 Apr 2007, Jari Aalto wrote:\n>\n>> +\t- send your patch to by using\n>> +\t git-format-patch(1) with option \"-M\". See also\n>> +\t git-send-email(1).\n>> \t- do not PGP sign your patch\n>> -\t- use \"git format-patch -M\" to create the patch\n>\n> NACK.\n>\n> I never use send-email myself. There are even technical issues to my \n> excuse: sometimes I cannot send the mails from my machine. So, this should \n> not be a _replacement_ for `git format-patch -M && send mail manually`, \n> but only an _alternative_.\n>\n> However, my impression was that many people had problems when first \n> sending patches with send-email. There should be _at least_ a word of \n> caution, that you should test the operation on something different than \n> the Git list first.\n\nIs this workding okay?\n\n - send your patch to by using\n git-format-patch(1) with option \"-M\". If you use \n git-send-email(1), please test it first by sending \n email to yourself.\n\nJari\n"},{"id":"40741","messageId":"Pine.LNX.4.64.0704301306340.2279@reaper.quantumfyre.co.uk","threadId":"7903","inReplyTo":"abwqxe6t.fsf@cante.net","subject":"Re: [PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Julian Phillips","fromEmail":"julian@quantumfyre.co.uk","sentAt":"2007-04-30T12:09:28Z","receivedAt":"2007-04-30T12:09:28Z","isPatch":true,"sender":{"key":"julian@quantumfyre.co.uk","avatar":"https://avatars.githubusercontent.com/u/948888?v=4"},"body":"On Mon, 30 Apr 2007, Jari Aalto wrote:\n\n> Is this workding okay?\n>\n> - send your patch to by using\n> git-format-patch(1) with option \"-M\". If you use\n> git-send-email(1), please test it first by sending\n> email to yourself.\n\nI don't want to seem picky, but that wording suggests to me that the -M \noption to format-patch magically sends patches to the list. Why not just \nhave:\n\n \t- use \"git format-patch -M\" to create the patch\n \t- send your patch to . If you use\n \t git-send-email(1), please test it first by sending\n \t email to yourself.\n\n-- \nJulian\n\n ---\nMy mother loved children -- she would have given anything if I had been one.\n \t\t-- Groucho Marx\n"},{"id":"40743","messageId":"Pine.LNX.4.64.0704301442240.29859@racer.site","threadId":"7903","inReplyTo":"Pine.LNX.4.64.0704301306340.2279@reaper.quantumfyre.co.uk","subject":"Re: [PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-04-30T12:42:46Z","receivedAt":"2007-04-30T12:42:46Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 30 Apr 2007, Julian Phillips wrote:\n\n> On Mon, 30 Apr 2007, Jari Aalto wrote:\n> \n> > Is this workding okay?\n> > \n> > - send your patch to by using\n> > git-format-patch(1) with option \"-M\". If you use\n> > git-send-email(1), please test it first by sending\n> > email to yourself.\n> \n> I don't want to seem picky, but that wording suggests to me that the -M\n> option to format-patch magically sends patches to the list. Why not just\n> have:\n> \n> \t- use \"git format-patch -M\" to create the patch\n> \t- send your patch to . If you use\n> \t git-send-email(1), please test it first by sending\n> \t email to yourself.\n\nYes, I like that much better!\n\nThank you,\nDscho\n"},{"id":"40748","messageId":"y7k9x306.fsf_-_@cante.net","threadId":"7903","inReplyTo":"Pine.LNX.4.64.0704301306340.2279@reaper.quantumfyre.co.uk","subject":"Re: [PATCH] v2: Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Jari Aalto","fromEmail":"jari.aalto@cante.net","sentAt":"2007-04-30T16:04:25Z","receivedAt":"2007-04-30T16:04:25Z","isPatch":true,"sender":{"key":"jari.aalto@cante.net","avatar":"https://avatars.githubusercontent.com/u/34601?v=4"},"body":"\n>From e65853b7bede747912a51fd77d5cf62fb255b116 Mon Sep 17 00:00:00 2001\nFrom: Jari Aalto \nDate: Mon, 30 Apr 2007 18:57:25 +0300\nSubject: [PATCH] Checklist clarifications: added Commits, Patch: headings\n\nSigned-off-by: Jari Aalto \n---\n This is version 2 of the orignal patch. Corrected according\n to Julian Phillips's comments.\n\n Documentation/SubmittingPatches | 10 +++++++++-\n 1 files changed, 9 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 2386f49..6a4da2d 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -1,5 +1,7 @@\n Checklist (and a short version for the impatient):\n \n+\tCommits:\n+\n \t- make commits of logical units\n \t- check for unnecessary whitespace with \"git diff --check\"\n \t before committing\n@@ -12,8 +14,14 @@ Checklist (and a short version for the impatient):\n \t commit message (or just use the option \"-s\" when\n \t committing) to confirm that you agree to the Developer's\n \t Certificate of Origin\n-\t- do not PGP sign your patch\n+\n+\tPatch:\n+\n \t- use \"git format-patch -M\" to create the patch\n+\t- send your patch to . If you use\n+\t git-send-email(1), please test it first by sending\n+\t email to yourself.\n+\t- do not PGP sign your patch\n \t- do not attach your patch, but read in the mail\n \t body, unless you cannot teach your mailer to\n \t leave the formatting of the patch alone.\n-- \n1.5.1.2.GIT\n"},{"id":"40756","messageId":"7vzm4pbmsp.fsf_-_@assigned-by-dhcp.cox.net","threadId":"7903","inReplyTo":"Pine.LNX.4.64.0704301333400.29859@racer.site","subject":"[PATCH] send-email: add a few config variables.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-30T21:00:06Z","receivedAt":"2007-04-30T21:00:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This adds from, to, suppressfrom and nosignedoffcc configuration\nvariables to git-send-email, so that these common options do not\nhave to be given from the command line all the time.\n\nSigned-off-by: Junio C Hamano \n---\n\n * I do not use send-email myself that often, but it irritated\n me enough that there do not seem to be a way to set these\n common things in the configuration. Maybe I was missing\n something obvious and this patch is not needed. I dunno.\n\n Documentation/git-send-email.txt | 17 +++++++++++++++++\n git-send-email.perl | 30 +++++++++++++++++++++++++-----\n 2 files changed, 42 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 795db87..3435b8c 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -119,6 +119,23 @@ sendemail.chainreplyto::\n \tBoolean value specifying the default to the '--chain_reply_to'\n \tparameter.\n \n+sendemail.fromme::\n+\tBoolean; when set, use your authorname and authoremail\n+\t(typically found in `.git/config` as user.name and\n+\tuser.email variables) if `--from` option is not given.\n+\n+sendemail.to::\n+\tWhen `--to` is not specified on the command line, use\n+\tthis address instead.\n+\n+sendemail.suppressfrom::\n+\tBoolean; when set, act as if `--suppress-from` is given\n+\ton the command line.\n+\n+sendemail.nosignedoffcc::\n+\tBoolean; when set, act as if `--no-signed-off-cc` is\n+\tgiven on the command line.\n+\n sendemail.smtpserver::\n \tDefault smtp server to use.\n \ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex a6e3e02..785fb75 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -164,6 +164,18 @@ if (!@bcclist or !$bcclist[0]) {\n @bcclist = ();\n }\n \n+my $fromme;\n+\n+for my $ent (['fromme', \\$fromme],\n+\t ['suppressfrom', \\$suppress_from],\n+\t ['nosignedoffcc', \\$no_signed_off_cc]) {\n+\tmy $val = $repo->config_boolean('sendemail.' . $ent->[0]);\n+\tmy $var = $ent->[1];\n+\t${$var} = (! ($val && $val eq 'false'));\n+}\n+\n+my $default_to = $repo->config('sendmail.to');\n+\n # Begin by accumulating all the variables (defined above), that we will end up\n # needing, first, from the command line:\n \n@@ -187,6 +199,19 @@ unless ($rc) {\n usage();\n }\n \n+# Now, let's fill any that aren't set in with defaults:\n+\n+my ($author) = $repo->ident_person('author');\n+my ($committer) = $repo->ident_person('committer');\n+\n+if ($fromme && !defined $from) {\n+\t$from = $author;\n+}\n+\n+if (!@to && $default_to ne '') {\n+\tpush @to, $default_to;\n+}\n+\n # Verify the user input\n \n foreach my $entry (@to) {\n@@ -201,11 +226,6 @@ foreach my $entry (@bcclist) {\n \tdie \"Comma in --bcclist entry: $entry'\\n\" unless $entry !~ m/,/;\n }\n \n-# Now, let's fill any that aren't set in with defaults:\n-\n-my ($author) = $repo->ident_person('author');\n-my ($committer) = $repo->ident_person('committer');\n-\n my %aliases;\n my @alias_files = $repo->config('sendemail.aliasesfile');\n my $aliasfiletype = $repo->config('sendemail.aliasfiletype');\n-- \n1.5.2.rc0.781.g5868\n"},{"id":"40777","messageId":"7vejm1bflk.fsf@assigned-by-dhcp.cox.net","threadId":"7903","inReplyTo":"y7k9x306.fsf_-_@cante.net","subject":"Re: [PATCH] v2: Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-30T23:35:35Z","receivedAt":"2007-04-30T23:35:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jari Aalto writes:\n\n> From e65853b7bede747912a51fd77d5cf62fb255b116 Mon Sep 17 00:00:00 2001\n> From: Jari Aalto \n> Date: Mon, 30 Apr 2007 18:57:25 +0300\n> Subject: [PATCH] Checklist clarifications: added Commits, Patch: headings\n>\n> Signed-off-by: Jari Aalto \n> ---\n> This is version 2 of the orignal patch. Corrected according\n> to Julian Phillips's comments.\n\nThe first one was well formatted, but this one is not quite.\n\nDo not have \"v2\" outside of \"[PATCH ...]\".\n\nI'll apply it by hand as the text itself feels an improvement.\n\nThanks.\n"},{"id":"40783","messageId":"7vslah89oi.fsf@assigned-by-dhcp.cox.net","threadId":"7903","inReplyTo":"Pine.LNX.4.64.0704301333400.29859@racer.site","subject":"Re: [PATCH] Checklist clarifications: added \"Commits\", \"Patch:\" headings","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-01T04:11:41Z","receivedAt":"2007-05-01T04:11:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> However, my impression was that many people had problems when first \n> sending patches with send-email. There should be _at least_ a word of \n> caution, that you should test the operation on something different than \n> the Git list first.\n\nAlso an EXAMPLES section to Documentation/git-send-email.txt\nwould be useful.\n"}]}