{"thread":{"id":"7890","subject":"[PATCH] Ensure test-genrandom availability for t5301/t5302","startedAt":"2007-04-28T19:46:02Z","lastAt":"2007-04-28T22:48:39Z","messageCount":4,"participants":["Dana How","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"40672","messageId":"4633A47A.4020508@cswitch.com","threadId":"7890","inReplyTo":null,"subject":"[PATCH] Ensure test-genrandom availability for t5301/t5302","fromName":"Dana How","fromEmail":"how@cswitch.com","sentAt":"2007-04-28T19:46:02Z","receivedAt":"2007-04-28T19:46:02Z","isPatch":true,"sender":{"key":"how@cswitch.com","avatar":null},"body":"\nCheck for this as well as test-chmtime in test-lib.sh\n\nSigned-off-by: Dana L. How \n---\n t/test-lib.sh | 13 ++++++++-----\n 1 files changed, 8 insertions(+), 5 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex f2c6bd3..d7838fc 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -268,11 +268,14 @@ test -d ../templates/blt || {\n \terror \"You haven't built things yet, have you?\"\n }\n \n-if ! test -x ../test-chmtime; then\n-\techo >&2 'You need to build test-chmtime:'\n-\techo >&2 'Run \"make test-chmtime\" in the source (toplevel) directory'\n-\texit 1\n-fi\n+for prog in test-chmtime test-genrandom\n+do\n+\tif ! test -x ../$prog; then\n+\t\techo >&2 \"You need to build $prog:\"\n+\t\techo >&2 \"Run \\\"make $prog\\\" in the source (toplevel) directory\"\n+\t\texit 1\n+\tfi\n+done\n \n # Test repository\n test=trash\n-- \n1.5.2.rc0.71.g4342-dirty\n"},{"id":"40674","messageId":"7v3b2kjfji.fsf@assigned-by-dhcp.cox.net","threadId":"7890","inReplyTo":"4633A47A.4020508@cswitch.com","subject":"Re: [PATCH] Ensure test-genrandom availability for t5301/t5302","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-28T22:32:49Z","receivedAt":"2007-04-28T22:32:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dana How writes:\n\n> Check for this as well as test-chmtime in test-lib.sh\n>\n> Signed-off-by: Dana L. How \n> ---\n> t/test-lib.sh | 13 ++++++++-----\n> 1 files changed, 8 insertions(+), 5 deletions(-)\n>\n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index f2c6bd3..d7838fc 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -268,11 +268,14 @@ test -d ../templates/blt || {\n> \terror \"You haven't built things yet, have you?\"\n> }\n> \n> -if ! test -x ../test-chmtime; then\n> -\techo >&2 'You need to build test-chmtime:'\n> -\techo >&2 'Run \"make test-chmtime\" in the source (toplevel) directory'\n> -\texit 1\n> -fi\n> +for prog in test-chmtime test-genrandom\n> +do\n> +\tif ! test -x ../$prog; then\n> +\t\techo >&2 \"You need to build $prog:\"\n> +\t\techo >&2 \"Run \\\"make $prog\\\" in the source (toplevel) directory\"\n> +\t\texit 1\n> +\tfi\n> +done\n> \n> # Test repository\n> test=trash\n> -- \n> 1.5.2.rc0.71.g4342-dirty\n\nAs these two are very small programs, why not always build them\nupon \"make all\", like this?\n\n---\n Makefile | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 60c41fd..817f8ef 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -933,13 +933,17 @@ endif\n \n ### Testing rules\n \n+TEST_PROGRAMS = test-chmtime$X test-genrandom$X\n+\n+all:: $(TEST_PROGRAMS)\n+\n # GNU make supports exporting all variables by \"export\" without parameters.\n # However, the environment gets quite big, and some programs have problems\n # with that.\n \n export NO_SVN_TESTS\n \n-test: all test-chmtime$X test-genrandom$X\n+test: all\n \t$(MAKE) -C t/ all\n \n test-date$X: test-date.c date.o ctype.o\n"},{"id":"40675","messageId":"56b7f5510704281536u5b5751a0k504a5ec0f8a36cf7@mail.gmail.com","threadId":"7890","inReplyTo":"7v3b2kjfji.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Ensure test-genrandom availability for t5301/t5302","fromName":"Dana How","fromEmail":"danahow@gmail.com","sentAt":"2007-04-28T22:36:54Z","receivedAt":"2007-04-28T22:36:54Z","isPatch":true,"sender":{"key":"danahow@gmail.com","avatar":null},"body":"Either way is fine with me.\nI just don't want any one to have the nasty surprise I had --\nfortunately I figured it out quickly.\n\nSo you will apply your patch?\n\nThanks,\n\nDana\n\nOn 4/28/07, Junio C Hamano wrote:\n> Dana How writes:\n>\n> > Check for this as well as test-chmtime in test-lib.sh\n> >\n> > Signed-off-by: Dana L. How \n> > ---\n> > t/test-lib.sh | 13 ++++++++-----\n> > 1 files changed, 8 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/t/test-lib.sh b/t/test-lib.sh\n> > index f2c6bd3..d7838fc 100644\n> > --- a/t/test-lib.sh\n> > +++ b/t/test-lib.sh\n> > @@ -268,11 +268,14 @@ test -d ../templates/blt || {\n> > error \"You haven't built things yet, have you?\"\n> > }\n> >\n> > -if ! test -x ../test-chmtime; then\n> > - echo >&2 'You need to build test-chmtime:'\n> > - echo >&2 'Run \"make test-chmtime\" in the source (toplevel) directory'\n> > - exit 1\n> > -fi\n> > +for prog in test-chmtime test-genrandom\n> > +do\n> > + if ! test -x ../$prog; then\n> > + echo >&2 \"You need to build $prog:\"\n> > + echo >&2 \"Run \\\"make $prog\\\" in the source (toplevel) directory\"\n> > + exit 1\n> > + fi\n> > +done\n> >\n> > # Test repository\n> > test=trash\n> > --\n> > 1.5.2.rc0.71.g4342-dirty\n>\n> As these two are very small programs, why not always build them\n> upon \"make all\", like this?\n>\n> ---\n> Makefile | 6 +++++-\n> 1 files changed, 5 insertions(+), 1 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index 60c41fd..817f8ef 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -933,13 +933,17 @@ endif\n>\n> ### Testing rules\n>\n> +TEST_PROGRAMS = test-chmtime$X test-genrandom$X\n> +\n> +all:: $(TEST_PROGRAMS)\n> +\n> # GNU make supports exporting all variables by \"export\" without parameters.\n> # However, the environment gets quite big, and some programs have problems\n> # with that.\n>\n> export NO_SVN_TESTS\n>\n> -test: all test-chmtime$X test-genrandom$X\n> +test: all\n> $(MAKE) -C t/ all\n>\n> test-date$X: test-date.c date.o ctype.o\n>\n>\n>\n\n\n-- \nDana L. How danahow@gmail.com +1 650 804 5991 cell\n"},{"id":"40678","messageId":"7vodl8i08o.fsf@assigned-by-dhcp.cox.net","threadId":"7890","inReplyTo":"56b7f5510704281536u5b5751a0k504a5ec0f8a36cf7@mail.gmail.com","subject":"Re: [PATCH] Ensure test-genrandom availability for t5301/t5302","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-28T22:48:39Z","receivedAt":"2007-04-28T22:48:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Dana How\" writes:\n\n> Either way is fine with me.\n> I just don't want any one to have the nasty surprise I had --\n> fortunately I figured it out quickly.\n>\n> So you will apply your patch?\n\nPerhaps. I've known about this for some time, but it is usually\nnot a problem if you do \"make test\" from the toplevel, hence it\nwas a low priority for me.\n"}]}