{"thread":{"id":"7875","subject":"[PATCH] gitweb: Fix few 'use of undefined value' warnings","startedAt":"2007-04-27T16:43:53Z","lastAt":"2007-05-17T11:25:11Z","messageCount":5,"participants":["Petr Baudis","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"40605","messageId":"20070427164352.396.54191.stgit@rover","threadId":"7875","inReplyTo":null,"subject":"[PATCH] gitweb: Fix few 'use of undefined value' warnings","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-04-27T16:43:53Z","receivedAt":"2007-04-27T16:43:53Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Signed-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n gitweb/gitweb.perl |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex b67ce41..b51103e 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1038,6 +1038,7 @@ sub git_get_hash_by_path {\n \t\tor die_error(undef, \"Open git-ls-tree failed\");\n \tmy $line = <$fd>;\n \tclose $fd or return undef;\n+\t$line or return undef;\n \n \t#'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa\tpanic.c'\n \t$line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\\t/;\n@@ -1057,6 +1058,7 @@ sub git_get_project_description {\n \topen my $fd, \"$projectroot/$path/description\" or return undef;\n \tmy $descr = <$fd>;\n \tclose $fd;\n+\t$descr or return undef;\n \tchomp $descr;\n \treturn $descr;\n }\n@@ -1208,6 +1210,7 @@ sub git_get_last_activity {\n \t     'refs/heads') or return;\n \tmy $most_recent = <$fd>;\n \tclose $fd or return;\n+\t$most_recent or return;\n \tif ($most_recent =~ / (\\d+) [-+][01]\\d\\d\\d$/) {\n \t\tmy $timestamp = $1;\n \t\tmy $age = time - $timestamp;\n"},{"id":"40695","messageId":"7v3b2jfzef.fsf@assigned-by-dhcp.cox.net","threadId":"7875","inReplyTo":"20070427164352.396.54191.stgit@rover","subject":"Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-29T06:49:44Z","receivedAt":"2007-04-29T06:49:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"thanks.\n"},{"id":"42352","messageId":"20070517013209.GJ4489@pasky.or.cz","threadId":"7875","inReplyTo":"20070427164352.396.54191.stgit@rover","subject":"Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-05-17T01:32:09Z","receivedAt":"2007-05-17T01:32:09Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index b67ce41..b51103e 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -1057,6 +1058,7 @@ sub git_get_project_description {\n>  \topen my $fd, \"$projectroot/$path/description\" or return undef;\n>  \tmy $descr = <$fd>;\n>  \tclose $fd;\n> +\t$descr or return undef;\n>  \tchomp $descr;\n>  \treturn $descr;\n>  }\n\nIt looks like this hunk has been skipped...?\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nEver try. Ever fail. No matter. // Try again. Fail again. Fail better.\n\t\t-- Samuel Beckett\n"},{"id":"42368","messageId":"7vabw4ccy5.fsf@assigned-by-dhcp.cox.net","threadId":"7875","inReplyTo":"20070517013209.GJ4489@pasky.or.cz","subject":"Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-05-17T04:05:06Z","receivedAt":"2007-05-17T04:05:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:\n>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n>> index b67ce41..b51103e 100755\n>> --- a/gitweb/gitweb.perl\n>> +++ b/gitweb/gitweb.perl\n>> @@ -1057,6 +1058,7 @@ sub git_get_project_description {\n>>  \topen my $fd, \"$projectroot/$path/description\" or return undef;\n>>  \tmy $descr = <$fd>;\n>>  \tclose $fd;\n>> +\t$descr or return undef;\n>>  \tchomp $descr;\n>>  \treturn $descr;\n>>  }\n>\n> It looks like this hunk has been skipped...?\n\nIt is more like the whole messages was missed, and then 198a2a8a\nand others tried to do the same thing but missed this one.\n"},{"id":"42386","messageId":"20070517112510.GM4489@pasky.or.cz","threadId":"7875","inReplyTo":"7vabw4ccy5.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-05-17T11:25:11Z","receivedAt":"2007-05-17T11:25:11Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Thu, May 17, 2007 at 06:05:06AM CEST, Junio C Hamano wrote:\n> Petr Baudis <pasky@suse.cz> writes:\n> \n> > On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:\n> >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> >> index b67ce41..b51103e 100755\n> >> --- a/gitweb/gitweb.perl\n> >> +++ b/gitweb/gitweb.perl\n> >> @@ -1057,6 +1058,7 @@ sub git_get_project_description {\n> >>  \topen my $fd, \"$projectroot/$path/description\" or return undef;\n> >>  \tmy $descr = <$fd>;\n> >>  \tclose $fd;\n> >> +\t$descr or return undef;\n> >>  \tchomp $descr;\n> >>  \treturn $descr;\n> >>  }\n> >\n> > It looks like this hunk has been skipped...?\n> \n> It is more like the whole messages was missed, and then 198a2a8a\n> and others tried to do the same thing but missed this one.\n\nOh, aha - I thought that it was applied when you replied \"thanks\"...\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nEver try. Ever fail. No matter. // Try again. Fail again. Fail better.\n\t\t-- Samuel Beckett\n"}]}