{"thread":{"id":"7823","subject":"Re: [PATCH] Remove usernames from all commit messages, not just when using svmprops","startedAt":"2007-04-25T01:02:07Z","lastAt":"2007-04-25T01:33:11Z","messageCount":2,"participants":["Eric Wong","Adam Roben"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"40373","messageId":"9F361BEA-54A1-479F-9552-1E2170A83DAF@apple.com","threadId":"7823","inReplyTo":null,"subject":"[PATCH] Remove usernames from all commit messages, not just when using svmprops","fromName":"Adam Roben","fromEmail":"aroben@apple.com","sentAt":"2007-04-25T01:02:07Z","receivedAt":"2007-04-25T01:02:07Z","isPatch":true,"sender":{"key":"aroben@apple.com","avatar":"https://gravatar.com/avatar/9d3697e1de53890adf241331f4b970bdd2b18962b2ff0b8028ebb00e085807f8?d=mp&s=160"},"body":"Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>\nSigned-off-by: Adam Roben <aroben@apple.com>\n---\n  git-svn.perl |    5 ++++-\n  1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex efc4c88..077d6b3 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1866,11 +1866,14 @@ sub make_log_entry {\n  \t} elsif ($self->use_svnsync_props) {\n  \t\tmy $full_url = $self->svnsync->{url};\n  \t\t$full_url .= \"/$self->{path}\" if length $self->{path};\n+\t\tremove_username($full_url);\n  \t\tmy $uuid = $self->svnsync->{uuid};\n  \t\t$log_entry{metadata} = \"$full_url\\@$rev $uuid\";\n  \t\t$email ||= \"$author\\@$uuid\"\n  \t} else {\n-\t\t$log_entry{metadata} = $self->metadata_url. \"\\@$rev \" .\n+\t\tmy $url = $self->metadata_url;\n+\t\tremove_username($url);\n+\t\t$log_entry{metadata} = \"$url\\@$rev \" .\n  \t\t                       $self->ra->get_uuid;\n  \t\t$email ||= \"$author\\@\" . $self->ra->get_uuid;\n  \t}\n-- \n1.5.2.rc0.14.g520d-dirty\n"},{"id":"40372","messageId":"20070425013221.GC7169@muzzle","threadId":"7823","inReplyTo":"9F361BEA-54A1-479F-9552-1E2170A83DAF@apple.com","subject":"Re: [PATCH] Remove usernames from all commit messages, not just when using svmprops","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-04-25T01:33:11Z","receivedAt":"2007-04-25T01:33:11Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Adam Roben <aroben@apple.com> wrote:\n> Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>\n> Signed-off-by: Adam Roben <aroben@apple.com>\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n> ---\n>  git-svn.perl |    5 ++++-\n>  1 files changed, 4 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index efc4c88..077d6b3 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -1866,11 +1866,14 @@ sub make_log_entry {\n>  \t} elsif ($self->use_svnsync_props) {\n>  \t\tmy $full_url = $self->svnsync->{url};\n>  \t\t$full_url .= \"/$self->{path}\" if length $self->{path};\n> +\t\tremove_username($full_url);\n>  \t\tmy $uuid = $self->svnsync->{uuid};\n>  \t\t$log_entry{metadata} = \"$full_url\\@$rev $uuid\";\n>  \t\t$email ||= \"$author\\@$uuid\"\n>  \t} else {\n> -\t\t$log_entry{metadata} = $self->metadata_url. \"\\@$rev \" .\n> +\t\tmy $url = $self->metadata_url;\n> +\t\tremove_username($url);\n> +\t\t$log_entry{metadata} = \"$url\\@$rev \" .\n>  \t\t                       $self->ra->get_uuid;\n>  \t\t$email ||= \"$author\\@\" . $self->ra->get_uuid;\n>  \t}\n> -- \n> 1.5.2.rc0.14.g520d-dirty\n\n-- \nEric Wong\n"}]}