{"thread":{"id":"7798","subject":"t4201-shortlog.sh does bad things to my terminal","startedAt":"2007-04-23T17:03:01Z","lastAt":"2007-04-23T20:14:04Z","messageCount":6,"participants":["Sven Verdoolaege","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"40212","messageId":"20070423170301.GL955MdfPADPa@greensroom.kotnet.org","threadId":"7798","inReplyTo":null,"subject":"t4201-shortlog.sh does bad things to my terminal","fromName":"Sven Verdoolaege","fromEmail":"skimo@kotnet.org","sentAt":"2007-04-23T17:03:01Z","receivedAt":"2007-04-23T17:03:01Z","isPatch":false,"sender":{"key":"skimo@kotnet.org","avatar":null},"body":"Running t4201-shortlog.sh in a non-utf8 terminal has some unpleasant effects:\n\nbash-3.00$ xterm -v\nXFree86 4.2.99.903(174)\nbash-3.00$ locale\nLANG=en_US\nLC_CTYPE=\"en_US\"\nLC_NUMERIC=\"en_US\"\nLC_TIME=\"en_US\"\nLC_COLLATE=POSIX\nLC_MONETARY=\"en_US\"\nLC_MESSAGES=\"en_US\"\nLC_PAPER=\"en_US\"\nLC_NAME=\"en_US\"\nLC_ADDRESS=\"en_US\"\nLC_TELEPHONE=\"en_US\"\nLC_MEASUREMENT=\"en_US\"\nLC_IDENTIFICATION=\"en_US\"\nLC_ALL=\nbash-3.00$ sh ./t4201-shortlog.sh --verbose\nCreated commit b8ab028: This is a very, very long first line for the commit message to see if it is wrapped correctly\n 1 files changed, 1 insertions(+), 1 deletions(-)\nCreated commit 3da0b85: Thð\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n(The cursor is now about half way the last line.)\n\nIt appears that this message is printing a control character to turn off echoing,\nbecause the terminal appears completely unresponsive afterwards.\nTyping \"reset\" restores the terminal.\n\nIs this really necessary?\n\nskimo\n"},{"id":"40219","messageId":"Pine.LNX.4.64.0704231928270.8822@racer.site","threadId":"7798","inReplyTo":"20070423170301.GL955MdfPADPa@greensroom.kotnet.org","subject":"Re: t4201-shortlog.sh does bad things to my terminal","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-04-23T17:29:29Z","receivedAt":"2007-04-23T17:29:29Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 23 Apr 2007, Sven Verdoolaege wrote:\n\n> It appears that this message is printing a control character to turn off \n> echoing, because the terminal appears completely unresponsive \n> afterwards. Typing \"reset\" restores the terminal.\n> \n> Is this really necessary?\n\nOn both accounts, no. I did not dream of these bytes being interpreted as \ncontrol characters.\n\nOTOH, you should not need to use --verbose anyway.\n\nCiao,\nDscho\n"},{"id":"40221","messageId":"20070423174803.GN955MdfPADPa@greensroom.kotnet.org","threadId":"7798","inReplyTo":"Pine.LNX.4.64.0704231928270.8822@racer.site","subject":"Re: t4201-shortlog.sh does bad things to my terminal","fromName":"Sven Verdoolaege","fromEmail":"skimo@kotnet.org","sentAt":"2007-04-23T17:48:03Z","receivedAt":"2007-04-23T17:48:03Z","isPatch":false,"sender":{"key":"skimo@kotnet.org","avatar":null},"body":"On Mon, Apr 23, 2007 at 07:29:29PM +0200, Johannes Schindelin wrote:\n> OTOH, you should not need to use --verbose anyway.\n\nWell, it does the same thing when I don't use --verbose.\nI only noticed because \"make test\" stopped producing output.\n\nskimo\n"},{"id":"40225","messageId":"7vmz0zey30.fsf@assigned-by-dhcp.cox.net","threadId":"7798","inReplyTo":"Pine.LNX.4.64.0704231928270.8822@racer.site","subject":"Re: t4201-shortlog.sh does bad things to my terminal","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-23T18:37:39Z","receivedAt":"2007-04-23T18:37:39Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> On Mon, 23 Apr 2007, Sven Verdoolaege wrote:\n>\n>> It appears that this message is printing a control character to turn off \n>> echoing, because the terminal appears completely unresponsive \n>> afterwards. Typing \"reset\" restores the terminal.\n>> \n>> Is this really necessary?\n>\n> On both accounts, no. I did not dream of these bytes being interpreted as \n> control characters.\n>\n> OTOH, you should not need to use --verbose anyway.\n\nI think it's not Sven but you; you should use --quiet in your\ngit commit if the log message has annoying characters.\n"},{"id":"40228","messageId":"Pine.LNX.4.64.0704232042170.8822@racer.site","threadId":"7798","inReplyTo":"7vmz0zey30.fsf@assigned-by-dhcp.cox.net","subject":"Re: t4201-shortlog.sh does bad things to my terminal","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-04-23T18:46:21Z","receivedAt":"2007-04-23T18:46:21Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 23 Apr 2007, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> \n> > On Mon, 23 Apr 2007, Sven Verdoolaege wrote:\n> >\n> >> It appears that this message is printing a control character to turn off \n> >> echoing, because the terminal appears completely unresponsive \n> >> afterwards. Typing \"reset\" restores the terminal.\n> >> \n> >> Is this really necessary?\n> >\n> > On both accounts, no. I did not dream of these bytes being interpreted as \n> > control characters.\n> >\n> > OTOH, you should not need to use --verbose anyway.\n> \n> I think it's not Sven but you; you should use --quiet in your\n> git commit if the log message has annoying characters.\n\nAh!\n\nI see where this is coming from: c7263d4d \"Display the subject of the \ncommit just made\".\n\nHere's the fix:\n\n-- snip --\n[PATCH] t4201: Do not display weird characters on the terminal\n\nNow that git-commit got chatty, we have to shut it up again.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n t/t4201-shortlog.sh |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh\nindex c27e39c..a48733c 100755\n--- a/t/t4201-shortlog.sh\n+++ b/t/t4201-shortlog.sh\n@@ -15,19 +15,19 @@ commit=$( (echo \"Test\"; echo) | git commit-tree $tree )\n git update-ref HEAD $commit\n \n echo 2 > a1\n-git commit -m \"This is a very, very long first line for the commit message to see if it is wrapped correctly\" a1\n+git commit --quiet -m \"This is a very, very long first line for the commit message to see if it is wrapped correctly\" a1\n \n # test if the wrapping is still valid when replacing all i's by treble clefs.\n echo 3 > a1\n-git commit -m \"$(echo \"This is a very, very long first line for the commit message to see if it is wrapped correctly\" | sed \"s/i/1234/g\" | tr 1234 '\\360\\235\\204\\236')\" a1\n+git commit --quiet -m \"$(echo \"This is a very, very long first line for the commit message to see if it is wrapped correctly\" | sed \"s/i/1234/g\" | tr 1234 '\\360\\235\\204\\236')\" a1\n \n # now fsck up the utf8\n git repo-config i18n.commitencoding non-utf-8\n echo 4 > a1\n-git commit -m \"$(echo \"This is a very, very long first line for the commit message to see if it is wrapped correctly\" | sed \"s/i/1234/g\" | tr 1234 '\\370\\235\\204\\236')\" a1\n+git commit --quiet -m \"$(echo \"This is a very, very long first line for the commit message to see if it is wrapped correctly\" | sed \"s/i/1234/g\" | tr 1234 '\\370\\235\\204\\236')\" a1\n \n echo 5 > a1\n-git commit -m \"a\t\t\t\t\t\t\t\t12\t34\t56\t78\" a1\n+git commit --quiet -m \"a\t\t\t\t\t\t\t\t12\t34\t56\t78\" a1\n \n git shortlog -w HEAD > out\n \n-- \n1.5.2.rc0.2414.g4e945\n"},{"id":"40235","messageId":"7v4pn6g86r.fsf@assigned-by-dhcp.cox.net","threadId":"7798","inReplyTo":"Pine.LNX.4.64.0704232042170.8822@racer.site","subject":"Re: t4201-shortlog.sh does bad things to my terminal","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-23T20:14:04Z","receivedAt":"2007-04-23T20:14:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Ah!\n>\n> I see where this is coming from: c7263d4d \"Display the subject of the \n> commit just made\".\n>\n> Here's the fix:\n\nthanks.\n"}]}