{"thread":{"id":"764","subject":"Problem with cg-diff ","startedAt":"2005-05-29T23:15:55Z","lastAt":"2005-05-30T08:36:03Z","messageCount":6,"participants":["Marcel Holtmann","Petr Baudis","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"4207","messageId":"1117408555.7072.109.camel@pegasus","threadId":"764","inReplyTo":null,"subject":"Problem with cg-diff ","fromName":"Marcel Holtmann","fromEmail":"marcel@holtmann.org","sentAt":"2005-05-29T23:15:55Z","receivedAt":"2005-05-29T23:15:55Z","isPatch":false,"sender":{"key":"marcel@holtmann.org","avatar":null},"body":"Hi Petr,\n\nyour latest changes are breaking the cg-diff functionality. Now\ncg-diff creates a diff against all local not committed changes.\n\nRegards\n\nMarcel\n\n\n"},{"id":"4210","messageId":"20050529233840.GY1036@pasky.ji.cz","threadId":"764","inReplyTo":"1117408555.7072.109.camel@pegasus","subject":"Re: Problem with cg-diff ","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-05-29T23:38:40Z","receivedAt":"2005-05-29T23:38:40Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Mon, May 30, 2005 at 01:15:55AM CEST, I got a letter\nwhere Marcel Holtmann told me that...\n> Hi Petr,\n\nHi,\n\n> your latest changes are breaking the cg-diff functionality. Now\n> cg-diff creates a diff against all local not committed changes.\n\noops, thanks for the report. Hopefully fixed and pushed out.\n\nEek, apparently not entirely fixed yet. git-diff-tree (in contrast to\ngit-diff-cache) won't take the pathspec as its trailing arguments,\ncausing cg-diff -r a:b still not to work 100% correct.\n\nJunio, is there any specific reason for that, or is the end of\ngit-diff-tree argument list the right spot for the pathspec stuff?\n\nThanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"},{"id":"4220","messageId":"7vis11ftvm.fsf@assigned-by-dhcp.cox.net","threadId":"764","inReplyTo":"20050529233840.GY1036@pasky.ji.cz","subject":"Re: Problem with cg-diff ","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-30T00:19:09Z","receivedAt":"2005-05-30T00:19:09Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":">>>>> \"PB\" == Petr Baudis writes:\n\nPB> ... git-diff-tree (in contrast to\nPB> git-diff-cache) won't take the pathspec as its trailing arguments,\n\nPB> Junio, is there any specific reason for that, or is the end of\nPB> git-diff-tree argument list the right spot for the pathspec stuff?\n\nBaffled. Are you at Linus tip?\n\nLinus correctly decided that diff-tree does not have to call\ndiffcore_pathspec(), which may be what confused you to make the\ncomment \"... in contrast to git-diff-cache) won't take ...\".\nBut it does not call it only because it does not need to. It\nfilters the filepairs itself on the input side using the\ntrailing arguments; since diffcore_pathspec filters as the first\none in the chain as the input filter, calling it from diff-tree\nwould not cull anything further.\n\nHere is what I am getting from the Linus tip binary, between my\nHEAD and Linus tip:\n\n$ git-diff-tree -r linus HEAD >.all ;# everything\n$ git-diff-tree -r linus HEAD t >.t-only ;# limiting to the test suite\n$ wc -l .all .t-only ;# count results\n 12 .all\n 3 .t-only\n 15 total\n$ cat .t-only\t\t\t\t ;# show what's in \"t\" output\n:100644 100644 a51985518251f6c3f677438c3cb51b9716c20296 5ac29d1f98438d3530bbc8b0bdaced58200aca37 M\tt/t4005-diff-rename-2.sh\n:100644 100644 518892b90c7cbb3fb193d6bfb622046aff0f4431 76ae7201f0d19b7933ca44958b7c468193ec9778 M\tt/t4007-rename-3.sh\n:000000 100755 0000000000000000000000000000000000000000 01d276692669f2241471b8ad611b17d51e2a98ab N\tt/t4009-diff-rename-4.sh\n$ head -n 1 .all ;# prove that \"t\" filtered. \n:100644 100644 f85a605f0a336f506cf5cf46476a43e4c56b3e66 1d92a01a02543e55d0feb3541ee594fbc638136c M\tDocumentation/diff-format.txt\n\n"},{"id":"4222","messageId":"20050530003242.GA1036@pasky.ji.cz","threadId":"764","inReplyTo":"7vis11ftvm.fsf@assigned-by-dhcp.cox.net","subject":"Re: Problem with cg-diff ","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-05-30T00:32:42Z","receivedAt":"2005-05-30T00:32:42Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Mon, May 30, 2005 at 02:19:09AM CEST, I got a letter\nwhere Junio C Hamano told me that...\n> >>>>> \"PB\" == Petr Baudis writes:\n> \n> PB> ... git-diff-tree (in contrast to\n> PB> git-diff-cache) won't take the pathspec as its trailing arguments,\n> \n> PB> Junio, is there any specific reason for that, or is the end of\n> PB> git-diff-tree argument list the right spot for the pathspec stuff?\n> \n> Baffled. Are you at Linus tip?\n> \n> Linus correctly decided that diff-tree does not have to call\n> diffcore_pathspec(), which may be what confused you to make the\n> comment \"... in contrast to git-diff-cache) won't take ...\".\n> But it does not call it only because it does not need to. It\n> filters the filepairs itself on the input side using the\n> trailing arguments; since diffcore_pathspec filters as the first\n> one in the chain as the input filter, calling it from diff-tree\n> would not cull anything further.\n\nOk, so this is what you get when you mix: sleepiness, performing only\nmental experiments not verified in practice, and inattentive reading of\nthe code.\n\nI'm sorry for bothering. Instruct yourself from my bad example, please.\n:-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"},{"id":"4242","messageId":"7vfyw55eu2.fsf@assigned-by-dhcp.cox.net","threadId":"764","inReplyTo":"20050530003242.GA1036@pasky.ji.cz","subject":"Re: Problem with cg-diff ","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-30T07:54:13Z","receivedAt":"2005-05-30T07:54:13Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":">>>>> \"PB\" == Petr Baudis writes:\n\nPB> Ok, so this is what you get when you mix: sleepiness, performing only\nPB> mental experiments not verified in practice, and inattentive reading of\nPB> the code.\n\nPB> I'm sorry for bothering. Instruct yourself from my bad example, please.\nPB> :-)\n\nIf you forbid people to ask for help when the person who is\nasked might feel the question groundless or based on \"only\nmental experiments not verified in practice and inattentive\nreading of the code\", the value to have a community diminishes.\n\nWe ask questions and ask for help because we know others know\nmore about things we do not know offhand, not necessarily\nbecause we would not ever be able to figure them out ourselves.\n\nIf you know somebody else would know the answer immediately for\nsomething that may take you a day or so to figure out, asking\nfor help is the right thing to do --- your time is better spent\non what you do best (e.g. improving Cogito). I should not feel\nbothered by your questions, and I am certainly not feeling\nbothered at all (well, at least until seeing the last sentence,\nand wondering what you really meant ;-)).\n\nAlways glad to be of help.\n\n"},{"id":"4246","messageId":"20050530083603.GD1036@pasky.ji.cz","threadId":"764","inReplyTo":"7vfyw55eu2.fsf@assigned-by-dhcp.cox.net","subject":"Re: Problem with cg-diff ","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-05-30T08:36:03Z","receivedAt":"2005-05-30T08:36:03Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Mon, May 30, 2005 at 09:54:13AM CEST, I got a letter\nwhere Junio C Hamano told me that...\n> >>>>> \"PB\" == Petr Baudis writes:\n> \n> PB> Ok, so this is what you get when you mix: sleepiness, performing only\n> PB> mental experiments not verified in practice, and inattentive reading of\n> PB> the code.\n> \n> PB> I'm sorry for bothering. Instruct yourself from my bad example, please.\n> PB> :-)\n> \n> If you forbid people to ask for help when the person who is\n> asked might feel the question groundless or based on \"only\n> mental experiments not verified in practice and inattentive\n> reading of the code\", the value to have a community diminishes.\n> \n> We ask questions and ask for help because we know others know\n> more about things we do not know offhand, not necessarily\n> because we would not ever be able to figure them out ourselves.\n> \n> If you know somebody else would know the answer immediately for\n> something that may take you a day or so to figure out, asking\n> for help is the right thing to do --- your time is better spent\n> on what you do best (e.g. improving Cogito).\n\nWell, you definitively have a point. I just felt guilty that if I\nwould've spent ten seconds actually testing it, you wouldn't have to\nspent ten minutes (or who knows how long) replying to my silly question.\n\n> I should not feel bothered by your questions, and I am certainly not\n> feeling bothered at all (well, at least until seeing the last\n> sentence, and wondering what you really meant ;-)).\n\nI meant you all on the mailing list, not you specifically. English is\nsometimes annoying. ;-) (And I was just trying to be funny, in my usual\nawful way.)\n\n> Always glad to be of help.\n\nThanks. :-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"}]}