{"thread":{"id":"753","subject":"[PATCH Cogito] cg-log: improve parsing -r","startedAt":"2005-05-29T01:41:38Z","lastAt":"2005-05-29T01:41:38Z","messageCount":1,"participants":["Jonas Fonseca"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"4150","messageId":"20050529014138.GB7520@diku.dk","threadId":"753","inReplyTo":null,"subject":"[PATCH Cogito] cg-log: improve parsing -r","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2005-05-29T01:41:38Z","receivedAt":"2005-05-29T01:41:38Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Move parsing of the -r option to the option parsing loop so it no longer\nneeds to be last in the argument list.\n\nSigned-off-by: Jonas Fonseca <fonseca@diku.dk>\n---\n\n cg-log |   32 +++++++++++++++-----------------\n 1 files changed, 15 insertions(+), 17 deletions(-)\n\n--- c8e987e5e4608c1144293cd3f852210d70b572cb/cg-log  (mode:100755)\n+++ uncommitted/cg-log  (mode:100755)\n@@ -37,7 +37,10 @@\n colsignoff=\n coldefault=\n list_files=\n+log_start=\n+log_end=\n user=\n+\n while [ \"$1\" ]; do\n \t# TODO: Parse -r here too.\n \tcase \"$1\" in\n@@ -59,6 +62,18 @@\n \t\tuser=\"${1#-u}\"\n \t\tshift\n \t\t;;\n+\t-r)\n+\t\tshift\n+\t\tif echo \"$1\" | grep -q ':'; then\n+\t\t\tlog_end=$(echo \"$1\" | cut -d : -f 2)\n+\t\t\tlog_start=$(echo \"$1\" | cut -d : -f 1)\n+\t\telif [ -z \"$log_start\" ]; then\n+\t\t\tlog_start=\"$1\"\n+\t\telse\n+\t\t\tlog_end=\"$1\"\n+\t\tfi\n+\t\tshift\n+\t\t;;\n \t*)\n \t\tbreak\n \t\t;;\n@@ -93,23 +108,6 @@\n \techo \"$coldefault:\"\n }\n \n-log_start=\n-log_end=\n-if [ \"$1\" = \"-r\" ]; then\n-\tshift\n-\tlog_start=\"$1\"\n-\tshift\n-\tif echo \"$log_start\" | grep -q ':'; then\n-\t\tlog_end=$(echo \"$log_start\" | cut -d : -f 2)\n-\t\tlog_start=$(echo \"$log_start\" | cut -d : -f 1)\n-\tfi\n-fi\n-if [ \"$1\" = \"-r\" ]; then\n-\tshift\n-\tlog_end=\"$1\"\n-\tshift\n-fi\n-\n if [ \"$log_end\" ]; then\n \tid1=\"$(commit-id $log_start)\" || exit 1\n \tid2=\"$(commit-id $log_end)\" || exit 1\n-- \nJonas Fonseca\n"}]}