{"thread":{"id":"7488","subject":"[PATCH (resend)] cvsserver: Don't lie about binary mode in asciidoc documentation","startedAt":"2007-03-31T13:32:13Z","lastAt":"2007-03-31T13:32:13Z","messageCount":1,"participants":["Frank Lichtenheld"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38434","messageId":"11753479333854-git-send-email-frank@lichtenheld.de","threadId":"7488","inReplyTo":null,"subject":"[PATCH (resend)] cvsserver: Don't lie about binary mode in asciidoc documentation","fromName":"Frank Lichtenheld","fromEmail":"frank@lichtenheld.de","sentAt":"2007-03-31T13:32:13Z","receivedAt":"2007-03-31T13:32:13Z","isPatch":true,"sender":{"key":"frank@lichtenheld.de","avatar":"https://gravatar.com/avatar/b9f1d4b120e138f157c9e480d0818197c474628923786adb98f30017cdb99c3c?d=mp&s=160"},"body":"The git-cvsserver documentation claims that the server will set\n-k modes if appropriate which is not really the case. On the other\nhand the available gitcvs.allbinary variable is not documented at\nall. Fix both these issues by rewording the related paragraph.\n\nSigned-off-by: Frank Lichtenheld <frank@lichtenheld.de>\n---\n Documentation/git-cvsserver.txt |    8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)\n\nI send this before but it seems to have been lost in the noise.\nAlso CCed Andy Parkins this time who introduced the gitcvs.allbinary\nvariable.\n\nI think this should be suitable for 1.5.1.\n\ndiff --git a/Documentation/git-cvsserver.txt b/Documentation/git-cvsserver.txt\nindex 1c6f6a7..85d0950 100644\n--- a/Documentation/git-cvsserver.txt\n+++ b/Documentation/git-cvsserver.txt\n@@ -134,9 +134,11 @@ checkout, diff, status, update, log, add, remove, commit.\n Legacy monitoring operations are not supported (edit, watch and related).\n Exports and tagging (tags and branches) are not supported at this stage.\n \n-The server will set the -k mode to binary when relevant. In proper GIT\n-tradition, the contents of the files are always respected.\n-No keyword expansion or newline munging is supported.\n+The server should set the -k mode to binary when relevant, however,\n+this is not really implemented yet. For now, you can force the server\n+to set `-kb` for all files by setting the `gitcvs.allbinary` config\n+variable. In proper GIT tradition, the contents of the files are\n+always respected. No keyword expansion or newline munging is supported.\n \n Dependencies\n ------------\n-- \n1.5.0.3\n"}]}