{"thread":{"id":"7480","subject":"[PATCH] git-mergetool: de-bashify function declarations","startedAt":"2007-03-30T03:26:45Z","lastAt":"2007-03-30T04:03:12Z","messageCount":2,"participants":["Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38371","messageId":"20070330032645.GA6876@coredump.intra.peff.net","threadId":"7480","inReplyTo":null,"subject":"[PATCH] git-mergetool: de-bashify function declarations","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-03-30T03:26:45Z","receivedAt":"2007-03-30T03:26:45Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"\nSigned-off-by: Jeff King <peff@peff.net>\n---\nWorks fine otherwise for me using dash as /bin/sh...\n\n git-mergetool.sh |   10 +++++-----\n 1 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/git-mergetool.sh b/git-mergetool.sh\nindex 7942fd0..68b35d3 100755\n--- a/git-mergetool.sh\n+++ b/git-mergetool.sh\n@@ -14,19 +14,19 @@ SUBDIRECTORY_OK=Yes\n require_work_tree\n \n # Returns true if the mode reflects a symlink\n-function is_symlink () {\n+is_symlink () {\n     test \"$1\" = 120000\n }\n \n-function local_present () {\n+local_present () {\n     test -n \"$local_mode\"\n }\n \n-function remote_present () {\n+remote_present () {\n     test -n \"$remote_mode\"\n }\n \n-function base_present () {\n+base_present () {\n     test -n \"$base_mode\"\n }\n \n@@ -39,7 +39,7 @@ cleanup_temp_files () {\n     fi\n }\n \n-function describe_file () {\n+describe_file () {\n     mode=\"$1\"\n     branch=\"$2\"\n     file=\"$3\"\n-- \n1.5.1.rc2.638.g85e08-dirty\n"},{"id":"38372","messageId":"20070330040312.GB2522@coredump.intra.peff.net","threadId":"7480","inReplyTo":"20070330032645.GA6876@coredump.intra.peff.net","subject":"Re: [PATCH] git-mergetool: de-bashify function declarations","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-03-30T04:03:12Z","receivedAt":"2007-03-30T04:03:12Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Mar 29, 2007 at 11:26:45PM -0400, Jeff King wrote:\n\n>  # Returns true if the mode reflects a symlink\n> -function is_symlink () {\n> +is_symlink () {\n>      test \"$1\" = 120000\n>  }\n\nOops, looks like Ted already fixed this, but it just hasn't been pulled\nyet. Sorry for the noise.\n\n-Peff\n"}]}