{"thread":{"id":"7430","subject":"[PATCH] Fix type confusion in pkt-line","startedAt":"2007-03-27T10:54:07Z","lastAt":"2007-03-27T10:54:07Z","messageCount":1,"participants":["rogan@dawes.za.net"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38142","messageId":"1174992847659-git-send-email-rogan@dawes.za.net","threadId":"7430","inReplyTo":null,"subject":"[PATCH] Fix type confusion in pkt-line","fromName":"","fromEmail":"rogan@dawes.za.net","sentAt":"2007-03-27T10:54:07Z","receivedAt":"2007-03-27T10:54:07Z","isPatch":true,"sender":{"key":"rogan@dawes.za.net","avatar":null},"body":"From: Rogan Dawes <rogan@dawes.za.net>\n\nWe were using unsigend and signed int when we should have been\nusing size_t and ssize_t.\n\nSigned-off-by: Rogan Dawes <rogan@dawes.za.net>\n---\n pkt-line.c |   10 +++++-----\n pkt-line.h |    2 +-\n 2 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/pkt-line.c b/pkt-line.c\nindex b4cb7e2..559a944 100644\n--- a/pkt-line.c\n+++ b/pkt-line.c\n@@ -63,12 +63,12 @@ void packet_write(int fd, const char *fmt, ...)\n \tsafe_write(fd, buffer, n);\n }\n \n-static void safe_read(int fd, void *buffer, unsigned size)\n+static void safe_read(int fd, void *buffer, size_t size)\n {\n-\tint n = 0;\n+\tsize_t n = 0;\n \n \twhile (n < size) {\n-\t\tint ret = xread(fd, (char *) buffer + n, size - n);\n+\t\tssize_t ret = xread(fd, (char *) buffer + n, size - n);\n \t\tif (ret < 0)\n \t\t\tdie(\"read error (%s)\", strerror(errno));\n \t\tif (!ret)\n@@ -77,10 +77,10 @@ static void safe_read(int fd, void *buffer, unsigned size)\n \t}\n }\n \n-int packet_read_line(int fd, char *buffer, unsigned size)\n+ssize_t packet_read_line(int fd, char *buffer, size_t size)\n {\n \tint n;\n-\tunsigned len;\n+\tsize_t len;\n \tchar linelen[4];\n \n \tsafe_read(fd, linelen, 4);\ndiff --git a/pkt-line.h b/pkt-line.h\nindex 9df653f..073fcd4 100644\n--- a/pkt-line.h\n+++ b/pkt-line.h\n@@ -9,7 +9,7 @@\n void packet_flush(int fd);\n void packet_write(int fd, const char *fmt, ...) __attribute__((format (printf, 2, 3)));\n \n-int packet_read_line(int fd, char *buffer, unsigned size);\n+ssize_t packet_read_line(int fd, char *buffer, size_t size);\n ssize_t safe_write(int, const void *, ssize_t);\n \n #endif\n-- \n1.5.0.3\n"}]}