{"thread":{"id":"7419","subject":"[PATCH] gitweb: Cleanup and uniquify die_error calls","startedAt":"2007-03-27T00:07:11Z","lastAt":"2007-03-27T00:07:11Z","messageCount":1,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38091","messageId":"11749540314189-git-send-email-jnareb@gmail.com","threadId":"7419","inReplyTo":null,"subject":"[PATCH] gitweb: Cleanup and uniquify die_error calls","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-03-27T00:07:11Z","receivedAt":"2007-03-27T00:07:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c79bfeb..3786955 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3154,7 +3154,7 @@ sub git_blame2 {\n \t}\n \t$ftype = git_get_type($hash);\n \tif ($ftype !~ \"blob\") {\n-\t\tdie_error(\"400 Bad Request\", \"Object is not a blob\");\n+\t\tdie_error('400 Bad Request', \"Object is not a blob\");\n \t}\n \topen ($fd, \"-|\", git_cmd(), \"blame\", '-p', '--',\n \t      $file_name, $hash_base)\n@@ -3220,7 +3220,7 @@ HTML\n \t\t\tprint \"</td>\\n\";\n \t\t}\n \t\topen (my $dd, \"-|\", git_cmd(), \"rev-parse\", \"$full_rev^\")\n-\t\t\tor die_error(\"could not open git-rev-parse\");\n+\t\t\tor die_error(undef, \"Open git-rev-parse failed\");\n \t\tmy $parent_commit = <$dd>;\n \t\tclose $dd;\n \t\tchomp($parent_commit);\n@@ -3622,7 +3622,7 @@ sub git_snapshot {\n \t$name =~ s/\\047/\\047\\\\\\047\\047/g;\n \topen my $fd, \"-|\",\n \t\"$git archive --format=tar --prefix=\\'$name\\'/ $hash | $command\"\n-\t\tor die_error(undef, \"Execute git-tar-tree failed.\");\n+\t\tor die_error(undef, \"Execute git-tar-tree failed\");\n \tbinmode STDOUT, ':raw';\n \tprint <$fd>;\n \tbinmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi\n-- \n1.5.0.5\n"}]}