{"thread":{"id":"7402","subject":"[PATCH] pager: default to LESS=FRX not LESS=FRSX","startedAt":"2007-03-26T07:35:02Z","lastAt":"2007-03-27T06:54:19Z","messageCount":11,"participants":["Eygene Ryabinkin","Junio C Hamano","Shawn O. Pearce","Jeff King","Bill Lear"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"37999","messageId":"20070326073502.GD44578@codelabs.ru","threadId":"7402","inReplyTo":null,"subject":"[PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Eygene Ryabinkin","fromEmail":"rea-git@codelabs.ru","sentAt":"2007-03-26T07:35:02Z","receivedAt":"2007-03-26T07:35:02Z","isPatch":true,"sender":{"key":"rea-git@codelabs.ru","avatar":null},"body":"Remove unnecessary '-S' option that enabled less to chop long lines.\nIt used to provide some confusion at least for the 'git diff':\n\"Where are my long lines? Are they missed from the patch?\".\n\nSigned-off-by: Eygene Ryabinkin \n---\n pager.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/pager.c b/pager.c\nindex 5f280ab..2dca00e 100644\n--- a/pager.c\n+++ b/pager.c\n@@ -62,7 +62,7 @@ void setup_pager(void)\n \tclose(fd[0]);\n \tclose(fd[1]);\n \n-\tsetenv(\"LESS\", \"FRSX\", 0);\n+\tsetenv(\"LESS\", \"FRX\", 0);\n \trun_pager(pager);\n \tdie(\"unable to execute pager '%s'\", pager);\n \texit(255);\n-- \n1.5.0.3-dirty\n"},{"id":"38009","messageId":"7vwt14xvaw.fsf@assigned-by-dhcp.cox.net","threadId":"7402","inReplyTo":"20070326073502.GD44578@codelabs.ru","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-26T08:28:55Z","receivedAt":"2007-03-26T08:28:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eygene Ryabinkin writes:\n\n> Remove unnecessary '-S' option that enabled less to chop long lines.\n> It used to provide some confusion at least for the 'git diff':\n> \"Where are my long lines? Are they missed from the patch?\".\n\nIt is not \"unnecessary\", but only \"what _you_ are not used to\".\nAs this breaks expectentions of people already familiar with\nwhat git does by default, I cannot take this patch.\n"},{"id":"38011","messageId":"20070326083617.GG13247@spearce.org","threadId":"7402","inReplyTo":"7vwt14xvaw.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-03-26T08:36:17Z","receivedAt":"2007-03-26T08:36:17Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano wrote:\n> Eygene Ryabinkin writes:\n> \n> > Remove unnecessary '-S' option that enabled less to chop long lines.\n> > It used to provide some confusion at least for the 'git diff':\n> > \"Where are my long lines? Are they missed from the patch?\".\n> \n> It is not \"unnecessary\", but only \"what _you_ are not used to\".\n> As this breaks expectentions of people already familiar with\n> what git does by default, I cannot take this patch.\n\nHear hear. I completely agree with Junio. I (and a number of\nother users that I work with) expect this behevaior by default.\n\n-- \nShawn.\n"},{"id":"38013","messageId":"7v8xdkxukt.fsf@assigned-by-dhcp.cox.net","threadId":"7402","inReplyTo":"20070326083617.GG13247@spearce.org","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-26T08:44:34Z","receivedAt":"2007-03-26T08:44:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> Junio C Hamano wrote:\n>> Eygene Ryabinkin writes:\n>> \n>> > Remove unnecessary '-S' option that enabled less to chop long lines.\n>> > It used to provide some confusion at least for the 'git diff':\n>> > \"Where are my long lines? Are they missed from the patch?\".\n>> \n>> It is not \"unnecessary\", but only \"what _you_ are not used to\".\n>> As this breaks expectentions of people already familiar with\n>> what git does by default, I cannot take this patch.\n>\n> Hear hear. I completely agree with Junio. I (and a number of\n> other users that I work with) expect this behevaior by default.\n\nTwo tips.\n\n (1) Learn to use left/right arrow keys under \"less -S\" if you\n have occasional lines that are too long.\n\n (2) Do not have too many too long lines to begin with. If you\n cannot comfortably read your code with \"less -S\", your\n nesting is too deep to be understood with or without line\n folding.\n"},{"id":"38024","messageId":"20070326100857.GW14837@codelabs.ru","threadId":"7402","inReplyTo":"7v8xdkxukt.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Eygene Ryabinkin","fromEmail":"rea-git@codelabs.ru","sentAt":"2007-03-26T10:08:57Z","receivedAt":"2007-03-26T10:08:57Z","isPatch":true,"sender":{"key":"rea-git@codelabs.ru","avatar":null},"body":"Junio,\n\nMon, Mar 26, 2007 at 01:44:34AM -0700, Junio C Hamano wrote:\n> > Junio C Hamano wrote:\n> >> Eygene Ryabinkin writes:\n> >> \n> >> > Remove unnecessary '-S' option that enabled less to chop long lines.\n> >> > It used to provide some confusion at least for the 'git diff':\n> >> > \"Where are my long lines? Are they missed from the patch?\".\n> >> \n> >> It is not \"unnecessary\", but only \"what _you_ are not used to\".\n> >> As this breaks expectentions of people already familiar with\n> >> what git does by default, I cannot take this patch.\n\nOK, no problem.\n\n> > Hear hear. I completely agree with Junio. I (and a number of\n> > other users that I work with) expect this behevaior by default.\n> \n> Two tips.\n> \n> (1) Learn to use left/right arrow keys under \"less -S\" if you\n> have occasional lines that are too long.\n\nI do not like the left/right keys: it is wery hard to get the\nright typing speed if we're using the arrow keys. But it is just\nmy habit since I learned to 10 fingers typing.\n\n> (2) Do not have too many too long lines to begin with. If you\n> cannot comfortably read your code with \"less -S\", your\n> nesting is too deep to be understood with or without line\n> folding.\n\nYes, yes, \"if you need more than 4 levels of identation then your\ncode is probably in a bad shape\". I know it. But the problem was that\nI noticed this behaviour when I was patching the Git sources and there\nwere some removed lines that were long enough not to fit to the screen\nwith the addition of the '- ' diff tags.\n-- \nEygene\n"},{"id":"38053","messageId":"7vlkhjx2rd.fsf@assigned-by-dhcp.cox.net","threadId":"7402","inReplyTo":"20070326100857.GW14837@codelabs.ru","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-26T18:45:26Z","receivedAt":"2007-03-26T18:45:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eygene Ryabinkin writes:\n\n>> Two tips.\n>> \n>> (1) Learn to use left/right arrow keys under \"less -S\" if you\n>> have occasional lines that are too long.\n>\n> I do not like the left/right keys: it is wery hard to get the\n> right typing speed ...\n\nHeh, who types 120-word a minute while perusing the source with\n\"less\"?\n\nI do not like to move my hand from the home position on the\nkeyboard either, so I never touch arrow keys while I am typing\nto produce, but I never thought of bothering to reconfigure less\nkeybindings for the reason you stated, as I do not have infinite\namount of time.\n"},{"id":"38055","messageId":"20070326190304.GB31844@coredump.intra.peff.net","threadId":"7402","inReplyTo":"20070326100857.GW14837@codelabs.ru","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-03-26T19:03:04Z","receivedAt":"2007-03-26T19:03:04Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Mar 26, 2007 at 02:08:57PM +0400, Eygene Ryabinkin wrote:\n\n> I do not like the left/right keys: it is wery hard to get the\n> right typing speed if we're using the arrow keys. But it is just\n> my habit since I learned to 10 fingers typing.\n\nYou might try:\n\ncat >>$HOME/.lesskey <<'EOF'\nh left-scroll\nl right-scroll\nEOF\nlesskey\n\n-Peff\n"},{"id":"38056","messageId":"17928.7076.871485.136142@lisa.zopyra.com","threadId":"7402","inReplyTo":"7v8xdkxukt.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Bill Lear","fromEmail":"rael@zopyra.com","sentAt":"2007-03-26T19:14:44Z","receivedAt":"2007-03-26T19:14:44Z","isPatch":true,"sender":{"key":"rael@zopyra.com","avatar":"https://gravatar.com/avatar/c4f2d2790ca3828d3b4e7dfebabf61d2fe94fd82fa49cdac2a5295dd2d46a874?d=mp&s=160"},"body":"On Monday, March 26, 2007 at 01:44:34 (-0700) Junio C Hamano writes:\n>\"Shawn O. Pearce\" writes:\n>\n>> Junio C Hamano wrote:\n>>> Eygene Ryabinkin writes:\n>>> \n>>> > Remove unnecessary '-S' option that enabled less to chop long lines.\n>>> > It used to provide some confusion at least for the 'git diff':\n>>> > \"Where are my long lines? Are they missed from the patch?\".\n>>> \n>>> It is not \"unnecessary\", but only \"what _you_ are not used to\".\n>>> As this breaks expectentions of people already familiar with\n>>> what git does by default, I cannot take this patch.\n>>\n>> Hear hear. I completely agree with Junio. I (and a number of\n>> other users that I work with) expect this behevaior by default.\n>\n>Two tips.\n>\n> (1) Learn to use left/right arrow keys under \"less -S\" if you\n> have occasional lines that are too long.\n\nHmm, looking at the code: why, if the environment variable LESS is\nalready set, should this all be worth talking about? Shouldn't the\nuser be able to set LESS to whatever they want, once, and be done with\nit? The current setenv() call to set up the pager does this, correct?\n\n\nBill\n"},{"id":"38059","messageId":"7vd52vwy1o.fsf@assigned-by-dhcp.cox.net","threadId":"7402","inReplyTo":"17928.7076.871485.136142@lisa.zopyra.com","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-26T20:27:15Z","receivedAt":"2007-03-26T20:27:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bill Lear writes:\n\n> On Monday, March 26, 2007 at 01:44:34 (-0700) Junio C Hamano writes:\n>>\"Shawn O. Pearce\" writes:\n>>\n>>> Junio C Hamano wrote:\n>>>> Eygene Ryabinkin writes:\n>>>> \n>>>> > Remove unnecessary '-S' option that enabled less to chop long lines.\n>>>> > It used to provide some confusion at least for the 'git diff':\n>>>> > \"Where are my long lines? Are they missed from the patch?\".\n>>>> \n>>>> It is not \"unnecessary\", but only \"what _you_ are not used to\".\n>>>> As this breaks expectentions of people already familiar with\n>>>> what git does by default, I cannot take this patch.\n>>>\n>>> Hear hear. I completely agree with Junio. I (and a number of\n>>> other users that I work with) expect this behevaior by default.\n>>\n>>Two tips.\n>>\n>> (1) Learn to use left/right arrow keys under \"less -S\" if you\n>> have occasional lines that are too long.\n>\n> Hmm, looking at the code: why, if the environment variable LESS is\n> already set, should this all be worth talking about? Shouldn't the\n> user be able to set LESS to whatever they want, once, and be done with\n> it? The current setenv() call to set up the pager does this, correct?\n\nYes. That would make the third tip ;-).\n"},{"id":"38112","messageId":"20070327064759.GA51155@codelabs.ru","threadId":"7402","inReplyTo":"20070326190304.GB31844@coredump.intra.peff.net","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Eygene Ryabinkin","fromEmail":"rea-git@codelabs.ru","sentAt":"2007-03-27T06:47:59Z","receivedAt":"2007-03-27T06:47:59Z","isPatch":true,"sender":{"key":"rea-git@codelabs.ru","avatar":null},"body":"Jeff, good day.\n\nMon, Mar 26, 2007 at 03:03:04PM -0400, Jeff King wrote:\n> On Mon, Mar 26, 2007 at 02:08:57PM +0400, Eygene Ryabinkin wrote:\n> \n> > I do not like the left/right keys: it is wery hard to get the\n> > right typing speed if we're using the arrow keys. But it is just\n> > my habit since I learned to 10 fingers typing.\n> \n> You might try:\n> \n> cat >>$HOME/.lesskey <<'EOF'\n> h left-scroll\n> l right-scroll\n> EOF\n> lesskey\n\nVery good, thanks!\n-- \nEygene\n"},{"id":"38113","messageId":"20070327065419.GB51155@codelabs.ru","threadId":"7402","inReplyTo":"17928.7076.871485.136142@lisa.zopyra.com","subject":"Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX","fromName":"Eygene Ryabinkin","fromEmail":"rea-git@codelabs.ru","sentAt":"2007-03-27T06:54:19Z","receivedAt":"2007-03-27T06:54:19Z","isPatch":true,"sender":{"key":"rea-git@codelabs.ru","avatar":null},"body":"Bill, good day.\n\nMon, Mar 26, 2007 at 01:14:44PM -0600, Bill Lear wrote:\n> > (1) Learn to use left/right arrow keys under \"less -S\" if you\n> > have occasional lines that are too long.\n> \n> Hmm, looking at the code: why, if the environment variable LESS is\n> already set, should this all be worth talking about? Shouldn't the\n> user be able to set LESS to whatever they want, once, and be done with\n> it? The current setenv() call to set up the pager does this, correct?\n\nIf it was named GIT_LESS, then yes, I could set it to the defaults\nthat are sane for me with Git. But I do not like the idea of setting\n-F, -R and -X for all less invocations. But OK, the 'l' and 'h'\nbindings for less movements are fine with me. I do not like scrolling\nvery much (using 14400 modem lines sometimes, so it is a bit slow),\nbut if 'FRSX' are good defaults that people are used to, then I\nshould live with them. Or probably start the git-FRX toolchain ;))\n\nOK, I feel that this thread is exhausted itself, so I am shutting up.\n-- \nEygene\n"}]}