{"thread":{"id":"7361","subject":"Errors pushing tags in \"next\"","startedAt":"2007-03-23T02:03:40Z","lastAt":"2007-03-23T09:43:31Z","messageCount":12,"participants":["Luben Tuikov","Junio C Hamano","Andy Parkins","Marco Roeland"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"37776","messageId":"958071.66875.qm@web31811.mail.mud.yahoo.com","threadId":"7361","inReplyTo":null,"subject":"Errors pushing tags in \"next\"","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-03-23T02:03:40Z","receivedAt":"2007-03-23T02:03:40Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Is this of any concern?\n\n### Pushing version 'v2.6.21-rc4' to the masses\nfatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\nrevision or path not in the working tree.\nUse '--' to separate paths from revisions\nfatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\nrevision or path not in the working tree.\nUse '--' to separate paths from revisions\nrefs/tags/v2.6.21-rc4: 0000000000000000000000000000000000000000 ->\nbac6eefe96204d0ad67d144f2511a6fc487aa594\n\nThanks,\n Luben\n\nP.S.\ngit --version\ngit version 1.5.1.rc1.901.gb7f2\n"},{"id":"37777","messageId":"7vr6rgsmj2.fsf@assigned-by-dhcp.cox.net","threadId":"7361","inReplyTo":"958071.66875.qm@web31811.mail.mud.yahoo.com","subject":"Re: Errors pushing tags in \"next\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-23T02:48:17Z","receivedAt":"2007-03-23T02:48:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n> Is this of any concern?\n\nSorry, I cannot tell without a command line.\n\n> ### Pushing version 'v2.6.21-rc4' to the masses\n> fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\n> revision or path not in the working tree.\n> Use '--' to separate paths from revisions\n> fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\n> revision or path not in the working tree.\n> Use '--' to separate paths from revisions\n> refs/tags/v2.6.21-rc4: 0000000000000000000000000000000000000000 ->\n> bac6eefe96204d0ad67d144f2511a6fc487aa594\n>\n> Thanks,\n> Luben\n>\n> P.S.\n> git --version\n> git version 1.5.1.rc1.901.gb7f2\n"},{"id":"37778","messageId":"483641.20752.qm@web31801.mail.mud.yahoo.com","threadId":"7361","inReplyTo":"7vr6rgsmj2.fsf@assigned-by-dhcp.cox.net","subject":"Re: Errors pushing tags in \"next\"","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-03-23T03:35:55Z","receivedAt":"2007-03-23T03:35:55Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano wrote:\n\n> Luben Tuikov writes:\n> \n> > Is this of any concern?\n> \n> Sorry, I cannot tell without a command line.\n\nSorry, I didn't include that. It is:\n\ngit-push --tags web\n\n Luben\n\n\n> \n> > ### Pushing version 'v2.6.21-rc4' to the masses\n> > fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\n> > revision or path not in the working tree.\n> > Use '--' to separate paths from revisions\n> > fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\n> > revision or path not in the working tree.\n> > Use '--' to separate paths from revisions\n> > refs/tags/v2.6.21-rc4: 0000000000000000000000000000000000000000 ->\n> > bac6eefe96204d0ad67d144f2511a6fc487aa594\n> >\n> > Thanks,\n> > Luben\n> >\n> > P.S.\n> > git --version\n> > git version 1.5.1.rc1.901.gb7f2\n> \n> \n"},{"id":"37781","messageId":"7vmz24sid9.fsf@assigned-by-dhcp.cox.net","threadId":"7361","inReplyTo":"483641.20752.qm@web31801.mail.mud.yahoo.com","subject":"Re: Errors pushing tags in \"next\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-23T04:18:10Z","receivedAt":"2007-03-23T04:18:10Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n> --- Junio C Hamano wrote:\n>\n>> Luben Tuikov writes:\n>> \n>> > Is this of any concern?\n>> \n>> Sorry, I cannot tell without a command line.\n>\n> Sorry, I didn't include that. It is:\n>\n> git-push --tags web\n>\n> Luben\n>> \n>> > ### Pushing version 'v2.6.21-rc4' to the masses\n>> > fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\n>> > revision or path not in the working tree.\n>> > Use '--' to separate paths from revisions\n>> > fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594': unknown\n\nWell, *I* don't say '### Pushing version blah to the masses', so\nit's hard to diagnose from this output. Is it coming from some\nof your own script (perhaps update hook on the receiving end)?\n"},{"id":"37788","messageId":"382665.13897.qm@web31804.mail.mud.yahoo.com","threadId":"7361","inReplyTo":"7vmz24sid9.fsf@assigned-by-dhcp.cox.net","subject":"Re: Errors pushing tags in \"next\"","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-03-23T07:44:49Z","receivedAt":"2007-03-23T07:44:49Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano wrote:\n> Luben Tuikov writes:\n> \n> > --- Junio C Hamano wrote:\n> >\n> >> Luben Tuikov writes:\n> >> \n> >> > Is this of any concern?\n> >> \n> >> Sorry, I cannot tell without a command line.\n> >\n> > Sorry, I didn't include that. It is:\n> >\n> > git-push --tags web\n> >\n> > Luben\n> >> \n> >> > ### Pushing version 'v2.6.21-rc4' to the masses\n> >> > fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594':\n> unknown\n> >> > revision or path not in the working tree.\n> >> > Use '--' to separate paths from revisions\n> >> > fatal: ambiguous argument 'v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594':\n> unknown\n> \n> Well, *I* don't say '### Pushing version blah to the masses', so\n> it's hard to diagnose from this output. Is it coming from some\n> of your own script (perhaps update hook on the receiving end)?\n\nNo, I don't have a script hooked onto git-push.\n\nBTW, git has always said to me \"Pushing version ... to the masses\"\nwhenever I'd do \"git-push --tags web\".\n\nOn the receiving end, I've only the standard git hooks enabled.\nIn fact only \"post-update\" is enabled.\n\n Luben\n\n\n Luben\n"},{"id":"37789","messageId":"7v7it8s7c4.fsf@assigned-by-dhcp.cox.net","threadId":"7361","inReplyTo":"382665.13897.qm@web31804.mail.mud.yahoo.com","subject":"Re: Errors pushing tags in \"next\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-23T08:16:27Z","receivedAt":"2007-03-23T08:16:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n> BTW, git has always said to me \"Pushing version ... to the masses\"\n> whenever I'd do \"git-push --tags web\".\n\nSorry, I must be blind, and git-grep is too.\n\n$ git grep -e 'to the masses' -e 'Pushing v'\n\nreturns absolutely empty.\n\nPuzzled...\n"},{"id":"37796","messageId":"20070323090213.GA7186@fiberbit.xs4all.nl","threadId":"7361","inReplyTo":"7v7it8s7c4.fsf@assigned-by-dhcp.cox.net","subject":"Re: Errors pushing tags in \"next\"","fromName":"Marco Roeland","fromEmail":"marco.roeland@xs4all.nl","sentAt":"2007-03-23T09:02:13Z","receivedAt":"2007-03-23T09:02:13Z","isPatch":false,"sender":{"key":"marco.roeland@xs4all.nl","avatar":null},"body":"On Friday March 23rd 2007 at 01:16 Junio C Hamano wrote:\n\n> Luben Tuikov writes:\n> \n> > BTW, git has always said to me \"Pushing version ... to the masses\"\n> > whenever I'd do \"git-push --tags web\".\n> \n> Sorry, I must be blind, and git-grep is too.\n> \n> $ git grep -e 'to the masses' -e 'Pushing v'\n> \n> returns absolutely empty.\n\nThe line comes from an older version of templates/hooks--update. The\nline was removed in commit 829a686f1b50ba96cac2d88494fa339efe0c0862 .\n\nSo Luben does seem to have a hook installed, perhaps this is the\nculprit.\n-- \nMarco Roeland\n"},{"id":"37793","messageId":"200703230913.12742.andyparkins@gmail.com","threadId":"7361","inReplyTo":"7v7it8s7c4.fsf@assigned-by-dhcp.cox.net","subject":"Re: Errors pushing tags in \"next\"","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-03-23T09:13:10Z","receivedAt":"2007-03-23T09:13:10Z","isPatch":false,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Friday 2007 March 23 08:16, Junio C Hamano wrote:\n\n> $ git grep -e 'to the masses' -e 'Pushing v'\n>\n> returns absolutely empty.\n\nAs Doc Brown once said: \"That's because you're not thinking four \ndimensionally\" ;-)\n\n git-show v1.4.4:templates/hooks--update | grep masses\n\nLuben: that message is being generated by the remote version of git rather \nthan your local version. It doesn't matter that /you/ don't have any hook \nscripts enabled, what matters is that the remote repository has them enabled. \nIn particular the hooks/update script has been enabled.\n\nThe output you show is from the update hook from an older version of git, but \nthe git you're running on the remote end is a newer version. The hook \nscripts don't get updated when you upgrade git because they're copied to the \nrepository from the latest template when you clone or init.\n\nNow: onto the fault; this same fault was fixed in the sample hook in revision \na2ee81bb7594b; the problem is that the older update hook used to split the \noutput of git-describe on the last dash and made the assumption that \neverything before the dash was a tag name. git-describe gained a nice new \nfeature were it would show the number of revisions since that tag as well. \nSo now the output of git-describe is\n\n tag-N-revision\n\nSo you can see that splitting on the last dash would return \"tag-N\" rather \nthan \"tag\". Now, when the update hook uses this \"tag-N\" as if it were a tag, \ngit obviously doesn't find it, so you're fatal error is coming from running \nsomething like:\n\n git-rev-list v2.6.21-rc3-329..bac6eefe96204d0ad67d144f2511a6fc487aa594\n\nbecuase \"v2.6.21-rc3-329\" is not a tag.\n\nThe fix: My own suggestion would be to just swap the update hook on the \nserver for the one that came with the latest version of git (although I'm \ncompletely biased :-)). Remember to do this on the remote repository, not \nyour local one. Alternatively you could fix just that bug in the hook script \nyou have to leave things as close as possible to what you've got now, by \nediting .git/hooks/update and making this change:\n\n- prev=$(git describe \"$3^\" | sed 's/-g.*//')\n+ prev=$(git describe --abbrev=0 \"$3^\")\n\nAlternatively; I've got a further update to the notification email script \nprepared that I'm finishing testing and will send today that updates to use \nthe post-receive hook rather than the update hook and fixes a number of bugs.\n\n\nAndy\n-- \nDr Andy Parkins, M Eng (hons), MIET\nandyparkins@gmail.com\n"},{"id":"37794","messageId":"7vps70qpx8.fsf@assigned-by-dhcp.cox.net","threadId":"7361","inReplyTo":"20070323090213.GA7186@fiberbit.xs4all.nl","subject":"Re: Errors pushing tags in \"next\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-23T09:17:55Z","receivedAt":"2007-03-23T09:17:55Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Marco Roeland writes:\n\n>> Luben Tuikov writes:\n>> \n>> > BTW, git has always said to me \"Pushing version ... to the masses\"\n>> > whenever I'd do \"git-push --tags web\".\n>> \n>> Sorry, I must be blind, and git-grep is too.\n>> \n>> $ git grep -e 'to the masses' -e 'Pushing v'\n>> \n>> returns absolutely empty.\n>\n> The line comes from an older version of templates/hooks--update. The\n> line was removed in commit 829a686f1b50ba96cac2d88494fa339efe0c0862 .\n>\n> So Luben does seem to have a hook installed, perhaps this is the\n> culprit.\n\nThanks for spotting this. I do not use this hook (well, I only\nuse commit-msg, pre-commit, and pre-rebase patches) and it was\ntotally outside of my radar.\n\nIt runs describe to find the previous tag, but the parser is a\nbit old fashioned. It says:\n\n\tprev=$(git describe \"$3^\" | sed 's/-g.*//')\n\nbut modern way to say the same is:\n\n\tprev=$(git describe --abbrev=0 \"$3^\")\n\nLuben, sorry for the trouble.\n\nI do not know how much better the recent hooks--update is\ncompared to the version you use. It is supposed to be backward\ncompatible, so you _might_ want to simply update it with the one\nfrom 'master' after checking if it suits your needs. Otherwise,\nI think the above one-liner should work the problem around.\n"},{"id":"37795","messageId":"803772.83961.qm@web31809.mail.mud.yahoo.com","threadId":"7361","inReplyTo":"20070323090213.GA7186@fiberbit.xs4all.nl","subject":"Re: Errors pushing tags in \"next\"","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-03-23T09:19:52Z","receivedAt":"2007-03-23T09:19:52Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Marco Roeland wrote:\n> On Friday March 23rd 2007 at 01:16 Junio C Hamano wrote:\n> \n> > Luben Tuikov writes:\n> > \n> > > BTW, git has always said to me \"Pushing version ... to the masses\"\n> > > whenever I'd do \"git-push --tags web\".\n> > \n> > Sorry, I must be blind, and git-grep is too.\n> > \n> > $ git grep -e 'to the masses' -e 'Pushing v'\n> > \n> > returns absolutely empty.\n> \n> The line comes from an older version of templates/hooks--update. The\n> line was removed in commit 829a686f1b50ba96cac2d88494fa339efe0c0862 .\n> \n> So Luben does seem to have a hook installed, perhaps this is the\n> culprit.\n\nI see.\n\nI double checked and I do have \"update\" and \"post-update\" hooks\nenabled. I don't think that it is \"post-update\" and this leaves\n\"update\" to be the problem (which is from an ancient git version\nwhen the repo was created...).\n\nI'll update the \"update\" hook from a recent git version and\nwill see if I get the same warning message. Hopefully not.\n\nThanks,\n Luben\n"},{"id":"37798","messageId":"409322.88629.qm@web31809.mail.mud.yahoo.com","threadId":"7361","inReplyTo":"200703230913.12742.andyparkins@gmail.com","subject":"Re: Errors pushing tags in \"next\"","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-03-23T09:38:41Z","receivedAt":"2007-03-23T09:38:41Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Andy Parkins wrote:\n> The output you show is from the update hook from an older version of git, but \n> the git you're running on the remote end is a newer version. The hook \n> scripts don't get updated when you upgrade git because they're copied to the \n> repository from the latest template when you clone or init.\n\nYeah, most of my git repos, especially the web exported ones are\ntruly of an ancient git...\n\n> The fix: My own suggestion would be to just swap the update hook on the \n> server for the one that came with the latest version of git (although I'm \n> completely biased :-)). Remember to do this on the remote repository, not \n> your local one.\n\nYeah, I'll cp(1) the most recent \"update\" hook I got in \"next\" to the\nancient web exported repos I own...\n\n> Alternatively; I've got a further update to the notification email script \n> prepared that I'm finishing testing and will send today that updates to use \n> the post-receive hook rather than the update hook and fixes a number of bugs.\n\nOk, sounds good.\n\nThanks,\n Luben\n"},{"id":"37799","messageId":"884930.67488.qm@web31803.mail.mud.yahoo.com","threadId":"7361","inReplyTo":"7vps70qpx8.fsf@assigned-by-dhcp.cox.net","subject":"Re: Errors pushing tags in \"next\"","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-03-23T09:43:31Z","receivedAt":"2007-03-23T09:43:31Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano wrote:\n> > So Luben does seem to have a hook installed, perhaps this is the\n> > culprit.\n> \n> Thanks for spotting this. I do not use this hook (well, I only\n> use commit-msg, pre-commit, and pre-rebase patches) and it was\n> totally outside of my radar.\n> \n> It runs describe to find the previous tag, but the parser is a\n> bit old fashioned. It says:\n> \n> \tprev=$(git describe \"$3^\" | sed 's/-g.*//')\n> \n> but modern way to say the same is:\n> \n> \tprev=$(git describe --abbrev=0 \"$3^\")\n> \n> Luben, sorry for the trouble.\n> \n> I do not know how much better the recent hooks--update is\n> compared to the version you use. It is supposed to be backward\n> compatible, so you _might_ want to simply update it with the one\n> from 'master' after checking if it suits your needs. Otherwise,\n> I think the above one-liner should work the problem around.\n\nYeah, that's what Andy suggested too.\n\nI guess the problem is that my git repos, especially the web\nexported ones are truly of an ancient git...\n\nI'll just update the \"update\" hook from the most recent \"next\"\nI've got and see if I get this again.\n\nThanks,\n Luben\n"}]}