{"thread":{"id":"736","subject":"Re: ALSA official git repository","startedAt":"2005-05-27T16:13:02Z","lastAt":"2005-05-29T09:06:32Z","messageCount":15,"participants":["Linus Torvalds","Sean","Jaroslav Kysela","Junio C Hamano","Andrew Morton","Jesper Juhl","Schneelocke","Chris Wedgwood"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"4049","messageId":"Pine.LNX.4.58.0505270903230.17402@ppc970.osdl.org","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505271741490.1757@pnote.perex-int.cz","subject":"Re: ALSA official git repository","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-27T16:13:02Z","receivedAt":"2005-05-27T16:13:02Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 27 May 2005, Jaroslav Kysela wrote:\n> \n> \tI created new git tree for the ALSA project at:\n> \n> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git\n\nYour scripts(?) to generate these things are a bit strange, since they\nleave an extra empty line in the commit message, which confuses at least\ngitweb (ie just look at\n\n http://www.kernel.org/git/?p=linux/kernel/git/perex/alsa.git;a=summary\n\nand note how the summary thing looks empty).\n\nNow, arguably gitweb should ignore whitespace at the beginning, but \nequally arguably your commits shouldn't have them either...\n\n\t\tLinus\n\n"},{"id":"4054","messageId":"3516.10.10.10.24.1117213207.squirrel@linux1","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505270903230.17402@ppc970.osdl.org","subject":"Re: ALSA official git repository","fromName":"Sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2005-05-27T17:00:07Z","receivedAt":"2005-05-27T17:00:07Z","isPatch":false,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"On Fri, May 27, 2005 12:13 pm, Linus Torvalds said:\n> On Fri, 27 May 2005, Jaroslav Kysela wrote:\n>>\n>> \tI created new git tree for the ALSA project at:\n>>\n>> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git\n>\n> Your scripts(?) to generate these things are a bit strange, since they\n> leave an extra empty line in the commit message, which confuses at least\n> gitweb (ie just look at\n>\n> http://www.kernel.org/git/?p=linux/kernel/git/perex/alsa.git;a=summary\n>\n> and note how the summary thing looks empty).\n>\n> Now, arguably gitweb should ignore whitespace at the beginning, but\n> equally arguably your commits shouldn't have them either...\n>\n\nPerhaps git should enforce this? Patch attached.\n\n\nRemove leading empty lines from commit messages.\n\nSigned-off-by: Sean Estabrooks \n\n\n\n--- raw/commit-tree.c\t2005-05-26 23:38:30.000000000 -0400\n+++ argp2/commit-tree.c\t2005-05-27 12:46:54.000000000 -0400\n@@ -90,6 +90,18 @@\n \tfree(buf);\n }\n \n+static int whitespace(const char *msg) \n+{\n+\twhile (*msg) \n+\t\tswitch (*msg) {\n+\t\tcase ' ': case '\\t': case '\\n': case '\\r':\n+\t\t\tmsg++; break;\n+\t\tdefault:\n+\t\t\treturn 0;\n+\t\t}\n+\treturn 1;\n+}\n+\n /*\n * Having more than two parents is not strange at all, and this is\n * how multi-way merges are represented.\n@@ -112,7 +124,7 @@\n \tchar comment[1000];\n \tstruct passwd *pw;\n \tchar *buffer;\n-\tunsigned int size;\n+\tunsigned int size, csize;\n \n \tif (argc < 2 || get_sha1_hex(argv[1], tree_sha1) < 0)\n \t\tusage(commit_tree_usage);\n@@ -174,8 +186,10 @@\n \tadd_buffer(&buffer, &size, \"committer %s <%s> %s\\n\\n\", commitgecos, commitemail, realdate);\n \n \t/* And add the comment */\n+\tcsize = size;\n \twhile (fgets(comment, sizeof(comment), stdin) != NULL)\n-\t\tadd_buffer(&buffer, &size, \"%s\", comment);\n+\t\tif (size > csize || ! whitespace(comment))\n+\t\t\tadd_buffer(&buffer, &size, \"%s\", comment);\n \n \twrite_sha1_file(buffer, size, \"commit\", commit_sha1);\n \tprintf(\"%s\\n\", sha1_to_hex(commit_sha1));"},{"id":"4057","messageId":"Pine.LNX.4.58.0505271026020.17402@ppc970.osdl.org","threadId":"736","inReplyTo":"3516.10.10.10.24.1117213207.squirrel@linux1","subject":"Re: ALSA official git repository","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-27T17:28:44Z","receivedAt":"2005-05-27T17:28:44Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 27 May 2005, Sean wrote:\n> >\n> > Now, arguably gitweb should ignore whitespace at the beginning, but\n> > equally arguably your commits shouldn't have them either...\n> \n> Perhaps git should enforce this? Patch attached.\n> \n> Remove leading empty lines from commit messages.\n> \n> Signed-off-by: Sean Estabrooks \n\nI'm not sure.\n\nThe thing is, right now git allows binary commit messages if somebody\nreally wants to. Now, a lot of the _tools_ end up only printing up to the\nfirst '\\0' or something, but in general, maybe somebody actually wants to\nembed his own strange stuff in there (eg use encryption but still use\nstandard git tools).\n\nWhich makes me worry. So I _do_ do whitespace cleanup in my \"apply email \npatches\" scripts, but I'm not sure whether the core should care about the \ndata that people feed it, even for commit messages.\n\nOpinions?\n\n\t\tLinus\n"},{"id":"4061","messageId":"Pine.LNX.4.58.0505271941250.1757@pnote.perex-int.cz","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505270903230.17402@ppc970.osdl.org","subject":"Re: ALSA official git repository","fromName":"Jaroslav Kysela","fromEmail":"perex@suse.cz","sentAt":"2005-05-27T17:43:44Z","receivedAt":"2005-05-27T17:43:44Z","isPatch":false,"sender":{"key":"perex@suse.cz","avatar":null},"body":"On Fri, 27 May 2005, Linus Torvalds wrote:\n\n> On Fri, 27 May 2005, Jaroslav Kysela wrote:\n> > \n> > \tI created new git tree for the ALSA project at:\n> > \n> > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git\n> \n> Your scripts(?) to generate these things are a bit strange, since they\n> leave an extra empty line in the commit message, which confuses at least\n> gitweb (ie just look at\n> \n> http://www.kernel.org/git/?p=linux/kernel/git/perex/alsa.git;a=summary\n> \n> and note how the summary thing looks empty).\n\nOkay, sorry for this small bug. I'll recreate the ALSA git tree with\nproper comments again. Also, the author is not correct (should be taken\nfrom the first Signed-off-by:).\n\n\t\t\t\t\t\tJaroslav\n\n-----\nJaroslav Kysela \nLinux Kernel Sound Maintainer\nALSA Project, SUSE Labs\n"},{"id":"4064","messageId":"Pine.LNX.4.58.0505271113410.17402@ppc970.osdl.org","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505271941250.1757@pnote.perex-int.cz","subject":"Re: ALSA official git repository","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-27T18:16:44Z","receivedAt":"2005-05-27T18:16:44Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 27 May 2005, Jaroslav Kysela wrote:\n> \n> Okay, sorry for this small bug. I'll recreate the ALSA git tree with\n> proper comments again. Also, the author is not correct (should be taken\n> from the first Signed-off-by:).\n\nHmm.. That's not always true in general, since Sign-off does allow to sign\noff on other peoples patches (see the \"(b)\" clause in DCO), but maybe in\nthe ALSA tree it is.\n\nAre you coming from a CVS tree or what? It's clearly not my patch \napplicator thing, since that one removes spaces, I'm pretty sure.\n\n\t\tLinus\n"},{"id":"4068","messageId":"7vvf54y092.fsf@assigned-by-dhcp.cox.net","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505271026020.17402@ppc970.osdl.org","subject":"Re: ALSA official git repository","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-27T18:47:21Z","receivedAt":"2005-05-27T18:47:21Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":">>>>> \"LT\" == Linus Torvalds writes:\n\nLT> On Fri, 27 May 2005, Sean wrote:\n>> >\n>> > Now, arguably gitweb should ignore whitespace at the beginning, but\n>> > equally arguably your commits shouldn't have them either...\n>> \n>> Perhaps git should enforce this? Patch attached.\n>> \n>> Remove leading empty lines from commit messages.\n>> \n>> Signed-off-by: Sean Estabrooks \n\nLT> I'm not sure.\nLT> Opinions?\n\nPorcelains and gitweb should play with each other nicely, but\nthe core should _not_ care by default.\n\nAn extra option (\"--text\", perhaps) to git-commit-tree is\nacceptable to me, and it may be even a good thing to have. It\nwould make life a bit easiear for Porcelain writers if nothing\nelse. If that is to happen, I would say we could do more than\njust leading blank line removal. We can also remove trailing\nblanks before each LF, tabify indented log message contents, and\nremove empty lines before EOF.\n\n"},{"id":"4087","messageId":"20050527135124.0d98c33e.akpm@osdl.org","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505271113410.17402@ppc970.osdl.org","subject":"Re: ALSA official git repository","fromName":"Andrew Morton","fromEmail":"akpm@osdl.org","sentAt":"2005-05-27T20:51:24Z","receivedAt":"2005-05-27T20:51:24Z","isPatch":false,"sender":{"key":"akpm@osdl.org","avatar":null},"body":"Linus Torvalds wrote:\n>\n> \n> \n> On Fri, 27 May 2005, Jaroslav Kysela wrote:\n> > \n> > Okay, sorry for this small bug. I'll recreate the ALSA git tree with\n> > proper comments again. Also, the author is not correct (should be taken\n> > from the first Signed-off-by:).\n> \n> Hmm.. That's not always true in general, since Sign-off does allow to sign\n> off on other peoples patches (see the \"(b)\" clause in DCO), but maybe in\n> the ALSA tree it is.\n\nYes, I'll occasionally do patches which were written by \"A\" as:\n\nFrom: A\n...\nSigned-off-by: B\n\nAnd that comes through email as:\n\n\n...\nFrom: \n...\nFrom: A\n...\nSigned-off-by: B\n\n\nwhich means that the algorithm for identifying the author is \"the final\nFrom:\".\n\nI guess the bug here is the use of From: to identify the primary author,\nbecause transporting the patch via email adds ambiguity.\n\nMaybe we should introduce \"^Author:\"?\n\n"},{"id":"4088","messageId":"7vekbswfo1.fsf@assigned-by-dhcp.cox.net","threadId":"736","inReplyTo":"20050527135124.0d98c33e.akpm@osdl.org","subject":"Re: ALSA official git repository","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-27T20:57:18Z","receivedAt":"2005-05-27T20:57:18Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":">>>>> \"AM\" == Andrew Morton writes:\n\nAM> I guess the bug here is the use of From: to identify the primary author,\nAM> because transporting the patch via email adds ambiguity.\n\nAM> Maybe we should introduce \"^Author:\"?\n\nWhile we are at it, we probably would want \"^Author-Date:\" as\nwell.\n"},{"id":"4089","messageId":"Pine.LNX.4.62.0505272313450.2400@dragon.hyggekrogen.localhost","threadId":"736","inReplyTo":"20050527135124.0d98c33e.akpm@osdl.org","subject":"Re: ALSA official git repository","fromName":"Jesper Juhl","fromEmail":"juhl-lkml@dif.dk","sentAt":"2005-05-27T21:18:12Z","receivedAt":"2005-05-27T21:18:12Z","isPatch":false,"sender":{"key":"juhl-lkml@dif.dk","avatar":null},"body":"On Fri, 27 May 2005, Andrew Morton wrote:\n\n> Linus Torvalds wrote:\n> >\n> > \n> > \n> > On Fri, 27 May 2005, Jaroslav Kysela wrote:\n> > > \n> > > Okay, sorry for this small bug. I'll recreate the ALSA git tree with\n> > > proper comments again. Also, the author is not correct (should be taken\n> > > from the first Signed-off-by:).\n> > \n> > Hmm.. That's not always true in general, since Sign-off does allow to sign\n> > off on other peoples patches (see the \"(b)\" clause in DCO), but maybe in\n> > the ALSA tree it is.\n> \n> Yes, I'll occasionally do patches which were written by \"A\" as:\n> \n> From: A\n> ...\n> Signed-off-by: B\n> \n> And that comes through email as:\n> \n> \n> ...\n> From: \n> ...\n> From: A\n> ...\n> Signed-off-by: B\n> \n> \n> which means that the algorithm for identifying the author is \"the final\n> From:\".\n> \n> I guess the bug here is the use of From: to identify the primary author,\n> because transporting the patch via email adds ambiguity.\n> \n> Maybe we should introduce \"^Author:\"?\n> \n\nThat might be good. I honestly don't know what would be the best \nsolution, but what happens often at the moment is that patches get passed \non as \"From\" whatever maintainer (or random resender) happened to pass it \non to Andrew/Linus and that person then effectively gets labeled as the \nauthor of the patch in the changelogs/git/whatever. That's not perfect...\n\nAuthor: might solve it.. worth a shot if you ask me.. \n\n\n-- \nJesper Juhl\n\n\n"},{"id":"4091","messageId":"d4dc44d505052714193e2c1d1@mail.gmail.com","threadId":"736","inReplyTo":"20050527135124.0d98c33e.akpm@osdl.org","subject":"Re: ALSA official git repository","fromName":"Schneelocke","fromEmail":"schneelocke@gmail.com","sentAt":"2005-05-27T21:19:13Z","receivedAt":"2005-05-27T21:19:13Z","isPatch":false,"sender":{"key":"schneelocke@gmail.com","avatar":null},"body":"On 27/05/05, Andrew Morton wrote:\n> Yes, I'll occasionally do patches which were written by \"A\" as:\n> \n> From: A\n> ...\n> Signed-off-by: B\n> \n> And that comes through email as:\n> \n> ...\n> From: \n> ...\n> From: A\n> ...\n> Signed-off-by: B\n> \n> which means that the algorithm for identifying the author is \"the final\n> From:\".\n> \n> I guess the bug here is the use of From: to identify the primary author,\n> because transporting the patch via email adds ambiguity.\n> \n> Maybe we should introduce \"^Author:\"?\n\nHow about \"^Written-by:\"? That seems to fit in much more nicely with\n\"Signed-off-by:\".\n \n-- \nschnee\n"},{"id":"4096","messageId":"Pine.LNX.4.58.0505271502240.17402@ppc970.osdl.org","threadId":"736","inReplyTo":"20050527135124.0d98c33e.akpm@osdl.org","subject":"Re: ALSA official git repository","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-27T22:06:42Z","receivedAt":"2005-05-27T22:06:42Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 27 May 2005, Andrew Morton wrote:\n>\n> Yes, I'll occasionally do patches which were written by \"A\" as:\n> \n> From: A\n> ...\n> Signed-off-by: B\n> \n> And that comes through email as:\n> \n> \n> ...\n> From: \n> ...\n> From: A\n> ...\n> Signed-off-by: B\n> \n> \n> which means that the algorithm for identifying the author is \"the final\n> From:\".\n\nNo, the algorithm is:\n - the email author, _or_ if there is one, the top \"From:\" in the body.\n\nAnd the rule is that you never remove (or add to) an existing From:, since \nthe author doesn't change from being passed around.\n\nPut another way: authorship is very different from sign-off. The sign-off \ngets stacked, the authorship is constant, and thus the rules are \ndifferent.\n\nAlso, authorship is more important than sign-off-ship, so authorship goes \nat the top, while sign-offs go at the bottom.\n\n> I guess the bug here is the use of From: to identify the primary author,\n> because transporting the patch via email adds ambiguity.\n\nNo it doesn't, the email \"from\" just ends up being the \"default\" if no \nexplicit authorship is noted.\n\n> Maybe we should introduce \"^Author:\"?\n\nIt would still have the same rules, so it wouldn't change anything but the \ntag, so I don't think there is any real advantage to it.\n\n\t\tLinus\n"},{"id":"4098","messageId":"20050527154625.5490f405.akpm@osdl.org","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505271502240.17402@ppc970.osdl.org","subject":"Re: ALSA official git repository","fromName":"Andrew Morton","fromEmail":"akpm@osdl.org","sentAt":"2005-05-27T22:46:25Z","receivedAt":"2005-05-27T22:46:25Z","isPatch":false,"sender":{"key":"akpm@osdl.org","avatar":null},"body":"Linus Torvalds wrote:\n>\n> > which means that the algorithm for identifying the author is \"the final\n> > From:\".\n> \n> No, the algorithm is:\n> - the email author, _or_ if there is one, the top \"From:\" in the body.\n\nThat all assumes that the tools are smart enough to separate the email\nheaders from the body :(\n\n"},{"id":"4118","messageId":"Pine.LNX.4.58.0505271854300.17402@ppc970.osdl.org","threadId":"736","inReplyTo":"20050527154625.5490f405.akpm@osdl.org","subject":"Re: ALSA official git repository","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-28T02:21:31Z","receivedAt":"2005-05-28T02:21:31Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 27 May 2005, Andrew Morton wrote:\n> \n> That all assumes that the tools are smart enough to separate the email\n> headers from the body :(\n\nWell, _that_ is trivial: the first empty line is the marker between header \nand body. \n\nThis is a stupid awk program to do this:\n\n\t/^From: / { name=$0 }\n\tstate==1 { print name; exit }\n\t/^$/ { state=1 }\n\nOr something. \n\n\n\t\tLinus\n"},{"id":"4122","messageId":"d931cd0e93f6fdc371160db78d0cfeec.ANY@taniwha.stupidest.org","threadId":"736","inReplyTo":"20050527154625.5490f405.akpm@osdl.org","subject":"Re: ALSA official git repository","fromName":"Chris Wedgwood","fromEmail":"cw@f00f.org","sentAt":"2005-05-28T03:33:12Z","receivedAt":"2005-05-28T03:33:12Z","isPatch":false,"sender":{"key":"cw@f00f.org","avatar":null},"body":"On Fri, May 27, 2005 at 03:46:25PM -0700, Andrew Morton wrote:\n\n> That all assumes that the tools are smart enough to separate the email\n> headers from the body :(\n\nthe first blank line separates these, sed can do that --- so is it\nreally a problem?\n\n"},{"id":"4159","messageId":"Pine.LNX.4.58.0505291103080.1748@pnote.perex-int.cz","threadId":"736","inReplyTo":"Pine.LNX.4.58.0505271941250.1757@pnote.perex-int.cz","subject":"Re: ALSA official git repository","fromName":"Jaroslav Kysela","fromEmail":"perex@suse.cz","sentAt":"2005-05-29T09:06:32Z","receivedAt":"2005-05-29T09:06:32Z","isPatch":false,"sender":{"key":"perex@suse.cz","avatar":null},"body":"On Fri, 27 May 2005, Jaroslav Kysela wrote:\n\n> On Fri, 27 May 2005, Linus Torvalds wrote:\n> \n> > On Fri, 27 May 2005, Jaroslav Kysela wrote:\n> > > \n> > > \tI created new git tree for the ALSA project at:\n> > > \n> > > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git\n> > \n> > Your scripts(?) to generate these things are a bit strange, since they\n> > leave an extra empty line in the commit message, which confuses at least\n> > gitweb (ie just look at\n> > \n> > http://www.kernel.org/git/?p=linux/kernel/git/perex/alsa.git;a=summary\n> > \n> > and note how the summary thing looks empty).\n> \n> Okay, sorry for this small bug. I'll recreate the ALSA git tree with\n> proper comments again. Also, the author is not correct (should be taken\n> from the first Signed-off-by:).\n\nThe ALSA git tree is updated with all fixes now. I had an old git version \nwhich inserted this extra line at top of comments.\n\nAlso, it seems that there's a delay between master.kernel.org and git web \ninterface at www.kernel.org (the changes are not on web yet).\n\n\t\t\t\t\t\tJaroslav\n\n-----\nJaroslav Kysela \nLinux Kernel Sound Maintainer\nALSA Project, SUSE Labs\n"}]}