{"thread":{"id":"7354","subject":"[BUG, PATCH] bisect and tags","startedAt":"2007-03-22T16:18:08Z","lastAt":"2007-03-22T16:18:08Z","messageCount":1,"participants":["Uwe Kleine-König"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"37742","messageId":"20070322161808.GA18791@informatik.uni-freiburg.de","threadId":"7354","inReplyTo":null,"subject":"[BUG, PATCH] bisect and tags","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2007-03-22T16:18:08Z","receivedAt":"2007-03-22T16:18:08Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Hello,\n\nzeisberg@cassiopeia:~/gsrc/test$ git init\nInitialized empty Git repository in .git/\nzeisberg@cassiopeia:~/gsrc/test$ echo 0 > 0\nzeisberg@cassiopeia:~/gsrc/test$ git add 0\nzeisberg@cassiopeia:~/gsrc/test$ git commit -m 0\nCreated initial commit fa8382e1b0a75f2abd5b8961ba88caa65e6e0ddc\n 1 files changed, 1 insertions(+), 0 deletions(-)\n create mode 100644 0\nzeisberg@cassiopeia:~/gsrc/test$ echo 1 > 1\nzeisberg@cassiopeia:~/gsrc/test$ git add 1\nzeisberg@cassiopeia:~/gsrc/test$ git commit -m 1\nCreated commit bf00881b13efd325f87899f0fd072566629aedb0\n 1 files changed, 1 insertions(+), 0 deletions(-)\n create mode 100644 1\nzeisberg@cassiopeia:~/gsrc/test$ git tag -m tag tag\nzeisberg@cassiopeia:~/gsrc/test$ git bisect start\nzeisberg@cassiopeia:~/gsrc/test$ git bisect good HEAD^\nzeisberg@cassiopeia:~/gsrc/test$ git bisect bad tag\nBisecting: 1 revisions left to test after this\n[bf00881b13efd325f87899f0fd072566629aedb0] 1\n\nActually the case is already clear here.  But bisect fails to detect\nthat because it doesn't see that tag^{commit} is bad, only tag itself.\n\n--- 8< ---\nBisect: convert revs given to good and bad to commits\n\nWithout this the rev could be (e.g.) a tag and then the condition to end the\nbisect might fail and you have to check the already known to be bad revision\nonce more.\n\nSigned-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>\n---\n git-bisect.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex b1c3a6b..dbce0df 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -85,7 +85,7 @@ bisect_bad() {\n \t0)\n \t\trev=$(git-rev-parse --verify HEAD) ;;\n \t1)\n-\t\trev=$(git-rev-parse --verify \"$1\") ;;\n+\t\trev=$(git-rev-parse --verify \"$1^{commit}\") ;;\n \t*)\n \t\tusage ;;\n \tesac || exit\n@@ -104,7 +104,7 @@ bisect_good() {\n \tesac\n \tfor rev in $revs\n \tdo\n-\t\trev=$(git-rev-parse --verify \"$rev\") || exit\n+\t\trev=$(git-rev-parse --verify \"$rev^{commit}\") || exit\n \t\techo \"$rev\" >\"$GIT_DIR/refs/bisect/good-$rev\"\n \t\techo \"# good: \"$(git-show-branch $rev) >>\"$GIT_DIR/BISECT_LOG\"\n \t\techo \"git-bisect good $rev\" >>\"$GIT_DIR/BISECT_LOG\"\n-- \n1.5.1.rc1.27.g1d848\n\n-- \nUwe Kleine-König\n\nhttp://www.google.com/search?q=1+newton+in+kg*m+%2F+s%5E2\n"}]}