{"thread":{"id":"7319","subject":"[PATCH] Replace remaining instances of strdup with xstrdup.","startedAt":"2007-03-19T21:42:40Z","lastAt":"2007-03-19T21:42:40Z","messageCount":1,"participants":["James Bowes"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"37551","messageId":"1174340560341-git-send-email-jbowes@dangerouslyinc.com","threadId":"7319","inReplyTo":null,"subject":"[PATCH] Replace remaining instances of strdup with xstrdup.","fromName":"James Bowes","fromEmail":"jbowes@dangerouslyinc.com","sentAt":"2007-03-19T21:42:40Z","receivedAt":"2007-03-19T21:42:40Z","isPatch":true,"sender":{"key":"jbowes@dangerouslyinc.com","avatar":"https://gravatar.com/avatar/a2fe98c66b2b47a9fa9d2ba92ff949d54c3208b1f8acc2e745b4b84ae3c4483a?d=mp&s=160"},"body":"Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>\n---\n\nThis is a blatant copy of Shawn's patch. I don't know if there's a reason these\nare still strdup. If there is, please ignore this patch :)\n\n builtin-log.c |    2 +-\n commit.c      |    2 +-\n revision.c    |    2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex 865832c..71df957 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -35,7 +35,7 @@ static void cmd_log_init(int argc, const char **argv, const char *prefix,\n \t\tif (!prefixcmp(arg, \"--encoding=\")) {\n \t\t\targ += 11;\n \t\t\tif (strcmp(arg, \"none\"))\n-\t\t\t\tgit_log_output_encoding = strdup(arg);\n+\t\t\t\tgit_log_output_encoding = xstrdup(arg);\n \t\t\telse\n \t\t\t\tgit_log_output_encoding = \"\";\n \t\t}\ndiff --git a/commit.c b/commit.c\nindex 5b9234e..718e568 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -706,7 +706,7 @@ static char *logmsg_reencode(const struct commit *commit,\n \tencoding = get_header(commit, \"encoding\");\n \tuse_encoding = encoding ? encoding : utf8;\n \tif (!strcmp(use_encoding, output_encoding))\n-\t\tout = strdup(commit->buffer);\n+\t\tout = xstrdup(commit->buffer);\n \telse\n \t\tout = reencode_string(commit->buffer,\n \t\t\t\t      output_encoding, use_encoding);\ndiff --git a/revision.c b/revision.c\nindex bcdb6a1..c680dcb 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -1038,7 +1038,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch\n \t\t\tif (!prefixcmp(arg, \"--encoding=\")) {\n \t\t\t\targ += 11;\n \t\t\t\tif (strcmp(arg, \"none\"))\n-\t\t\t\t\tgit_log_output_encoding = strdup(arg);\n+\t\t\t\t\tgit_log_output_encoding = xstrdup(arg);\n \t\t\t\telse\n \t\t\t\t\tgit_log_output_encoding = \"\";\n \t\t\t\tcontinue;\n-- \n1.5.1.rc1.1.g504b\n"}]}