{"thread":{"id":"7261","subject":"[PATCH] use xstrdup please","startedAt":"2007-03-16T01:02:51Z","lastAt":"2007-03-16T01:02:51Z","messageCount":1,"participants":["Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"37186","messageId":"20070316010251.GA31023@spearce.org","threadId":"7261","inReplyTo":null,"subject":"[PATCH] use xstrdup please","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-03-16T01:02:51Z","receivedAt":"2007-03-16T01:02:51Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"We generally prefer xstrdup to just plain strdup.\nMake it so.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n config.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/config.c b/config.c\nindex a3c7b77..d537311 100644\n--- a/config.c\n+++ b/config.c\n@@ -351,12 +351,12 @@ int git_default_config(const char *var, const char *value)\n \t}\n \n \tif (!strcmp(var, \"i18n.commitencoding\")) {\n-\t\tgit_commit_encoding = strdup(value);\n+\t\tgit_commit_encoding = xstrdup(value);\n \t\treturn 0;\n \t}\n \n \tif (!strcmp(var, \"i18n.logoutputencoding\")) {\n-\t\tgit_log_output_encoding = strdup(value);\n+\t\tgit_log_output_encoding = xstrdup(value);\n \t\treturn 0;\n \t}\n \n-- \n1.5.0.4.1009.gd3da\n"}]}