{"thread":{"id":"7121","subject":"[PATCH] Support of \"make -s\": do not output anything of the build itself","startedAt":"2007-03-06T23:14:30Z","lastAt":"2007-03-06T23:59:03Z","messageCount":5,"participants":["Alex Riesen","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"36493","messageId":"81b0412b0703061514m2f2b3237yd1192dd651a1109e@mail.gmail.com","threadId":"7121","inReplyTo":null,"subject":"[PATCH] Support of \"make -s\": do not output anything of the build itself","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-06T23:14:30Z","receivedAt":"2007-03-06T23:14:30Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n Makefile         |   10 +++++++---\n git-gui/Makefile |    5 -----\n 2 files changed, 7 insertions(+), 8 deletions(-)\n\n\nFrom d433ed1d682b64eb4a8ac1cb55bc568e0f0f10f0 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Tue, 6 Mar 2007 23:57:55 +0100\nSubject: [PATCH] Support of \"make -s\": do not output anything of the build itself\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n Makefile         |   10 +++++++---\n git-gui/Makefile |    5 -----\n 2 files changed, 7 insertions(+), 8 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex eb6c421..983da60 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -604,6 +604,11 @@ endif\n ifdef NO_PERL_MAKEMAKER\n \texport NO_PERL_MAKEMAKER\n endif\n+\n+QUIET_SUBDIR0  = $(MAKE) -C # space to separate -C and subdir\n+QUIET_SUBDIR1  =\n+\n+ifneq ($(findstring $(MAKEFLAGS),s),s)\n ifndef V\n \tQUIET_CC       = @echo '   ' CC $@;\n \tQUIET_AR       = @echo '   ' AR $@;\n@@ -615,9 +620,8 @@ ifndef V\n \t\t\t $(MAKE) --no-print-directory -C $$subdir\n \texport V\n \texport QUIET_GEN\n-else\n-\tQUIET_SUBDIR0  = $(MAKE) -C\n-\tQUIET_SUBDIR1  =\n+\texport QUIET_BUILT_IN\n+endif\n endif\n \n # Shell quote (do not use $(call) to accommodate ancient setups);\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex e486e8f..4f3fc74 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -22,11 +22,6 @@ ifndef INSTALL\n \tINSTALL = install\n endif\n \n-ifndef V\n-\tQUIET_GEN      = @echo '   ' GEN $@;\n-\tQUIET_BUILT_IN = @echo '   ' BUILTIN $@;\n-endif\n-\n DESTDIR_SQ = $(subst ','\\'',$(DESTDIR))\n gitexecdir_SQ = $(subst ','\\'',$(gitexecdir))\n SHELL_PATH_SQ = $(subst ','\\'',$(SHELL_PATH))\n-- \n1.5.0.3.410.gca42\n\n"},{"id":"36498","messageId":"20070306232927.GB25785@spearce.org","threadId":"7121","inReplyTo":"81b0412b0703061514m2f2b3237yd1192dd651a1109e@mail.gmail.com","subject":"Re: [PATCH] Support of \"make -s\": do not output anything of the build itself","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-03-06T23:29:27Z","receivedAt":"2007-03-06T23:29:27Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Alex Riesen <raa.lkml@gmail.com> wrote:\n> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n> ---\n> Makefile         |   10 +++++++---\n> git-gui/Makefile |    5 -----\n> 2 files changed, 7 insertions(+), 8 deletions(-)\n\nNack.  You need to split any git-gui changes into their own patch\nso that I can apply them to the git-gui repository directly.\nJunio then merges that into git.git.\n\n> +QUIET_SUBDIR0  = $(MAKE) -C # space to separate -C and subdir\n> +QUIET_SUBDIR1  =\n> +\n> +ifneq ($(findstring $(MAKEFLAGS),s),s)\n\nThis is a good idea.\n\n>  ifndef V\n>  \tQUIET_CC       = @echo '   ' CC $@;\n>  \tQUIET_AR       = @echo '   ' AR $@;\n> @@ -615,9 +620,8 @@ ifndef V\n>  \t\t\t $(MAKE) --no-print-directory -C $$subdir\n>  \texport V\n>  \texport QUIET_GEN\n> -else\n> -\tQUIET_SUBDIR0  = $(MAKE) -C\n> -\tQUIET_SUBDIR1  =\n> +\texport QUIET_BUILT_IN\n> +endif\n>  endif\n\n> diff --git a/git-gui/Makefile b/git-gui/Makefile\n> -ifndef V\n> -\tQUIET_GEN      = @echo '   ' GEN $@;\n> -\tQUIET_BUILT_IN = @echo '   ' BUILTIN $@;\n> -endif\n> -\n\ngit-gui can be built on its own, outside of git.git's make system.\nI need the ifneq(...-s...) thing above also here, around the\nexisting ifndef.\n\nWant to rework the patch as two?  ;-)\n\n-- \nShawn.\n"},{"id":"36499","messageId":"81b0412b0703061533o532dfeedo1aeb65723717227a@mail.gmail.com","threadId":"7121","inReplyTo":"20070306232927.GB25785@spearce.org","subject":"Re: [PATCH] Support of \"make -s\": do not output anything of the build itself","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-06T23:33:25Z","receivedAt":"2007-03-06T23:33:25Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"This message will break the thread (which is short yet). Gmail again,\nbut I really want it to get to the list.\n\nOn 3/7/07, Shawn O. Pearce <spearce@spearce.org> wrote:\n> Alex Riesen <raa.lkml@gmail.com> wrote:\n> > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n> > ---\n> > Makefile         |   10 +++++++---\n> > git-gui/Makefile |    5 -----\n> > 2 files changed, 7 insertions(+), 8 deletions(-)\n>\n> Nack.  You need to split any git-gui changes into their own patch\n> so that I can apply them to the git-gui repository directly.\n\nRight. Sorry, I completely forgot about that. Will redo it.\n\n> git-gui can be built on its own, outside of git.git's make system.\n> I need the ifneq(...-s...) thing above also here, around the\n> existing ifndef.\n>\n> Want to rework the patch as two?  ;-)\n\nWill do.\n\nP.S. I'm glad that someone can here me from here :)\n"},{"id":"36500","messageId":"81b0412b0703061556o2b648b58kaf1116ba29485d3@mail.gmail.com","threadId":"7121","inReplyTo":"81b0412b0703061533o532dfeedo1aeb65723717227a@mail.gmail.com","subject":"Re: [PATCH] Support of \"make -s\": do not output anything of the build itself","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-06T23:56:30Z","receivedAt":"2007-03-06T23:56:30Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 3/7/07, Alex Riesen <raa.lkml@gmail.com> wrote:\n>\n> P.S. I'm glad that someone can here me from here :)\n>\n\n\"Hear\", of course. And it does not seem to work really...\n"},{"id":"36502","messageId":"81b0412b0703061559v7a42c8d8t5b9ecdb0fa6d0d47@mail.gmail.com","threadId":"7121","inReplyTo":"81b0412b0703061533o532dfeedo1aeb65723717227a@mail.gmail.com","subject":"[PATCH] Support of \"make -s\": do not output anything of the build itself","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-06T23:59:03Z","receivedAt":"2007-03-06T23:59:03Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n\n---\n Makefile |   10 +++++++---\n 1 files changed, 7 insertions(+), 3 deletions(-)\n\n\nFrom f741856c82aa840a198e3d751a1721b225b5b433 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Wed, 7 Mar 2007 00:44:49 +0100\nSubject: [PATCH] Support of \"make -s\": do not output anything of the build itself\n\n---\n Makefile |   10 +++++++---\n 1 files changed, 7 insertions(+), 3 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex eb6c421..983da60 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -604,6 +604,11 @@ endif\n ifdef NO_PERL_MAKEMAKER\n \texport NO_PERL_MAKEMAKER\n endif\n+\n+QUIET_SUBDIR0  = $(MAKE) -C # space to separate -C and subdir\n+QUIET_SUBDIR1  =\n+\n+ifneq ($(findstring $(MAKEFLAGS),s),s)\n ifndef V\n \tQUIET_CC       = @echo '   ' CC $@;\n \tQUIET_AR       = @echo '   ' AR $@;\n@@ -615,9 +620,8 @@ ifndef V\n \t\t\t $(MAKE) --no-print-directory -C $$subdir\n \texport V\n \texport QUIET_GEN\n-else\n-\tQUIET_SUBDIR0  = $(MAKE) -C\n-\tQUIET_SUBDIR1  =\n+\texport QUIET_BUILT_IN\n+endif\n endif\n \n # Shell quote (do not use $(call) to accommodate ancient setups);\n-- \n1.5.0.3.430.g5573f\n\n"}]}